From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 847ADC43331 for ; Tue, 12 Nov 2019 10:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58AF620674 for ; Tue, 12 Nov 2019 10:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573555198; bh=b4WMMkvRkImRLDoMsQKNzUFF3wEIW6Af2ngHCdd2yRk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pUrXGFeIffprvZAwGNetV9gc75divCDhVDIRAXDaG+uZSaSk4GgvzJlp3W96Vv9fc IIiLtl8rAxn5JA1/t5GOcvVQD1f9SrvBh7yswbVLd1ju0ZpROB9EN2OqcG3DIfVZFJ cAp4uFyHqRbqtDzThuT4OtM4lYAsqBC8DnltuEbc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726659AbfKLKj6 (ORCPT ); Tue, 12 Nov 2019 05:39:58 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:34923 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbfKLKj5 (ORCPT ); Tue, 12 Nov 2019 05:39:57 -0500 Received: by mail-lf1-f66.google.com with SMTP id i26so1356135lfl.2; Tue, 12 Nov 2019 02:39:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XWXqgjsblbcyWM0h2meBDVZ+XPFRuLEW2MPm0S54S/s=; b=CTVAyYnT5d6NFMoTSwruMSYLoQz31YwMh9f1b2imH4VEgUZqDunjh4OAZ0qiGkpMU4 2yyYvSmP/mCBvvzXw6+syV4fitEOKf6Xv29FqALV9M+3YnhzKPOTM5NjSPKaMvmlZJOl H1OVAk3AggiVh8sNvwPUP5fcBb/SCxxC+L1AlFCYp1lMnLMJsa2fZ7HMIaodqMGq8x1R d9mXNlWJXeWyv20bvSUJewbMbg1TnYDJCoo4oz1b21dfWaFvROuCVZF5wXZ5sZ8IQXbH 60XoAVLZoVF/zmJ6ohHK7uFPzhP4N5Cq88cl4vPaMVq3Iz31e3vyFdSosmFZz9UHKLM+ DFIA== X-Gm-Message-State: APjAAAXYPD1CN/dYvjmx9RDiixBwB8WCvp6aiseDojWCHXAgbc9lJZlu 4Sz7/vHAlzl8pCjcACPineI= X-Google-Smtp-Source: APXvYqxbw5J+tzBKcx+QigjOviaP1PWngnIR6FhtuOsFfYfySEHZWhgInymsNuVEPwxpwVY/mq8xpg== X-Received: by 2002:a05:6512:21e:: with SMTP id a30mr8849014lfo.76.1573555194825; Tue, 12 Nov 2019 02:39:54 -0800 (PST) Received: from xi.terra (c-51f1e055.07-184-6d6c6d4.bbcust.telenor.se. [85.224.241.81]) by smtp.gmail.com with ESMTPSA id d24sm3344144ljg.73.2019.11.12.02.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 02:39:54 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.92.3) (envelope-from ) id 1iUTab-0000IZ-1b; Tue, 12 Nov 2019 11:40:01 +0100 Date: Tue, 12 Nov 2019 11:40:01 +0100 From: Johan Hovold To: Rob Clark , Sean Paul , Daniel Vetter Cc: David Airlie , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman , Johan Hovold , stable , Jordan Crouse , Harald Freudenberger , Mauro Carvalho Chehab , Fabien Dessenne Subject: Re: [PATCH 1/4] drm/msm: fix memleak on release Message-ID: <20191112104001.GP11035@localhost> References: <20191010131333.23635-1-johan@kernel.org> <20191010131333.23635-2-johan@kernel.org> <20191030100146.GC4691@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030100146.GC4691@localhost> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Oct 30, 2019 at 11:01:46AM +0100, Johan Hovold wrote: > On Thu, Oct 10, 2019 at 03:13:30PM +0200, Johan Hovold wrote: > > If a process is interrupted while accessing the "gpu" debugfs file and > > the drm device struct_mutex is contended, release() could return early > > and fail to free related resources. > > > > Note that the return value from release() is ignored. > > > > Fixes: 4f776f4511c7 ("drm/msm/gpu: Convert the GPU show function to use the GPU state") > > Cc: stable # 4.18 > > Cc: Jordan Crouse > > Cc: Rob Clark > > Signed-off-by: Johan Hovold > > --- > > Rob, Sean, > > Sending a reminder about this one, which is not yet in linux-next. > > Perhaps Daniel can pick it up otherwise? Another two weeks, another reminder. This one is still not in -next. Johan > > drivers/gpu/drm/msm/msm_debugfs.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c > > index 6be879578140..1c74381a4fc9 100644 > > --- a/drivers/gpu/drm/msm/msm_debugfs.c > > +++ b/drivers/gpu/drm/msm/msm_debugfs.c > > @@ -47,12 +47,8 @@ static int msm_gpu_release(struct inode *inode, struct file *file) > > struct msm_gpu_show_priv *show_priv = m->private; > > struct msm_drm_private *priv = show_priv->dev->dev_private; > > struct msm_gpu *gpu = priv->gpu; > > - int ret; > > - > > - ret = mutex_lock_interruptible(&show_priv->dev->struct_mutex); > > - if (ret) > > - return ret; > > > > + mutex_lock(&show_priv->dev->struct_mutex); > > gpu->funcs->gpu_state_put(show_priv->state); > > mutex_unlock(&show_priv->dev->struct_mutex); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB10C17440 for ; Tue, 12 Nov 2019 10:39:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CBDA222CD for ; Tue, 12 Nov 2019 10:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CBDA222CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 80F186EB00; Tue, 12 Nov 2019 10:39:58 +0000 (UTC) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id 966A66E3EC; Tue, 12 Nov 2019 10:39:56 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id j26so5328207lfh.7; Tue, 12 Nov 2019 02:39:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XWXqgjsblbcyWM0h2meBDVZ+XPFRuLEW2MPm0S54S/s=; b=L2JboYZ3gg+oFl8izuBGzPzVM3y2adU/wawLStkCRpKtDyzNs/eaHKSZ2npBnjJ8c+ tZoSOn4vsAQiGtmH2xKFHUK3mBKWn+MczP6dkICB9Cx3Mj5R/WDLbVREa7U7DrD4X4dz DhBrVG8Vmh6misW02lFRIM1d4S3DTr1Ao/VtY0/DQtQ0JVbRPBdjsQ2Nk4Gf43n4FxZj PlXIVHV4gVzudD/o2WGTmssX/fi22GHBW2Fb7QdqXk5wE0MAZbU4l6mNFQovd66ZmY4H isQPw/wInZ8CT/txplUVJrysuUFIw3VloEr9Ph2/++kU/JGJnOR1kpCb5n3BhdmGqcWh L1jw== X-Gm-Message-State: APjAAAXkJY6Ka1TtlJZ/YtNM3c8xvYA4Uo+RqGQFLB+qgKxqpcW3Jd2v DiWVjECg2bsGm5ELn1k45nw= X-Google-Smtp-Source: APXvYqxbw5J+tzBKcx+QigjOviaP1PWngnIR6FhtuOsFfYfySEHZWhgInymsNuVEPwxpwVY/mq8xpg== X-Received: by 2002:a05:6512:21e:: with SMTP id a30mr8849014lfo.76.1573555194825; Tue, 12 Nov 2019 02:39:54 -0800 (PST) Received: from xi.terra (c-51f1e055.07-184-6d6c6d4.bbcust.telenor.se. [85.224.241.81]) by smtp.gmail.com with ESMTPSA id d24sm3344144ljg.73.2019.11.12.02.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 02:39:54 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.92.3) (envelope-from ) id 1iUTab-0000IZ-1b; Tue, 12 Nov 2019 11:40:01 +0100 Date: Tue, 12 Nov 2019 11:40:01 +0100 From: Johan Hovold To: Rob Clark , Sean Paul , Daniel Vetter Subject: Re: [PATCH 1/4] drm/msm: fix memleak on release Message-ID: <20191112104001.GP11035@localhost> References: <20191010131333.23635-1-johan@kernel.org> <20191010131333.23635-2-johan@kernel.org> <20191030100146.GC4691@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191030100146.GC4691@localhost> User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Vasily Gorbik , David Airlie , linux-arm-msm@vger.kernel.org, Heiko Carstens , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Johan Hovold , Fabien Dessenne , Christian Borntraeger , Harald Freudenberger , stable , Greg Kroah-Hartman , Mauro Carvalho Chehab , freedreno@lists.freedesktop.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191112104001.OpGYGoy_D4m8V954Ts6RQyZ-VvFkQZDRO_sMauYVek0@z> T24gV2VkLCBPY3QgMzAsIDIwMTkgYXQgMTE6MDE6NDZBTSArMDEwMCwgSm9oYW4gSG92b2xkIHdy b3RlOgo+IE9uIFRodSwgT2N0IDEwLCAyMDE5IGF0IDAzOjEzOjMwUE0gKzAyMDAsIEpvaGFuIEhv dm9sZCB3cm90ZToKPiA+IElmIGEgcHJvY2VzcyBpcyBpbnRlcnJ1cHRlZCB3aGlsZSBhY2Nlc3Np bmcgdGhlICJncHUiIGRlYnVnZnMgZmlsZSBhbmQKPiA+IHRoZSBkcm0gZGV2aWNlIHN0cnVjdF9t dXRleCBpcyBjb250ZW5kZWQsIHJlbGVhc2UoKSBjb3VsZCByZXR1cm4gZWFybHkKPiA+IGFuZCBm YWlsIHRvIGZyZWUgcmVsYXRlZCByZXNvdXJjZXMuCj4gPiAKPiA+IE5vdGUgdGhhdCB0aGUgcmV0 dXJuIHZhbHVlIGZyb20gcmVsZWFzZSgpIGlzIGlnbm9yZWQuCj4gPiAKPiA+IEZpeGVzOiA0Zjc3 NmY0NTExYzcgKCJkcm0vbXNtL2dwdTogQ29udmVydCB0aGUgR1BVIHNob3cgZnVuY3Rpb24gdG8g dXNlIHRoZSBHUFUgc3RhdGUiKQo+ID4gQ2M6IHN0YWJsZSA8c3RhYmxlQHZnZXIua2VybmVsLm9y Zz4gICAgICMgNC4xOAo+ID4gQ2M6IEpvcmRhbiBDcm91c2UgPGpjcm91c2VAY29kZWF1cm9yYS5v cmc+Cj4gPiBDYzogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgo+ID4gU2lnbmVkLW9m Zi1ieTogSm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPgo+ID4gLS0tCj4gCj4gUm9iLCBT ZWFuLAo+IAo+IFNlbmRpbmcgYSByZW1pbmRlciBhYm91dCB0aGlzIG9uZSwgd2hpY2ggaXMgbm90 IHlldCBpbiBsaW51eC1uZXh0Lgo+IAo+IFBlcmhhcHMgRGFuaWVsIGNhbiBwaWNrIGl0IHVwIG90 aGVyd2lzZT8KCkFub3RoZXIgdHdvIHdlZWtzLCBhbm90aGVyIHJlbWluZGVyLiBUaGlzIG9uZSBp cyBzdGlsbCBub3QgaW4gLW5leHQuCgpKb2hhbgoKPiA+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL21z bV9kZWJ1Z2ZzLmMgfCA2ICstLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgNSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9t c20vbXNtX2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2RlYnVnZnMuYwo+ID4g aW5kZXggNmJlODc5NTc4MTQwLi4xYzc0MzgxYTRmYzkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vbXNtL21zbV9kZWJ1Z2ZzLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20v bXNtX2RlYnVnZnMuYwo+ID4gQEAgLTQ3LDEyICs0Nyw4IEBAIHN0YXRpYyBpbnQgbXNtX2dwdV9y ZWxlYXNlKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdCBmaWxlICpmaWxlKQo+ID4gIAlzdHJ1 Y3QgbXNtX2dwdV9zaG93X3ByaXYgKnNob3dfcHJpdiA9IG0tPnByaXZhdGU7Cj4gPiAgCXN0cnVj dCBtc21fZHJtX3ByaXZhdGUgKnByaXYgPSBzaG93X3ByaXYtPmRldi0+ZGV2X3ByaXZhdGU7Cj4g PiAgCXN0cnVjdCBtc21fZ3B1ICpncHUgPSBwcml2LT5ncHU7Cj4gPiAtCWludCByZXQ7Cj4gPiAt Cj4gPiAtCXJldCA9IG11dGV4X2xvY2tfaW50ZXJydXB0aWJsZSgmc2hvd19wcml2LT5kZXYtPnN0 cnVjdF9tdXRleCk7Cj4gPiAtCWlmIChyZXQpCj4gPiAtCQlyZXR1cm4gcmV0Owo+ID4gIAo+ID4g KwltdXRleF9sb2NrKCZzaG93X3ByaXYtPmRldi0+c3RydWN0X211dGV4KTsKPiA+ICAJZ3B1LT5m dW5jcy0+Z3B1X3N0YXRlX3B1dChzaG93X3ByaXYtPnN0YXRlKTsKPiA+ICAJbXV0ZXhfdW5sb2Nr KCZzaG93X3ByaXYtPmRldi0+c3RydWN0X211dGV4KTsKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVs