From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4480AC43331 for ; Tue, 12 Nov 2019 10:49:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1A222084E for ; Tue, 12 Nov 2019 10:49:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lwpHTr8R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Euto9/lQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1A222084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=esdl5eok+3hu9bqAbA4EmrHNzTXtNhEOgKvgO3DyaZU=; b=lwpHTr8Rszd9XL lE4gczKIhyIYnDYxXte3nM8CRZgIoZN+Vi822mjktOkPRqFoAHL4Dtl4oYDKE89xX+jjoBQ0HQYx5 BzQEwg9ep96Ve0OUCEQjhzO//c6rYGV5NbLiI9Hh+lYihYF7uDZKeQ79lXq1/azp5jlBGpwIJ3/OH EyDsQkcqPeZFbiPTccfcZVBAclX3bG/AmkvtqpnMV4sB+KvaFsPEK8Pc+Dn0C3GsqfvLgpCzjk/SV u5N6WHmJ2H7pKB4EBpqHVbN+7CUdSbD9WQp8sVsiYTjdsU8u/6fSYKVTVHBSJnsXe721MOTBDnTxc G1Q1cGrS0TQdCQIWITnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUTjb-0000GW-IG; Tue, 12 Nov 2019 10:49:19 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUTjP-000069-G0 for linux-amlogic@lists.infradead.org; Tue, 12 Nov 2019 10:49:09 +0000 Received: by mail-wm1-x343.google.com with SMTP id 8so2434692wmo.0 for ; Tue, 12 Nov 2019 02:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=cGBOxzPSbBShIku6cnlQrmVn7eBeOMTad4fgKmfaiFg=; b=Euto9/lQ4Xwt8ZRKGQSpeBv2obGwPp0u/+pHm60h9VTX/05YlZOdCRCI1JzXVpLwm5 l3g5u9AFmtrm3QcRsRuxM1XCIckSOBQlVGjQfackXRDKAGPfxGCGPr2ts4qmE3SI7Lfa qyt0jnRdqJhvES9HKhPlZxKoPX4Q0FbVDo2FOC4Yzl+Bl6Xf3IPU/0ngPAt6xaCWtibg UTc8mO7c9XiPGZ0CWumWdpueA3Ij/0fnZhjAvhY3vrWGa4BjuE60H6SiPQn9SD+rn953 yVVMks7re251j1u6UBWrXfef46kcrzBmy8gCmxIv2xCOGSjIP9dlaZzQrTTtl7GEk6u6 0lDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cGBOxzPSbBShIku6cnlQrmVn7eBeOMTad4fgKmfaiFg=; b=la4ymfbOPtZeNZIAt5ElI2spNrra/ZeaCC8St/f79fnff3Nvxj4zC4Lf1SNl6nNxIl ykEq2QJEjltkjqz1KgVq2tVMr/BFDD1TFyUP/q+3d29lCn+LGSQNXAK201CD2YsSQmnd 8Viza5QPWd6wJ3a9ZQfpAyWhlu41kSnKtt5cycK1MpMHukBw2DcWgUmWjZoXPfTyH9tW WrTYA41JidBzuGklFaPlewBAm+TwCjvg4exP/dv8XvXEK3c2Jp4FwyT6WrbnCSL8Wdfv OfJeX9/ThIxoxAWvnVfy78Z7KFVyuSOnm/pZAJ0dd4kMp4gBf8QwzcyaSVOXr/tDOn8p 8WRA== X-Gm-Message-State: APjAAAXkqYjusOrWvIluvZB3kagDjBR4ebVUjBBXIF0O2SmRNvNTuXb6 GikNPkikMneyy4dp6q82y4uRgfQvbmo= X-Google-Smtp-Source: APXvYqzZj+j6WLZsmzeULWLgYPCNF9UMEvYlEH8Wd9m5JB3mfTBRFsR7TnMXmSIlEe9absXUaF8dMQ== X-Received: by 2002:a05:600c:2202:: with SMTP id z2mr3210310wml.162.1573555745515; Tue, 12 Nov 2019 02:49:05 -0800 (PST) Received: from dell ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id n65sm4341325wmf.28.2019.11.12.02.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 02:49:05 -0800 (PST) Date: Tue, 12 Nov 2019 10:48:56 +0000 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] base: soc: Export soc_device_to_device() helper Message-ID: <20191112104856.GQ3218@dell> References: <20191103013645.9856-3-afaerber@suse.de> <20191111045609.7026-1-afaerber@suse.de> <20191111052741.GB3176397@kroah.com> <586fa37c-6292-aca4-fa7c-73064858afaf@suse.de> <20191111064040.GA3502217@kroah.com> <20191112052347.GA1197504@kroah.com> <20191112072926.isjxfa4ci6akhx56@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112072926.isjxfa4ci6akhx56@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_024907_545583_BA03A372 X-CRM114-Status: GOOD ( 25.89 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , linux-realtek-soc@lists.infradead.org, Tony Lindgren , Linus Walleij , Bjorn Andersson , Thierry Reding , Fabio Estevam , Kevin Hilman , "Rafael J. Wysocki" , Michal Simek , Jonathan Hunter , NXP Linux Team , Sascha Hauer , "linux-tegra@vger.kernel.org" , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, Alexander Sverdlin , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Hartley Sweeten , Pengutronix Kernel Team , Shawn Guo , Andreas =?iso-8859-1?Q?F=E4rber?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxMiBOb3YgMjAxOSwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cgo+IE9uIFR1ZSwg Tm92IDEyLCAyMDE5IGF0IDA2OjIzOjQ3QU0gKzAxMDAsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90 ZToKPiA+IE9uIE1vbiwgTm92IDExLCAyMDE5IGF0IDA5OjEwOjQxUE0gKzAxMDAsIEFuZHJlYXMg RsOkcmJlciB3cm90ZToKPiA+ID4gQW0gMTEuMTEuMTkgdW0gMDc6NDAgc2NocmllYiBHcmVnIEty b2FoLUhhcnRtYW46Cj4gPiA+ID4gT24gTW9uLCBOb3YgMTEsIDIwMTkgYXQgMDY6NDI6MDVBTSAr MDEwMCwgQW5kcmVhcyBGw6RyYmVyIHdyb3RlOgo+ID4gPiA+PiBIaSBHcmVnLAo+ID4gPiA+Pgo+ ID4gPiA+PiBBbSAxMS4xMS4xOSB1bSAwNjoyNyBzY2hyaWViIEdyZWcgS3JvYWgtSGFydG1hbjoK PiA+ID4gPj4+IE9uIE1vbiwgTm92IDExLCAyMDE5IGF0IDA1OjU2OjA5QU0gKzAxMDAsIEFuZHJl YXMgRsOkcmJlciB3cm90ZToKPiA+ID4gPj4+PiBVc2Ugb2Ygc29jX2RldmljZV90b19kZXZpY2Uo KSBpbiBkcml2ZXIgbW9kdWxlcyBjYXVzZXMgYSBidWlsZCBmYWlsdXJlLgo+ID4gPiA+Pj4+IEdp dmVuIHRoYXQgdGhlIGhlbHBlciBpcyBuaWNlbHkgZG9jdW1lbnRlZCBpbiBpbmNsdWRlL2xpbnV4 L3N5c19zb2MuaCwKPiA+ID4gPj4+PiBsZXQncyBleHBvcnQgaXQgYXMgR1BMIHN5bWJvbC4KPiA+ ID4gPj4+Cj4gPiA+ID4+PiBJIHRob3VnaHQgd2Ugd2VyZSBmaXhpbmcgdGhlIHNvYyBkcml2ZXJz IHRvIG5vdCBuZWVkIHRoaXMuICBXaGF0Cj4gPiA+ID4+PiBoYXBwZW5lZCB0byB0aGF0IGVmZm9y dD8gIEkgdGhvdWdodCBJIGhhZCBwYXRjaGVzIGluIG15IHRyZWUgKG9yCj4gPiA+ID4+PiBzb21l b25lJ3MgdHJlZSkgdGhhdCBkaWQgc29tZSBvZiB0aGlzIHdvcmsgYWxyZWFkeSwgc3VjaCB0aGF0 IHRoaXMKPiA+ID4gPj4+IHN5bWJvbCBpc24ndCBuZWVkZWQgYW55bW9yZS4KPiA+ID4gPj4KPiA+ ID4gPj4gSSBkbyBzdGlsbCBzZWUgdGhpcyBmdW5jdGlvbiB1c2VkIGluIG5leHQtMjAxOTExMDgg aW4gZHJpdmVycy9zb2MvLgo+ID4gPiA+Pgo+ID4gPiA+PiBJJ2xsIGJlIGhhcHB5IHRvIGFkanVz dCBteSBSRkMgZHJpdmVyIGlmIHNvbWVvbmUgcG9pbnRzIG1lIHRvIGhvdyEKPiA+ID4gPiAKPiA+ ID4gPiBMb29rIGF0IGMzMWU3MzEyMWY0YyAoImJhc2U6IHNvYzogSGFuZGxlIGN1c3RvbSBzb2Mg aW5mb3JtYXRpb24gc3lzZnMKPiA+ID4gPiBlbnRyaWVzIikgZm9yIGhvdyB5b3UgY2FuIGp1c3Qg dXNlIHRoZSBkZWZhdWx0IGF0dHJpYnV0ZXMgZm9yIHRoZSBzb2MgdG8KPiA+ID4gPiBjcmVhdGUg dGhlIG5lZWRlZCBzeXNmcyBmaWxlcywgaW5zdGVhZCBvZiBoYXZpbmcgdG8gZG8gaXQgImJ5IGhh bmQiCj4gPiA+ID4gd2hpY2ggaXMgcmFjeSBhbmQgaW5jb3JyZWN0Lgo+ID4gPiAKPiA+ID4gVW5y ZWxhdGVkLgo+ID4gPiAKPiA+ID4gPj4gR2l2ZW4gdGhlIGN1cnJlbnQgc3RydWN0IGxheW91dCwg YSB0eXBlIGNhc3QgbWlnaHQgd29yayAoYnV0IHVnbHkpLgo+ID4gPiA+PiBPciBpZiB3ZSBzdGF5 IHdpdGggbXkgY3VycmVudCBSRkMgZHJpdmVyIGRlc2lnbiwgd2UgY291bGQgdXNlIHRoZQo+ID4g PiA+PiBwbGF0Zm9ybV9kZXZpY2UgaW5zdGVhZCBvZiB0aGUgc29jX2RldmljZSAod2hpY2ggd291 bGQgY2x1dHRlciB0aGUKPiA+ID4gPj4gc2NyZWVuIG1vcmUgdGhhbiAic29jIHNvYzA6Iikgb3Ig cmVzb3J0IHRvIHByX2luZm8oKSB3L28gZGV2aWNlLgo+ID4gPiA+IAo+ID4gPiA+IEljaywgbm8s IGRvbid0IGNhc3QgYmxpbmRseS4gIFdoYXQgZG8geW91IG5lZWQgdGhlIHBvaW50ZXIgZm9yPyAg SXMgdGhpcwo+ID4gPiA+IGZvciBpbi10cmVlIGNvZGU/Cj4gPiA+IAo+ID4gPiBObywgYW4gUkZD IHBhdGNoc2V0OiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL2NvdmVyLzExMjI0MjYxLwo+ ID4gPiAKPiA+ID4gQXMgSSBpbmRpY2F0ZWQgYWJvdmUsIEkgdXNlZCBpdCBmb3IgYSBkZXZfaW5m bygpLCB3aGljaCBJIGNhbiBlYXNpbHkKPiA+ID4gYXZvaWQgYnkgdXNpbmcgcHJfaW5mbygpIGlu c3RlYWQ6Cj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2MvcmVhbHRlay9jaGlw LmMgYi9kcml2ZXJzL3NvYy9yZWFsdGVrL2NoaXAuYwo+ID4gPiBpbmRleCBlNTA3OGM2NzMxZmQu LmY5MzgwZTgzMTY1OSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9zb2MvcmVhbHRlay9jaGlw LmMKPiA+ID4gKysrIGIvZHJpdmVycy9zb2MvcmVhbHRlay9jaGlwLmMKPiA+ID4gQEAgLTE3OCw4 ICsxNzgsNyBAQCBzdGF0aWMgaW50IHJ0ZF9zb2NfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKPiA+ID4gCj4gPiA+ICAgICAgICAgcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwg c29jX2Rldik7Cj4gPiA+IAo+ID4gPiAtICAgICAgIGRldl9pbmZvKHNvY19kZXZpY2VfdG9fZGV2 aWNlKHNvY19kZXYpLAo+ID4gPiAtICAgICAgICAgICAgICAgIiVzICVzICgweCUwOHgpIHJldiAl cyAoMHglMDh4KSBkZXRlY3RlZFxuIiwKPiA+ID4gKyAgICAgICBwcl9pbmZvKCIlcyAlcyAoMHgl MDh4KSByZXYgJXMgKDB4JTA4eCkgZGV0ZWN0ZWRcbiIsCj4gPiA+ICAgICAgICAgICAgICAgICBz b2NfZGV2X2F0dHItPmZhbWlseSwgc29jX2Rldl9hdHRyLT5zb2NfaWQsIGNoaXBfaWQsCj4gPiA+ ICAgICAgICAgICAgICAgICBzb2NfZGV2X2F0dHItPnJldmlzaW9uLCBjaGlwX3Jldik7Cj4gPiAK PiA+IEZpcnN0IG9mZiwgdGhlIGRyaXZlciBzaG91bGQgbm90IGJlIHNwaXR0aW5nIG91dCBub2lz ZSBmb3Igd2hlbiBhbGwgZ29lcwo+ID4gd2VsbCBsaWtlIHRoaXMgOikKPiAKPiBJIGRpZG4ndCBm b2xsb3cgdGhlIGRpc2N1c3Npb24gY2xvc2VseSwgYnV0IEkgdGhpbmsgSSB3YW50IHRvIG9iamVj dAo+IGhlcmUgYSBiaXQuIFdoaWxlIEkgYWdyZWUgdGhhdCBlYWNoIGRyaXZlciBlbWl0dGluZyBz b21lIHN0dWZmIHRvIHRoZQo+IGxvZyBidWZmZXIgaXMgaGFyZGx5IGhlbHBmdWwsIHNlZWluZyB0 aGUgZXhhY3QgU29DIGRldGFpbHMgaXMgaW5kZWVkCj4gdXNlZnVsIGF0IHRpbWVzLiBXaXRoIG15 IERlYmlhbiBrZXJuZWwgdGVhbSBtZW1iZXIgaGF0IG9uLCBJJ2Qgc2F5Cj4ga2VlcCB0aGlzIGlu Zm9ybWF0aW9uLiBUaGlzIHdheSB0aGUgU29DIGRldGFpbHMgbWFrZSBpdCBpbnRvIGtlcm5lbCBi dWcKPiByZXBvcnRzIHdpdGhvdXQgZWZmb3J0IG9uIG91ciBzaWRlLgoKUmlnaHQuIEZyb20gbXkg YW5nbGUgd2UgYXJlIHN0YXJ0aW5nIHRvIGJlIHdheSB0b28gYWdncmVzc2l2ZSB3aXRoIHRoZQpw b2ludCBhYm91dCBub3QgcHJpbnRpbmcgaW5mb3JtYXRpb24gdG8gdGhlIGtlcm5lbCBsb2cuIElu IG9ubHkgYQpzbWFsbCBzZXQgb2YgY2FzZXMgZG9lcyB0aGlzIGFjdHVhbGx5IGNhdXNlIGFuIGlz c3VlIGkuZS4gd2l0aApwbGF0Zm9ybXMgY29udGFpbmluZyBzbyBtYW55IGRldmljZXMgdGhhdCBw cmludGluZyBpbmZvcm1hdGlvbiBmcm9tCmVhY2ggb2YgdGhlbSBkb2VzIHNpZ25pZmljYW50bHkg aW5jcmVhc2UgYm9vdCB0aW1lcy4gSW4gbXkgd29ybGQgb2YKc21hbGwgZWxlY3Ryb25pY3MgSSd2 ZSBiZWVuIGdyZWF0bHkgaGluZGVyZWQgYnkgdGhlIGxhY2sgb2YKaW5mb3JtYXRpb24sIHN1Y2gg dGhhdCBpdCBoYXMgY29zdCBkYXlzIG9mIGVuZ2luZWVyaW5nIHRyeWluZyB0byB0cmFjawpkb3du IGZpY3RpdGlvdXMgYnVncyBhbmQgdGhlIGxpa2UuCgpGb3IgcGxhdGZvcm1zIHdoZXJlIHByaW50 aW5nIHVzZWZ1bCBpbmZvcm1hdGlvbiBjdWxtaW5hdGVzIGluIG5lZ2F0aXZlCmVmZmVjdHMsIHBl cmhhcHMgc2ltcGx5IGxvd2VyIHRoZWlyIGxvZyBsZXZlbCwgcmF0aGVyIHRoYW4gc3VmZm9jYXRl CmFsbCBwbGF0Zm9ybXMuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNl cyBUZWNobmljYWwgTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBt YWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] base: soc: Export soc_device_to_device() helper Date: Tue, 12 Nov 2019 10:48:56 +0000 Message-ID: <20191112104856.GQ3218@dell> References: <20191103013645.9856-3-afaerber@suse.de> <20191111045609.7026-1-afaerber@suse.de> <20191111052741.GB3176397@kroah.com> <586fa37c-6292-aca4-fa7c-73064858afaf@suse.de> <20191111064040.GA3502217@kroah.com> <20191112052347.GA1197504@kroah.com> <20191112072926.isjxfa4ci6akhx56@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20191112072926.isjxfa4ci6akhx56@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Greg Kroah-Hartman , Andreas =?iso-8859-1?Q?F=E4rber?= , Geert Uytterhoeven , linux-realtek-soc@lists.infradead.org, Tony Lindgren , Linus Walleij , Bjorn Andersson , Thierry Reding , Fabio Estevam , Kevin Hilman , "Rafael J. Wysocki" , Michal Simek , Jonathan Hunter , NXP Linux Team , Sascha Hauer , "linux-tegra@vger.kernel.org" , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, Alexander List-Id: linux-omap@vger.kernel.org On Tue, 12 Nov 2019, Uwe Kleine-König wrote: > On Tue, Nov 12, 2019 at 06:23:47AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 11, 2019 at 09:10:41PM +0100, Andreas Färber wrote: > > > Am 11.11.19 um 07:40 schrieb Greg Kroah-Hartman: > > > > On Mon, Nov 11, 2019 at 06:42:05AM +0100, Andreas Färber wrote: > > > >> Hi Greg, > > > >> > > > >> Am 11.11.19 um 06:27 schrieb Greg Kroah-Hartman: > > > >>> On Mon, Nov 11, 2019 at 05:56:09AM +0100, Andreas Färber wrote: > > > >>>> Use of soc_device_to_device() in driver modules causes a build failure. > > > >>>> Given that the helper is nicely documented in include/linux/sys_soc.h, > > > >>>> let's export it as GPL symbol. > > > >>> > > > >>> I thought we were fixing the soc drivers to not need this. What > > > >>> happened to that effort? I thought I had patches in my tree (or > > > >>> someone's tree) that did some of this work already, such that this > > > >>> symbol isn't needed anymore. > > > >> > > > >> I do still see this function used in next-20191108 in drivers/soc/. > > > >> > > > >> I'll be happy to adjust my RFC driver if someone points me to how! > > > > > > > > Look at c31e73121f4c ("base: soc: Handle custom soc information sysfs > > > > entries") for how you can just use the default attributes for the soc to > > > > create the needed sysfs files, instead of having to do it "by hand" > > > > which is racy and incorrect. > > > > > > Unrelated. > > > > > > >> Given the current struct layout, a type cast might work (but ugly). > > > >> Or if we stay with my current RFC driver design, we could use the > > > >> platform_device instead of the soc_device (which would clutter the > > > >> screen more than "soc soc0:") or resort to pr_info() w/o device. > > > > > > > > Ick, no, don't cast blindly. What do you need the pointer for? Is this > > > > for in-tree code? > > > > > > No, an RFC patchset: https://patchwork.kernel.org/cover/11224261/ > > > > > > As I indicated above, I used it for a dev_info(), which I can easily > > > avoid by using pr_info() instead: > > > > > > diff --git a/drivers/soc/realtek/chip.c b/drivers/soc/realtek/chip.c > > > index e5078c6731fd..f9380e831659 100644 > > > --- a/drivers/soc/realtek/chip.c > > > +++ b/drivers/soc/realtek/chip.c > > > @@ -178,8 +178,7 @@ static int rtd_soc_probe(struct platform_device *pdev) > > > > > > platform_set_drvdata(pdev, soc_dev); > > > > > > - dev_info(soc_device_to_device(soc_dev), > > > - "%s %s (0x%08x) rev %s (0x%08x) detected\n", > > > + pr_info("%s %s (0x%08x) rev %s (0x%08x) detected\n", > > > soc_dev_attr->family, soc_dev_attr->soc_id, chip_id, > > > soc_dev_attr->revision, chip_rev); > > > > First off, the driver should not be spitting out noise for when all goes > > well like this :) > > I didn't follow the discussion closely, but I think I want to object > here a bit. While I agree that each driver emitting some stuff to the > log buffer is hardly helpful, seeing the exact SoC details is indeed > useful at times. With my Debian kernel team member hat on, I'd say > keep this information. This way the SoC details make it into kernel bug > reports without effort on our side. Right. From my angle we are starting to be way too aggressive with the point about not printing information to the kernel log. In only a small set of cases does this actually cause an issue i.e. with platforms containing so many devices that printing information from each of them does significantly increase boot times. In my world of small electronics I've been greatly hindered by the lack of information, such that it has cost days of engineering trying to track down fictitious bugs and the like. For platforms where printing useful information culminates in negative effects, perhaps simply lower their log level, rather than suffocate all platforms. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFC0C43331 for ; Tue, 12 Nov 2019 10:49:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F3B92084E for ; Tue, 12 Nov 2019 10:49:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="toL96Rrj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Euto9/lQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F3B92084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bnnWmP2w6dYYBmGq3dE+y5fjIJUPz4CZ/ZC5rIA1udw=; b=toL96RrjpqT8Jg jNxPWnExNi2+sxPhFINGHGDsX8INGN0CRu9sQ1zsIE+dS5xs84WqncSPfjtEZc5Wi3qSX5eN3vJfQ RVDLHa3Uwsfrymuxfb+WQ6IQfx4l6iKGjkM7wgXa2yLCyV53FX6o/tVtdjlWOOOwXTbsucX+Ynh3C R7TvxOZFmBnuwQCRya3r29mwS3kEwdUNGBAf4QH0VZ5ndsdh5XK6MBSBihXcbyBqKgEjA2IfnJwFG 8mdbKkFpfvDbuiZOm9lrSDALKHbRXyDwnji13ITsGb/eAuKFucX40ouD2NhEscr/SxQ4FRpMCgBpG n7ptKyoGW74do1MKDKhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUTjS-00007i-Sc; Tue, 12 Nov 2019 10:49:10 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUTjP-00006B-G3 for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2019 10:49:09 +0000 Received: by mail-wm1-x343.google.com with SMTP id l1so2581742wme.2 for ; Tue, 12 Nov 2019 02:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=cGBOxzPSbBShIku6cnlQrmVn7eBeOMTad4fgKmfaiFg=; b=Euto9/lQ4Xwt8ZRKGQSpeBv2obGwPp0u/+pHm60h9VTX/05YlZOdCRCI1JzXVpLwm5 l3g5u9AFmtrm3QcRsRuxM1XCIckSOBQlVGjQfackXRDKAGPfxGCGPr2ts4qmE3SI7Lfa qyt0jnRdqJhvES9HKhPlZxKoPX4Q0FbVDo2FOC4Yzl+Bl6Xf3IPU/0ngPAt6xaCWtibg UTc8mO7c9XiPGZ0CWumWdpueA3Ij/0fnZhjAvhY3vrWGa4BjuE60H6SiPQn9SD+rn953 yVVMks7re251j1u6UBWrXfef46kcrzBmy8gCmxIv2xCOGSjIP9dlaZzQrTTtl7GEk6u6 0lDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cGBOxzPSbBShIku6cnlQrmVn7eBeOMTad4fgKmfaiFg=; b=Ghes27LzTmqbRHbFmOAtgP7vMYCGP8JKEDY+sSrSaY+jV37uWvBbjXmQhaRYDQ7hth mhakgF66HrsfFQ3J0Dce+ZvO/Bbd3WdE3FktDWX/o1VKNf/J1zXuXLXzIFFPZqyWLA/U EkemutLxftTOCReRK6itTlfYmT9t+FnIgQyrYasq2hn8weUoewR+xch4G2pTNMylCcZY osYIyZvSaah1mjsj/gFYfspgZ9yLHBu+/K44Rky0DMx44irBAcs3kHCMi3dq0D3E31vi 7FhFj6yHNK2ZDNLqPCICbK+JJ++k8+6FXGxjWsMc0Y9VYtiMFY/3v/HcQRxW6XEkgJHZ mJNA== X-Gm-Message-State: APjAAAUMBvQIIBmnKEeljdTHaf/ILpiLK9+Ww/Ob6agrmIzqsSzwskdT 3MDvTwrFlTQdNU5ncMks86YyPg== X-Google-Smtp-Source: APXvYqzZj+j6WLZsmzeULWLgYPCNF9UMEvYlEH8Wd9m5JB3mfTBRFsR7TnMXmSIlEe9absXUaF8dMQ== X-Received: by 2002:a05:600c:2202:: with SMTP id z2mr3210310wml.162.1573555745515; Tue, 12 Nov 2019 02:49:05 -0800 (PST) Received: from dell ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id n65sm4341325wmf.28.2019.11.12.02.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 02:49:05 -0800 (PST) Date: Tue, 12 Nov 2019 10:48:56 +0000 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] base: soc: Export soc_device_to_device() helper Message-ID: <20191112104856.GQ3218@dell> References: <20191103013645.9856-3-afaerber@suse.de> <20191111045609.7026-1-afaerber@suse.de> <20191111052741.GB3176397@kroah.com> <586fa37c-6292-aca4-fa7c-73064858afaf@suse.de> <20191111064040.GA3502217@kroah.com> <20191112052347.GA1197504@kroah.com> <20191112072926.isjxfa4ci6akhx56@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112072926.isjxfa4ci6akhx56@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_024907_547314_A8D2C948 X-CRM114-Status: GOOD ( 27.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , linux-realtek-soc@lists.infradead.org, Tony Lindgren , Linus Walleij , Bjorn Andersson , Thierry Reding , Fabio Estevam , Kevin Hilman , "Rafael J. Wysocki" , Michal Simek , Jonathan Hunter , NXP Linux Team , Sascha Hauer , "linux-tegra@vger.kernel.org" , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, Alexander Sverdlin , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Hartley Sweeten , Pengutronix Kernel Team , Shawn Guo , Andreas =?iso-8859-1?Q?F=E4rber?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxMiBOb3YgMjAxOSwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cgo+IE9uIFR1ZSwg Tm92IDEyLCAyMDE5IGF0IDA2OjIzOjQ3QU0gKzAxMDAsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90 ZToKPiA+IE9uIE1vbiwgTm92IDExLCAyMDE5IGF0IDA5OjEwOjQxUE0gKzAxMDAsIEFuZHJlYXMg RsOkcmJlciB3cm90ZToKPiA+ID4gQW0gMTEuMTEuMTkgdW0gMDc6NDAgc2NocmllYiBHcmVnIEty b2FoLUhhcnRtYW46Cj4gPiA+ID4gT24gTW9uLCBOb3YgMTEsIDIwMTkgYXQgMDY6NDI6MDVBTSAr MDEwMCwgQW5kcmVhcyBGw6RyYmVyIHdyb3RlOgo+ID4gPiA+PiBIaSBHcmVnLAo+ID4gPiA+Pgo+ ID4gPiA+PiBBbSAxMS4xMS4xOSB1bSAwNjoyNyBzY2hyaWViIEdyZWcgS3JvYWgtSGFydG1hbjoK PiA+ID4gPj4+IE9uIE1vbiwgTm92IDExLCAyMDE5IGF0IDA1OjU2OjA5QU0gKzAxMDAsIEFuZHJl YXMgRsOkcmJlciB3cm90ZToKPiA+ID4gPj4+PiBVc2Ugb2Ygc29jX2RldmljZV90b19kZXZpY2Uo KSBpbiBkcml2ZXIgbW9kdWxlcyBjYXVzZXMgYSBidWlsZCBmYWlsdXJlLgo+ID4gPiA+Pj4+IEdp dmVuIHRoYXQgdGhlIGhlbHBlciBpcyBuaWNlbHkgZG9jdW1lbnRlZCBpbiBpbmNsdWRlL2xpbnV4 L3N5c19zb2MuaCwKPiA+ID4gPj4+PiBsZXQncyBleHBvcnQgaXQgYXMgR1BMIHN5bWJvbC4KPiA+ ID4gPj4+Cj4gPiA+ID4+PiBJIHRob3VnaHQgd2Ugd2VyZSBmaXhpbmcgdGhlIHNvYyBkcml2ZXJz IHRvIG5vdCBuZWVkIHRoaXMuICBXaGF0Cj4gPiA+ID4+PiBoYXBwZW5lZCB0byB0aGF0IGVmZm9y dD8gIEkgdGhvdWdodCBJIGhhZCBwYXRjaGVzIGluIG15IHRyZWUgKG9yCj4gPiA+ID4+PiBzb21l b25lJ3MgdHJlZSkgdGhhdCBkaWQgc29tZSBvZiB0aGlzIHdvcmsgYWxyZWFkeSwgc3VjaCB0aGF0 IHRoaXMKPiA+ID4gPj4+IHN5bWJvbCBpc24ndCBuZWVkZWQgYW55bW9yZS4KPiA+ID4gPj4KPiA+ ID4gPj4gSSBkbyBzdGlsbCBzZWUgdGhpcyBmdW5jdGlvbiB1c2VkIGluIG5leHQtMjAxOTExMDgg aW4gZHJpdmVycy9zb2MvLgo+ID4gPiA+Pgo+ID4gPiA+PiBJJ2xsIGJlIGhhcHB5IHRvIGFkanVz dCBteSBSRkMgZHJpdmVyIGlmIHNvbWVvbmUgcG9pbnRzIG1lIHRvIGhvdyEKPiA+ID4gPiAKPiA+ ID4gPiBMb29rIGF0IGMzMWU3MzEyMWY0YyAoImJhc2U6IHNvYzogSGFuZGxlIGN1c3RvbSBzb2Mg aW5mb3JtYXRpb24gc3lzZnMKPiA+ID4gPiBlbnRyaWVzIikgZm9yIGhvdyB5b3UgY2FuIGp1c3Qg dXNlIHRoZSBkZWZhdWx0IGF0dHJpYnV0ZXMgZm9yIHRoZSBzb2MgdG8KPiA+ID4gPiBjcmVhdGUg dGhlIG5lZWRlZCBzeXNmcyBmaWxlcywgaW5zdGVhZCBvZiBoYXZpbmcgdG8gZG8gaXQgImJ5IGhh bmQiCj4gPiA+ID4gd2hpY2ggaXMgcmFjeSBhbmQgaW5jb3JyZWN0Lgo+ID4gPiAKPiA+ID4gVW5y ZWxhdGVkLgo+ID4gPiAKPiA+ID4gPj4gR2l2ZW4gdGhlIGN1cnJlbnQgc3RydWN0IGxheW91dCwg YSB0eXBlIGNhc3QgbWlnaHQgd29yayAoYnV0IHVnbHkpLgo+ID4gPiA+PiBPciBpZiB3ZSBzdGF5 IHdpdGggbXkgY3VycmVudCBSRkMgZHJpdmVyIGRlc2lnbiwgd2UgY291bGQgdXNlIHRoZQo+ID4g PiA+PiBwbGF0Zm9ybV9kZXZpY2UgaW5zdGVhZCBvZiB0aGUgc29jX2RldmljZSAod2hpY2ggd291 bGQgY2x1dHRlciB0aGUKPiA+ID4gPj4gc2NyZWVuIG1vcmUgdGhhbiAic29jIHNvYzA6Iikgb3Ig cmVzb3J0IHRvIHByX2luZm8oKSB3L28gZGV2aWNlLgo+ID4gPiA+IAo+ID4gPiA+IEljaywgbm8s IGRvbid0IGNhc3QgYmxpbmRseS4gIFdoYXQgZG8geW91IG5lZWQgdGhlIHBvaW50ZXIgZm9yPyAg SXMgdGhpcwo+ID4gPiA+IGZvciBpbi10cmVlIGNvZGU/Cj4gPiA+IAo+ID4gPiBObywgYW4gUkZD IHBhdGNoc2V0OiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL2NvdmVyLzExMjI0MjYxLwo+ ID4gPiAKPiA+ID4gQXMgSSBpbmRpY2F0ZWQgYWJvdmUsIEkgdXNlZCBpdCBmb3IgYSBkZXZfaW5m bygpLCB3aGljaCBJIGNhbiBlYXNpbHkKPiA+ID4gYXZvaWQgYnkgdXNpbmcgcHJfaW5mbygpIGlu c3RlYWQ6Cj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2MvcmVhbHRlay9jaGlw LmMgYi9kcml2ZXJzL3NvYy9yZWFsdGVrL2NoaXAuYwo+ID4gPiBpbmRleCBlNTA3OGM2NzMxZmQu LmY5MzgwZTgzMTY1OSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9zb2MvcmVhbHRlay9jaGlw LmMKPiA+ID4gKysrIGIvZHJpdmVycy9zb2MvcmVhbHRlay9jaGlwLmMKPiA+ID4gQEAgLTE3OCw4 ICsxNzgsNyBAQCBzdGF0aWMgaW50IHJ0ZF9zb2NfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKPiA+ID4gCj4gPiA+ICAgICAgICAgcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwg c29jX2Rldik7Cj4gPiA+IAo+ID4gPiAtICAgICAgIGRldl9pbmZvKHNvY19kZXZpY2VfdG9fZGV2 aWNlKHNvY19kZXYpLAo+ID4gPiAtICAgICAgICAgICAgICAgIiVzICVzICgweCUwOHgpIHJldiAl cyAoMHglMDh4KSBkZXRlY3RlZFxuIiwKPiA+ID4gKyAgICAgICBwcl9pbmZvKCIlcyAlcyAoMHgl MDh4KSByZXYgJXMgKDB4JTA4eCkgZGV0ZWN0ZWRcbiIsCj4gPiA+ICAgICAgICAgICAgICAgICBz b2NfZGV2X2F0dHItPmZhbWlseSwgc29jX2Rldl9hdHRyLT5zb2NfaWQsIGNoaXBfaWQsCj4gPiA+ ICAgICAgICAgICAgICAgICBzb2NfZGV2X2F0dHItPnJldmlzaW9uLCBjaGlwX3Jldik7Cj4gPiAK PiA+IEZpcnN0IG9mZiwgdGhlIGRyaXZlciBzaG91bGQgbm90IGJlIHNwaXR0aW5nIG91dCBub2lz ZSBmb3Igd2hlbiBhbGwgZ29lcwo+ID4gd2VsbCBsaWtlIHRoaXMgOikKPiAKPiBJIGRpZG4ndCBm b2xsb3cgdGhlIGRpc2N1c3Npb24gY2xvc2VseSwgYnV0IEkgdGhpbmsgSSB3YW50IHRvIG9iamVj dAo+IGhlcmUgYSBiaXQuIFdoaWxlIEkgYWdyZWUgdGhhdCBlYWNoIGRyaXZlciBlbWl0dGluZyBz b21lIHN0dWZmIHRvIHRoZQo+IGxvZyBidWZmZXIgaXMgaGFyZGx5IGhlbHBmdWwsIHNlZWluZyB0 aGUgZXhhY3QgU29DIGRldGFpbHMgaXMgaW5kZWVkCj4gdXNlZnVsIGF0IHRpbWVzLiBXaXRoIG15 IERlYmlhbiBrZXJuZWwgdGVhbSBtZW1iZXIgaGF0IG9uLCBJJ2Qgc2F5Cj4ga2VlcCB0aGlzIGlu Zm9ybWF0aW9uLiBUaGlzIHdheSB0aGUgU29DIGRldGFpbHMgbWFrZSBpdCBpbnRvIGtlcm5lbCBi dWcKPiByZXBvcnRzIHdpdGhvdXQgZWZmb3J0IG9uIG91ciBzaWRlLgoKUmlnaHQuIEZyb20gbXkg YW5nbGUgd2UgYXJlIHN0YXJ0aW5nIHRvIGJlIHdheSB0b28gYWdncmVzc2l2ZSB3aXRoIHRoZQpw b2ludCBhYm91dCBub3QgcHJpbnRpbmcgaW5mb3JtYXRpb24gdG8gdGhlIGtlcm5lbCBsb2cuIElu IG9ubHkgYQpzbWFsbCBzZXQgb2YgY2FzZXMgZG9lcyB0aGlzIGFjdHVhbGx5IGNhdXNlIGFuIGlz c3VlIGkuZS4gd2l0aApwbGF0Zm9ybXMgY29udGFpbmluZyBzbyBtYW55IGRldmljZXMgdGhhdCBw cmludGluZyBpbmZvcm1hdGlvbiBmcm9tCmVhY2ggb2YgdGhlbSBkb2VzIHNpZ25pZmljYW50bHkg aW5jcmVhc2UgYm9vdCB0aW1lcy4gSW4gbXkgd29ybGQgb2YKc21hbGwgZWxlY3Ryb25pY3MgSSd2 ZSBiZWVuIGdyZWF0bHkgaGluZGVyZWQgYnkgdGhlIGxhY2sgb2YKaW5mb3JtYXRpb24sIHN1Y2gg dGhhdCBpdCBoYXMgY29zdCBkYXlzIG9mIGVuZ2luZWVyaW5nIHRyeWluZyB0byB0cmFjawpkb3du IGZpY3RpdGlvdXMgYnVncyBhbmQgdGhlIGxpa2UuCgpGb3IgcGxhdGZvcm1zIHdoZXJlIHByaW50 aW5nIHVzZWZ1bCBpbmZvcm1hdGlvbiBjdWxtaW5hdGVzIGluIG5lZ2F0aXZlCmVmZmVjdHMsIHBl cmhhcHMgc2ltcGx5IGxvd2VyIHRoZWlyIGxvZyBsZXZlbCwgcmF0aGVyIHRoYW4gc3VmZm9jYXRl CmFsbCBwbGF0Zm9ybXMuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNl cyBUZWNobmljYWwgTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2380CC43331 for ; Tue, 12 Nov 2019 10:49:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8242214E0 for ; Tue, 12 Nov 2019 10:49:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Euto9/lQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727129AbfKLKtJ (ORCPT ); Tue, 12 Nov 2019 05:49:09 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:39737 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbfKLKtI (ORCPT ); Tue, 12 Nov 2019 05:49:08 -0500 Received: by mail-wm1-f66.google.com with SMTP id t26so2402485wmi.4 for ; Tue, 12 Nov 2019 02:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=cGBOxzPSbBShIku6cnlQrmVn7eBeOMTad4fgKmfaiFg=; b=Euto9/lQ4Xwt8ZRKGQSpeBv2obGwPp0u/+pHm60h9VTX/05YlZOdCRCI1JzXVpLwm5 l3g5u9AFmtrm3QcRsRuxM1XCIckSOBQlVGjQfackXRDKAGPfxGCGPr2ts4qmE3SI7Lfa qyt0jnRdqJhvES9HKhPlZxKoPX4Q0FbVDo2FOC4Yzl+Bl6Xf3IPU/0ngPAt6xaCWtibg UTc8mO7c9XiPGZ0CWumWdpueA3Ij/0fnZhjAvhY3vrWGa4BjuE60H6SiPQn9SD+rn953 yVVMks7re251j1u6UBWrXfef46kcrzBmy8gCmxIv2xCOGSjIP9dlaZzQrTTtl7GEk6u6 0lDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cGBOxzPSbBShIku6cnlQrmVn7eBeOMTad4fgKmfaiFg=; b=aFNU37wQb2Lrz64AEhJXyIeH86IPuWjXwNC/Ns4TYkBk0vymtduMhsDZSiFDAJaC5M XlrAmYTHYRdu2KAxN+9y81Lh0/044MqIDUWX2yPYQ8dlRMQejlmqolayor+pXTYZqV92 WIi2ES8ZVa+Hl/N2w8slx1KTYaAOuNIATWxDgMNmCW8M/fboLEUkrz/yGPCaG7+VOIUy wToldR35UMCeB0xGciP8fSfKPE6wTipJ8VYAnsKFKRUiXzn0X/BdzLI7JDKfVZhNDBDw bhlw2axD5oHQBIh2kpHB/ZOvz9J0VyPxp3fqf2/a7p5SjG2ZbJlyLcQQkUutSq2pvBsz Tn0Q== X-Gm-Message-State: APjAAAXQ9n9o2shbpE94WF3utwZgwHhePqtc0N2VXPjU5W769CFeNXN7 xg1bYL/cHwWKcivF9wiuICbFrg== X-Google-Smtp-Source: APXvYqzZj+j6WLZsmzeULWLgYPCNF9UMEvYlEH8Wd9m5JB3mfTBRFsR7TnMXmSIlEe9absXUaF8dMQ== X-Received: by 2002:a05:600c:2202:: with SMTP id z2mr3210310wml.162.1573555745515; Tue, 12 Nov 2019 02:49:05 -0800 (PST) Received: from dell ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id n65sm4341325wmf.28.2019.11.12.02.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 02:49:05 -0800 (PST) Date: Tue, 12 Nov 2019 10:48:56 +0000 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Greg Kroah-Hartman , Andreas =?iso-8859-1?Q?F=E4rber?= , Geert Uytterhoeven , linux-realtek-soc@lists.infradead.org, Tony Lindgren , Linus Walleij , Bjorn Andersson , Thierry Reding , Fabio Estevam , Kevin Hilman , "Rafael J. Wysocki" , Michal Simek , Jonathan Hunter , NXP Linux Team , Sascha Hauer , "linux-tegra@vger.kernel.org" , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, Alexander Sverdlin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hartley Sweeten , Pengutronix Kernel Team , Shawn Guo Subject: Re: [PATCH] base: soc: Export soc_device_to_device() helper Message-ID: <20191112104856.GQ3218@dell> References: <20191103013645.9856-3-afaerber@suse.de> <20191111045609.7026-1-afaerber@suse.de> <20191111052741.GB3176397@kroah.com> <586fa37c-6292-aca4-fa7c-73064858afaf@suse.de> <20191111064040.GA3502217@kroah.com> <20191112052347.GA1197504@kroah.com> <20191112072926.isjxfa4ci6akhx56@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191112072926.isjxfa4ci6akhx56@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Nov 2019, Uwe Kleine-König wrote: > On Tue, Nov 12, 2019 at 06:23:47AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 11, 2019 at 09:10:41PM +0100, Andreas Färber wrote: > > > Am 11.11.19 um 07:40 schrieb Greg Kroah-Hartman: > > > > On Mon, Nov 11, 2019 at 06:42:05AM +0100, Andreas Färber wrote: > > > >> Hi Greg, > > > >> > > > >> Am 11.11.19 um 06:27 schrieb Greg Kroah-Hartman: > > > >>> On Mon, Nov 11, 2019 at 05:56:09AM +0100, Andreas Färber wrote: > > > >>>> Use of soc_device_to_device() in driver modules causes a build failure. > > > >>>> Given that the helper is nicely documented in include/linux/sys_soc.h, > > > >>>> let's export it as GPL symbol. > > > >>> > > > >>> I thought we were fixing the soc drivers to not need this. What > > > >>> happened to that effort? I thought I had patches in my tree (or > > > >>> someone's tree) that did some of this work already, such that this > > > >>> symbol isn't needed anymore. > > > >> > > > >> I do still see this function used in next-20191108 in drivers/soc/. > > > >> > > > >> I'll be happy to adjust my RFC driver if someone points me to how! > > > > > > > > Look at c31e73121f4c ("base: soc: Handle custom soc information sysfs > > > > entries") for how you can just use the default attributes for the soc to > > > > create the needed sysfs files, instead of having to do it "by hand" > > > > which is racy and incorrect. > > > > > > Unrelated. > > > > > > >> Given the current struct layout, a type cast might work (but ugly). > > > >> Or if we stay with my current RFC driver design, we could use the > > > >> platform_device instead of the soc_device (which would clutter the > > > >> screen more than "soc soc0:") or resort to pr_info() w/o device. > > > > > > > > Ick, no, don't cast blindly. What do you need the pointer for? Is this > > > > for in-tree code? > > > > > > No, an RFC patchset: https://patchwork.kernel.org/cover/11224261/ > > > > > > As I indicated above, I used it for a dev_info(), which I can easily > > > avoid by using pr_info() instead: > > > > > > diff --git a/drivers/soc/realtek/chip.c b/drivers/soc/realtek/chip.c > > > index e5078c6731fd..f9380e831659 100644 > > > --- a/drivers/soc/realtek/chip.c > > > +++ b/drivers/soc/realtek/chip.c > > > @@ -178,8 +178,7 @@ static int rtd_soc_probe(struct platform_device *pdev) > > > > > > platform_set_drvdata(pdev, soc_dev); > > > > > > - dev_info(soc_device_to_device(soc_dev), > > > - "%s %s (0x%08x) rev %s (0x%08x) detected\n", > > > + pr_info("%s %s (0x%08x) rev %s (0x%08x) detected\n", > > > soc_dev_attr->family, soc_dev_attr->soc_id, chip_id, > > > soc_dev_attr->revision, chip_rev); > > > > First off, the driver should not be spitting out noise for when all goes > > well like this :) > > I didn't follow the discussion closely, but I think I want to object > here a bit. While I agree that each driver emitting some stuff to the > log buffer is hardly helpful, seeing the exact SoC details is indeed > useful at times. With my Debian kernel team member hat on, I'd say > keep this information. This way the SoC details make it into kernel bug > reports without effort on our side. Right. From my angle we are starting to be way too aggressive with the point about not printing information to the kernel log. In only a small set of cases does this actually cause an issue i.e. with platforms containing so many devices that printing information from each of them does significantly increase boot times. In my world of small electronics I've been greatly hindered by the lack of information, such that it has cost days of engineering trying to track down fictitious bugs and the like. For platforms where printing useful information culminates in negative effects, perhaps simply lower their log level, rather than suffocate all platforms. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog