From: Boris Brezillon <boris.brezillon@collabora.com>
To: Alexandre Courbot <acourbot@google.com>
Cc: Ezequiel Garcia <ezequiel@collabora.com>,
Maxime Ripard <mripard@kernel.org>,
Tomasz Figa <tfiga@chromium.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: H264 stateless reference frames ordering lists
Date: Tue, 12 Nov 2019 11:53:43 +0100 [thread overview]
Message-ID: <20191112115343.1b1908ce@collabora.com> (raw)
In-Reply-To: <CAPBb6MWXj+PNbJ0_m6O6wnYf6Z9NcYwr49qbSowG66NB-23k2g@mail.gmail.com>
Hi Alexandre,
On Tue, 12 Nov 2019 19:14:22 +0900
Alexandre Courbot <acourbot@google.com> wrote:
> Hi Boris and Ezequiel,
>
> Patch c3adb85745ca6 has removed the ref_pic_list_* members from the
> v4l2_ctrl_h264_decode_params struct. The MT8183 stateless decoder
> driver I am working on still relies on these lists and I am trying (a
> bit late to the game) to remove them from the Chromium OS kernel UAPI
> in order to match upstream.
>
> I have dug into the discussion that resulted in this removal and could
> not really find how these are supposed to be reconstructed and on the
> basis on which information. The commit log for the above-mentioned
> patch mentions that "generic helpers will be provided for drivers that
> need this list". I could not find any in the kernel so far, do you
> have any code available at the moment? Or any idea on how these can be
> reconstructed? The process seems to involve reading the DPB itself as
> well as reordering information from the slice parameters, and seems to
> be a bit involved to be done in the kernel, but maybe I am missing
> something here.
The code is here [1], and it should indeed be extracted and put in a
generic v4l2_h264 lib at some point (should happen soon, since we need
the same logic for the rkvdec driver).
Let me know if you have any questions.
Regards,
Boris
[1]https://elixir.bootlin.com/linux/v5.4-rc7/source/drivers/staging/media/hantro/hantro_h264.c#L270
next prev parent reply other threads:[~2019-11-12 10:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 10:14 H264 stateless reference frames ordering lists Alexandre Courbot
2019-11-12 10:53 ` Boris Brezillon [this message]
2019-11-13 6:30 ` Alexandre Courbot
2019-11-13 7:22 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112115343.1b1908ce@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=acourbot@google.com \
--cc=ezequiel@collabora.com \
--cc=linux-media@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.