From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH v2] virtiofs: Use static const, not const static Date: Tue, 12 Nov 2019 08:18:41 -0500 Message-ID: <20191112131841.GA5501@redhat.com> References: <1573474545-37037-1-git-send-email-zhengbin13@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1573474545-37037-1-git-send-email-zhengbin13@huawei.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: zhengbin Cc: linux-fsdevel@vger.kernel.org, mszeredi@redhat.com, stefanha@redhat.com, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org T24gTW9uLCBOb3YgMTEsIDIwMTkgYXQgMDg6MTU6NDVQTSArMDgwMCwgemhlbmdiaW4gd3JvdGU6 Cj4gTW92ZSB0aGUgc3RhdGljIGtleXdvcmQgdG8gdGhlIGZyb250IG9mIGRlY2xhcmF0aW9ucywg d2hpY2ggcmVzb2x2ZXMKPiBjb21waWxlciB3YXJuaW5ncyB3aGVuIGJ1aWxkaW5nIHdpdGggIlc9 MSI6Cj4gCj4gZnMvZnVzZS92aXJ0aW9fZnMuYzo2ODc6MTogd2FybmluZzog4oCYc3RhdGlj4oCZ IGlzIG5vdCBhdCBiZWdpbm5pbmcgb2YgZGVjbGFyYXRpb24gWy1Xb2xkLXN0eWxlLWRlY2xhcmF0 aW9uXQo+ICBjb25zdCBzdGF0aWMgc3RydWN0IHZpcnRpb19kZXZpY2VfaWQgaWRfdGFibGVbXSA9 IHsKPiAgXgo+IGZzL2Z1c2UvdmlydGlvX2ZzLmM6NjkyOjE6IHdhcm5pbmc6IOKAmHN0YXRpY+KA mSBpcyBub3QgYXQgYmVnaW5uaW5nIG9mIGRlY2xhcmF0aW9uIFstV29sZC1zdHlsZS1kZWNsYXJh dGlvbl0KPiAgY29uc3Qgc3RhdGljIHVuc2lnbmVkIGludCBmZWF0dXJlX3RhYmxlW10gPSB7fTsK PiAgXgo+IGZzL2Z1c2UvdmlydGlvX2ZzLmM6MTAyOToxOiB3YXJuaW5nOiDigJhzdGF0aWPigJkg aXMgbm90IGF0IGJlZ2lubmluZyBvZiBkZWNsYXJhdGlvbiBbLVdvbGQtc3R5bGUtZGVjbGFyYXRp b25dCj4gIGNvbnN0IHN0YXRpYyBzdHJ1Y3QgZnVzZV9pcXVldWVfb3BzIHZpcnRpb19mc19maXFf b3BzID0gewo+IAo+IFJlcG9ydGVkLWJ5OiBIdWxrIFJvYm90IDxodWxrY2lAaHVhd2VpLmNvbT4K PiBTaWduZWQtb2ZmLWJ5OiB6aGVuZ2JpbiA8emhlbmdiaW4xM0BodWF3ZWkuY29tPgoKQWNrZWQt Ynk6IFZpdmVrIEdveWFsIDx2Z295YWxAcmVkaGF0LmNvbT4KClZpdmVrCj4gLS0tCj4gdjEtPnYy OiBtb2RpZnkgY29tbWVudAo+ICBmcy9mdXNlL3ZpcnRpb19mcy5jIHwgNiArKystLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZnMvZnVzZS92aXJ0aW9fZnMuYyBiL2ZzL2Z1c2UvdmlydGlvX2ZzLmMKPiBpbmRleCBi NzdhY2VhLi4yYWM2ODE4IDEwMDY0NAo+IC0tLSBhL2ZzL2Z1c2UvdmlydGlvX2ZzLmMKPiArKysg Yi9mcy9mdXNlL3ZpcnRpb19mcy5jCj4gQEAgLTY4NCwxMiArNjg0LDEyIEBAIHN0YXRpYyBpbnQg dmlydGlvX2ZzX3Jlc3RvcmUoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYpCj4gIH0KPiAgI2Vu ZGlmIC8qIENPTkZJR19QTV9TTEVFUCAqLwo+IAo+IC1jb25zdCBzdGF0aWMgc3RydWN0IHZpcnRp b19kZXZpY2VfaWQgaWRfdGFibGVbXSA9IHsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCB2aXJ0aW9f ZGV2aWNlX2lkIGlkX3RhYmxlW10gPSB7Cj4gIAl7IFZJUlRJT19JRF9GUywgVklSVElPX0RFVl9B TllfSUQgfSwKPiAgCXt9LAo+ICB9Owo+IAo+IC1jb25zdCBzdGF0aWMgdW5zaWduZWQgaW50IGZl YXR1cmVfdGFibGVbXSA9IHt9Owo+ICtzdGF0aWMgY29uc3QgdW5zaWduZWQgaW50IGZlYXR1cmVf dGFibGVbXSA9IHt9Owo+IAo+ICBzdGF0aWMgc3RydWN0IHZpcnRpb19kcml2ZXIgdmlydGlvX2Zz X2RyaXZlciA9IHsKPiAgCS5kcml2ZXIubmFtZQkJPSBLQlVJTERfTU9ETkFNRSwKPiBAQCAtMTAy Niw3ICsxMDI2LDcgQEAgX19yZWxlYXNlcyhmaXEtPmxvY2spCj4gIAl9Cj4gIH0KPiAKPiAtY29u c3Qgc3RhdGljIHN0cnVjdCBmdXNlX2lxdWV1ZV9vcHMgdmlydGlvX2ZzX2ZpcV9vcHMgPSB7Cj4g K3N0YXRpYyBjb25zdCBzdHJ1Y3QgZnVzZV9pcXVldWVfb3BzIHZpcnRpb19mc19maXFfb3BzID0g ewo+ICAJLndha2VfZm9yZ2V0X2FuZF91bmxvY2sJCT0gdmlydGlvX2ZzX3dha2VfZm9yZ2V0X2Fu ZF91bmxvY2ssCj4gIAkud2FrZV9pbnRlcnJ1cHRfYW5kX3VubG9jawk9IHZpcnRpb19mc193YWtl X2ludGVycnVwdF9hbmRfdW5sb2NrLAo+ICAJLndha2VfcGVuZGluZ19hbmRfdW5sb2NrCT0gdmly dGlvX2ZzX3dha2VfcGVuZGluZ19hbmRfdW5sb2NrLAo+IC0tCj4gMi43LjQKPiAKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1h aWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRw czovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXph dGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB52C43331 for ; Tue, 12 Nov 2019 13:18:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50107214E0 for ; Tue, 12 Nov 2019 13:18:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BdBKy4yC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726008AbfKLNSs (ORCPT ); Tue, 12 Nov 2019 08:18:48 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:57120 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725847AbfKLNSs (ORCPT ); Tue, 12 Nov 2019 08:18:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573564727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DifWWZ3nxpQ7N+G4DC3RqHsKEjQ6VCW7kyonEbc0we4=; b=BdBKy4yCIKQOUZ2fGCM6EW3YV9KsYXcNK5iKVC7VCgIho0OF4uyHQLCd4rsuqCcPNiOYZ/ m8hc6Dq7eJ0QqiZmoj1lyQLad4o53gFGbPd7/RQtcniD/Z+N0PcMIlJOWUmM4esqhxQR+f hyVZ2GL/NPVQpfuRgP7GqeE9dBYii7g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-65-cxkwwec0OZC1FrpEEqBZ5g-1; Tue, 12 Nov 2019 08:18:45 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0A82800C61; Tue, 12 Nov 2019 13:18:44 +0000 (UTC) Received: from horse.redhat.com (unknown [10.18.25.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE201171FF; Tue, 12 Nov 2019 13:18:41 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 46C21220463; Tue, 12 Nov 2019 08:18:41 -0500 (EST) Date: Tue, 12 Nov 2019 08:18:41 -0500 From: Vivek Goyal To: zhengbin Cc: stefanha@redhat.com, mszeredi@redhat.com, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2] virtiofs: Use static const, not const static Message-ID: <20191112131841.GA5501@redhat.com> References: <1573474545-37037-1-git-send-email-zhengbin13@huawei.com> MIME-Version: 1.0 In-Reply-To: <1573474545-37037-1-git-send-email-zhengbin13@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: cxkwwec0OZC1FrpEEqBZ5g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Nov 11, 2019 at 08:15:45PM +0800, zhengbin wrote: > Move the static keyword to the front of declarations, which resolves > compiler warnings when building with "W=3D1": >=20 > fs/fuse/virtio_fs.c:687:1: warning: =E2=80=98static=E2=80=99 is not at be= ginning of declaration [-Wold-style-declaration] > const static struct virtio_device_id id_table[] =3D { > ^ > fs/fuse/virtio_fs.c:692:1: warning: =E2=80=98static=E2=80=99 is not at be= ginning of declaration [-Wold-style-declaration] > const static unsigned int feature_table[] =3D {}; > ^ > fs/fuse/virtio_fs.c:1029:1: warning: =E2=80=98static=E2=80=99 is not at b= eginning of declaration [-Wold-style-declaration] > const static struct fuse_iqueue_ops virtio_fs_fiq_ops =3D { >=20 > Reported-by: Hulk Robot > Signed-off-by: zhengbin Acked-by: Vivek Goyal Vivek > --- > v1->v2: modify comment > fs/fuse/virtio_fs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c > index b77acea..2ac6818 100644 > --- a/fs/fuse/virtio_fs.c > +++ b/fs/fuse/virtio_fs.c > @@ -684,12 +684,12 @@ static int virtio_fs_restore(struct virtio_device *= vdev) > } > #endif /* CONFIG_PM_SLEEP */ >=20 > -const static struct virtio_device_id id_table[] =3D { > +static const struct virtio_device_id id_table[] =3D { > =09{ VIRTIO_ID_FS, VIRTIO_DEV_ANY_ID }, > =09{}, > }; >=20 > -const static unsigned int feature_table[] =3D {}; > +static const unsigned int feature_table[] =3D {}; >=20 > static struct virtio_driver virtio_fs_driver =3D { > =09.driver.name=09=09=3D KBUILD_MODNAME, > @@ -1026,7 +1026,7 @@ __releases(fiq->lock) > =09} > } >=20 > -const static struct fuse_iqueue_ops virtio_fs_fiq_ops =3D { > +static const struct fuse_iqueue_ops virtio_fs_fiq_ops =3D { > =09.wake_forget_and_unlock=09=09=3D virtio_fs_wake_forget_and_unlock, > =09.wake_interrupt_and_unlock=09=3D virtio_fs_wake_interrupt_and_unlock, > =09.wake_pending_and_unlock=09=3D virtio_fs_wake_pending_and_unlock, > -- > 2.7.4 >=20