From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C98B7C43331 for ; Tue, 12 Nov 2019 14:01:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AE09214E0 for ; Tue, 12 Nov 2019 14:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WC3AmfAL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="kdU551XW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AE09214E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U2IeKCrr7J4DIP0XirWpcV93e3q7f55M8uczTx12Zh4=; b=WC3AmfAL9Bl7XN ya0vnmoG5dwENdwtOBmBGkf2H1jj2fZmkPLMdBcPllLp5yJM6wWMnX2RDmBhDR7gvQPU37WsNJoFc /tJ4NvNgcSofyjUS1hLH36fr2ozdsyVvp2HjRigT9l8CI2K8TY4fQXhEs4DRWVM85/B+M1zkdvCcV QbmK4Oi4jOBoB1mk7okuzaMNeeS78N+f/M3QuKGuzoORqEFpIicWGYxmlmkKJke7gf90cXp8kZOKw OQZimRoytDl3Fe6fhFkDZPE1WJmEKWHCwob7vBPQVXb0W0L4O1W44sS8RwE2UZ/SHf3izKXjNIH9E x/oVrWcRutekw3WqwMbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUWja-0005ak-2s; Tue, 12 Nov 2019 14:01:30 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUWjM-0005Zf-Qh for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2019 14:01:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/RI6fmn/sUXIGU/PUViPxPFyONizIT5yqn4fGxzbWxQ=; b=kdU551XWBYrVXong2h3XiotiJw JEiOK35L945IH4Zcekg9kweTxxuCuNnr4G0T1uFTXjeEbSxUJbRhXRAQY4ypq1qe9FEywx8BFQPJ2 R0pOR300JtGlbAsbLKXQXxI61kwlu+ffVZ6W9GsL5xI0UZG2io2JlKEGIPQECAXq4z9c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iUWjF-0001m2-E6; Tue, 12 Nov 2019 15:01:09 +0100 Date: Tue, 12 Nov 2019 15:01:09 +0100 From: Andrew Lunn To: Vladimir Oltean Subject: Re: [PATCH 2/2] ARM: dts: ls1021a-tsn: Use interrupts for the SGMII PHYs Message-ID: <20191112140109.GK5090@lunn.ch> References: <20191112132010.18274-1-linux@rasmusvillemoes.dk> <20191112132010.18274-3-linux@rasmusvillemoes.dk> <6d4292fcb0cf290837306388bdfe9b0f@www.loen.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_060116_865616_E99D86C0 X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Marc Zyngier , Rasmus Villemoes , lkml , Li Yang , Rob Herring , netdev , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > >> + /* SGMII2_PHY_INT_B: connected to IRQ2, active low > > >> */ > > >> + interrupts-extended = <&extirq 2 > > >> IRQ_TYPE_EDGE_FALLING>; > The interrupt specifier certainly works. So that points to an issue > with the description. What do you mean, exactly? Does "active low" > mean "level-triggered"? How would you have described this? I would expect IRQ_TYPE_ACTIVE_LOW, or whatever it is called. Since this is a shared interrupt, going on the edge i think opens up a race condition and interrupts can be missed. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24AF5C43331 for ; Tue, 12 Nov 2019 14:01:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDF04214E0 for ; Tue, 12 Nov 2019 14:01:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="kdU551XW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726497AbfKLOBO (ORCPT ); Tue, 12 Nov 2019 09:01:14 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:35926 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725947AbfKLOBO (ORCPT ); Tue, 12 Nov 2019 09:01:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/RI6fmn/sUXIGU/PUViPxPFyONizIT5yqn4fGxzbWxQ=; b=kdU551XWBYrVXong2h3XiotiJw JEiOK35L945IH4Zcekg9kweTxxuCuNnr4G0T1uFTXjeEbSxUJbRhXRAQY4ypq1qe9FEywx8BFQPJ2 R0pOR300JtGlbAsbLKXQXxI61kwlu+ffVZ6W9GsL5xI0UZG2io2JlKEGIPQECAXq4z9c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iUWjF-0001m2-E6; Tue, 12 Nov 2019 15:01:09 +0100 Date: Tue, 12 Nov 2019 15:01:09 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: Marc Zyngier , Rasmus Villemoes , Shawn Guo , Li Yang , Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, lkml , netdev Subject: Re: [PATCH 2/2] ARM: dts: ls1021a-tsn: Use interrupts for the SGMII PHYs Message-ID: <20191112140109.GK5090@lunn.ch> References: <20191112132010.18274-1-linux@rasmusvillemoes.dk> <20191112132010.18274-3-linux@rasmusvillemoes.dk> <6d4292fcb0cf290837306388bdfe9b0f@www.loen.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > > >> + /* SGMII2_PHY_INT_B: connected to IRQ2, active low > > >> */ > > >> + interrupts-extended = <&extirq 2 > > >> IRQ_TYPE_EDGE_FALLING>; > The interrupt specifier certainly works. So that points to an issue > with the description. What do you mean, exactly? Does "active low" > mean "level-triggered"? How would you have described this? I would expect IRQ_TYPE_ACTIVE_LOW, or whatever it is called. Since this is a shared interrupt, going on the edge i think opens up a race condition and interrupts can be missed. Andrew