From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Date: Tue, 12 Nov 2019 14:04:26 +0000 Subject: [PATCH v3 0/5] drm/udl: Replace fbdev by generic emulation Message-Id: <20191112140431.7895-1-tzimmermann@suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: airlied@redhat.com, sean@poorly.run, daniel@ffwll.ch, b.zolnierkie@samsung.com, noralf@tronnes.org, kraxel@redhat.com, sam@ravnborg.org, emil.velikov@collabora.com Cc: linux-fbdev@vger.kernel.org, Thomas Zimmermann , dri-devel@lists.freedesktop.org The udl driver can use the generic fbdev emulation. After conversion, a number of cleanups can be applied. Patch 1 prepares the prefered defaults. 32 bpp work well with driver, console and X11. The fbdev conversion is in patch 2. The original fbdev code in udl mapped the framebuffer's GEM object memory unconditionally, and unmapped the memory in the object's free() function. The respective code in free() can now be removed (Patch 3). And as udl was the only remaining external user of unlink_framebuffer(), that function now becomes an internal interface of the fbdev code (Patches 4 + 5). The patchset has been tested by running the console, X11 and Weston on a DisplayLink adapter. v3: * use 32 bpp by default * use defaults for several callback functions * remove all fb module parameters * remove udl_fbdev_init() v2: * converted udl to SHMEM and recreated fbdev patchset on top Thomas Zimmermann (5): drm/udl: Set default color depth to 32 bpp drm/udl: Replace fbdev code with generic emulation drm/udl: Remove udl implementation of GEM's free_object() drm/fb-helper: Remove drm_fb_helper_unlink_fbi() fbdev: Unexport unlink_framebuffer() drivers/gpu/drm/drm_fb_helper.c | 16 +- drivers/gpu/drm/udl/udl_drv.c | 1 - drivers/gpu/drm/udl/udl_drv.h | 6 - drivers/gpu/drm/udl/udl_fb.c | 282 ------------------------------ drivers/gpu/drm/udl/udl_gem.c | 18 +- drivers/gpu/drm/udl/udl_main.c | 5 +- drivers/gpu/drm/udl/udl_modeset.c | 3 +- drivers/video/fbdev/core/fbmem.c | 3 +- include/drm/drm_fb_helper.h | 6 - include/linux/fb.h | 1 - 10 files changed, 6 insertions(+), 335 deletions(-) -- 2.23.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: [PATCH v3 0/5] drm/udl: Replace fbdev by generic emulation Date: Tue, 12 Nov 2019 15:04:26 +0100 Message-ID: <20191112140431.7895-1-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96E1D6E441 for ; Tue, 12 Nov 2019 14:04:35 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@redhat.com, sean@poorly.run, daniel@ffwll.ch, b.zolnierkie@samsung.com, noralf@tronnes.org, kraxel@redhat.com, sam@ravnborg.org, emil.velikov@collabora.com Cc: linux-fbdev@vger.kernel.org, Thomas Zimmermann , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlIHVkbCBkcml2ZXIgY2FuIHVzZSB0aGUgZ2VuZXJpYyBmYmRldiBlbXVsYXRpb24uIEFmdGVy IGNvbnZlcnNpb24sCmEgbnVtYmVyIG9mIGNsZWFudXBzIGNhbiBiZSBhcHBsaWVkLgoKUGF0Y2gg MSBwcmVwYXJlcyB0aGUgcHJlZmVyZWQgZGVmYXVsdHMuIDMyIGJwcCB3b3JrIHdlbGwgd2l0aCBk cml2ZXIsCmNvbnNvbGUgYW5kIFgxMS4gVGhlIGZiZGV2IGNvbnZlcnNpb24gaXMgaW4gcGF0Y2gg Mi4gVGhlIG9yaWdpbmFsIGZiZGV2CmNvZGUgaW4gdWRsIG1hcHBlZCB0aGUgZnJhbWVidWZmZXIn cyBHRU0gb2JqZWN0IG1lbW9yeSB1bmNvbmRpdGlvbmFsbHksCmFuZCB1bm1hcHBlZCB0aGUgbWVt b3J5IGluIHRoZSBvYmplY3QncyBmcmVlKCkgZnVuY3Rpb24uIFRoZSByZXNwZWN0aXZlCmNvZGUg aW4gZnJlZSgpIGNhbiBub3cgYmUgcmVtb3ZlZCAoUGF0Y2ggMykuIEFuZCBhcyB1ZGwgd2FzIHRo ZQpvbmx5IHJlbWFpbmluZyBleHRlcm5hbCB1c2VyIG9mIHVubGlua19mcmFtZWJ1ZmZlcigpLCB0 aGF0IGZ1bmN0aW9uCm5vdyBiZWNvbWVzIGFuIGludGVybmFsIGludGVyZmFjZSBvZiB0aGUgZmJk ZXYgY29kZSAoUGF0Y2hlcyA0ICsgNSkuCgpUaGUgcGF0Y2hzZXQgaGFzIGJlZW4gdGVzdGVkIGJ5 IHJ1bm5pbmcgdGhlIGNvbnNvbGUsIFgxMSBhbmQgV2VzdG9uCm9uIGEgRGlzcGxheUxpbmsgYWRh cHRlci4KCnYzOgoJKiB1c2UgMzIgYnBwIGJ5IGRlZmF1bHQKCSogdXNlIGRlZmF1bHRzIGZvciBz ZXZlcmFsIGNhbGxiYWNrIGZ1bmN0aW9ucwoJKiByZW1vdmUgYWxsIGZiIG1vZHVsZSBwYXJhbWV0 ZXJzCgkqIHJlbW92ZSB1ZGxfZmJkZXZfaW5pdCgpCnYyOgoJKiBjb252ZXJ0ZWQgdWRsIHRvIFNI TUVNIGFuZCByZWNyZWF0ZWQgZmJkZXYgcGF0Y2hzZXQgb24gdG9wCgpUaG9tYXMgWmltbWVybWFu biAoNSk6CiAgZHJtL3VkbDogU2V0IGRlZmF1bHQgY29sb3IgZGVwdGggdG8gMzIgYnBwCiAgZHJt L3VkbDogUmVwbGFjZSBmYmRldiBjb2RlIHdpdGggZ2VuZXJpYyBlbXVsYXRpb24KICBkcm0vdWRs OiBSZW1vdmUgdWRsIGltcGxlbWVudGF0aW9uIG9mIEdFTSdzIGZyZWVfb2JqZWN0KCkKICBkcm0v ZmItaGVscGVyOiBSZW1vdmUgZHJtX2ZiX2hlbHBlcl91bmxpbmtfZmJpKCkKICBmYmRldjogVW5l eHBvcnQgdW5saW5rX2ZyYW1lYnVmZmVyKCkKCiBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBl ci5jICAgfCAgMTYgKy0KIGRyaXZlcnMvZ3B1L2RybS91ZGwvdWRsX2Rydi5jICAgICB8ICAgMSAt CiBkcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9kcnYuaCAgICAgfCAgIDYgLQogZHJpdmVycy9ncHUv ZHJtL3VkbC91ZGxfZmIuYyAgICAgIHwgMjgyIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfZ2VtLmMgICAgIHwgIDE4ICstCiBkcml2ZXJzL2dw dS9kcm0vdWRsL3VkbF9tYWluLmMgICAgfCAgIDUgKy0KIGRyaXZlcnMvZ3B1L2RybS91ZGwvdWRs X21vZGVzZXQuYyB8ICAgMyArLQogZHJpdmVycy92aWRlby9mYmRldi9jb3JlL2ZibWVtLmMgIHwg ICAzICstCiBpbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmggICAgICAgfCAgIDYgLQogaW5jbHVk ZS9saW51eC9mYi5oICAgICAgICAgICAgICAgIHwgICAxIC0KIDEwIGZpbGVzIGNoYW5nZWQsIDYg aW5zZXJ0aW9ucygrKSwgMzM1IGRlbGV0aW9ucygtKQoKLS0KMi4yMy4wCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=