From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Date: Tue, 12 Nov 2019 14:04:30 +0000 Subject: [PATCH v3 4/5] drm/fb-helper: Remove drm_fb_helper_unlink_fbi() Message-Id: <20191112140431.7895-5-tzimmermann@suse.de> List-Id: References: <20191112140431.7895-1-tzimmermann@suse.de> In-Reply-To: <20191112140431.7895-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: airlied@redhat.com, sean@poorly.run, daniel@ffwll.ch, b.zolnierkie@samsung.com, noralf@tronnes.org, kraxel@redhat.com, sam@ravnborg.org, emil.velikov@collabora.com Cc: linux-fbdev@vger.kernel.org, Thomas Zimmermann , dri-devel@lists.freedesktop.org There are no callers of drm_fb_helper_unlink_fbi() left. Remove the function. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 16 +--------------- include/drm/drm_fb_helper.h | 6 ------ 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 1038a2f0639e..eb97f34a15ea 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -563,8 +563,7 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi); * drm_fb_helper_fini - finialize a &struct drm_fb_helper * @fb_helper: driver-allocated fbdev helper, can be NULL * - * This cleans up all remaining resources associated with @fb_helper. Must be - * called after drm_fb_helper_unlink_fbi() was called. + * This cleans up all remaining resources associated with @fb_helper. */ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper) { @@ -604,19 +603,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper) } EXPORT_SYMBOL(drm_fb_helper_fini); -/** - * drm_fb_helper_unlink_fbi - wrapper around unlink_framebuffer - * @fb_helper: driver-allocated fbdev helper, can be NULL - * - * A wrapper around unlink_framebuffer implemented by fbdev core - */ -void drm_fb_helper_unlink_fbi(struct drm_fb_helper *fb_helper) -{ - if (fb_helper && fb_helper->fbdev) - unlink_framebuffer(fb_helper->fbdev); -} -EXPORT_SYMBOL(drm_fb_helper_unlink_fbi); - static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper) { struct drm_device *dev = fb_helper->dev; diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index e3a75ff07390..1c2e0c3cf857 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -231,8 +231,6 @@ void drm_fb_helper_fill_info(struct fb_info *info, struct drm_fb_helper *fb_helper, struct drm_fb_helper_surface_size *sizes); -void drm_fb_helper_unlink_fbi(struct drm_fb_helper *fb_helper); - void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagelist); @@ -356,10 +354,6 @@ static inline int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, return 0; } -static inline void drm_fb_helper_unlink_fbi(struct drm_fb_helper *fb_helper) -{ -} - static inline void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagelist) { -- 2.23.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: [PATCH v3 4/5] drm/fb-helper: Remove drm_fb_helper_unlink_fbi() Date: Tue, 12 Nov 2019 15:04:30 +0100 Message-ID: <20191112140431.7895-5-tzimmermann@suse.de> References: <20191112140431.7895-1-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0EEC16E45E for ; Tue, 12 Nov 2019 14:04:37 +0000 (UTC) In-Reply-To: <20191112140431.7895-1-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@redhat.com, sean@poorly.run, daniel@ffwll.ch, b.zolnierkie@samsung.com, noralf@tronnes.org, kraxel@redhat.com, sam@ravnborg.org, emil.velikov@collabora.com Cc: linux-fbdev@vger.kernel.org, Thomas Zimmermann , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlcmUgYXJlIG5vIGNhbGxlcnMgb2YgZHJtX2ZiX2hlbHBlcl91bmxpbmtfZmJpKCkgbGVmdC4g UmVtb3ZlIHRoZQpmdW5jdGlvbi4KClNpZ25lZC1vZmYtYnk6IFRob21hcyBaaW1tZXJtYW5uIDx0 emltbWVybWFubkBzdXNlLmRlPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMg fCAxNiArLS0tLS0tLS0tLS0tLS0tCiBpbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmggICAgIHwg IDYgLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyMSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwppbmRleCAxMDM4YTJmMDYzOWUuLmViOTdmMzRhMTVl YSAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYworKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCkBAIC01NjMsOCArNTYzLDcgQEAgRVhQT1JUX1NZ TUJPTChkcm1fZmJfaGVscGVyX3VucmVnaXN0ZXJfZmJpKTsKICAqIGRybV9mYl9oZWxwZXJfZmlu aSAtIGZpbmlhbGl6ZSBhICZzdHJ1Y3QgZHJtX2ZiX2hlbHBlcgogICogQGZiX2hlbHBlcjogZHJp dmVyLWFsbG9jYXRlZCBmYmRldiBoZWxwZXIsIGNhbiBiZSBOVUxMCiAgKgotICogVGhpcyBjbGVh bnMgdXAgYWxsIHJlbWFpbmluZyByZXNvdXJjZXMgYXNzb2NpYXRlZCB3aXRoIEBmYl9oZWxwZXIu IE11c3QgYmUKLSAqIGNhbGxlZCBhZnRlciBkcm1fZmJfaGVscGVyX3VubGlua19mYmkoKSB3YXMg Y2FsbGVkLgorICogVGhpcyBjbGVhbnMgdXAgYWxsIHJlbWFpbmluZyByZXNvdXJjZXMgYXNzb2Np YXRlZCB3aXRoIEBmYl9oZWxwZXIuCiAgKi8KIHZvaWQgZHJtX2ZiX2hlbHBlcl9maW5pKHN0cnVj dCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIpCiB7CkBAIC02MDQsMTkgKzYwMyw2IEBAIHZvaWQg ZHJtX2ZiX2hlbHBlcl9maW5pKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIpCiB9CiBF WFBPUlRfU1lNQk9MKGRybV9mYl9oZWxwZXJfZmluaSk7CiAKLS8qKgotICogZHJtX2ZiX2hlbHBl cl91bmxpbmtfZmJpIC0gd3JhcHBlciBhcm91bmQgdW5saW5rX2ZyYW1lYnVmZmVyCi0gKiBAZmJf aGVscGVyOiBkcml2ZXItYWxsb2NhdGVkIGZiZGV2IGhlbHBlciwgY2FuIGJlIE5VTEwKLSAqCi0g KiBBIHdyYXBwZXIgYXJvdW5kIHVubGlua19mcmFtZWJ1ZmZlciBpbXBsZW1lbnRlZCBieSBmYmRl diBjb3JlCi0gKi8KLXZvaWQgZHJtX2ZiX2hlbHBlcl91bmxpbmtfZmJpKHN0cnVjdCBkcm1fZmJf aGVscGVyICpmYl9oZWxwZXIpCi17Ci0JaWYgKGZiX2hlbHBlciAmJiBmYl9oZWxwZXItPmZiZGV2 KQotCQl1bmxpbmtfZnJhbWVidWZmZXIoZmJfaGVscGVyLT5mYmRldik7Ci19Ci1FWFBPUlRfU1lN Qk9MKGRybV9mYl9oZWxwZXJfdW5saW5rX2ZiaSk7Ci0KIHN0YXRpYyBib29sIGRybV9mYmRldl91 c2Vfc2hhZG93X2ZiKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIpCiB7CiAJc3RydWN0 IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2OwpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9k cm0vZHJtX2ZiX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCmluZGV4IGUz YTc1ZmYwNzM5MC4uMWMyZTBjM2NmODU3IDEwMDY0NAotLS0gYS9pbmNsdWRlL2RybS9kcm1fZmJf aGVscGVyLmgKKysrIGIvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCkBAIC0yMzEsOCArMjMx LDYgQEAgdm9pZCBkcm1fZmJfaGVscGVyX2ZpbGxfaW5mbyhzdHJ1Y3QgZmJfaW5mbyAqaW5mbywK IAkJCSAgICAgc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKIAkJCSAgICAgc3RydWN0 IGRybV9mYl9oZWxwZXJfc3VyZmFjZV9zaXplICpzaXplcyk7CiAKLXZvaWQgZHJtX2ZiX2hlbHBl cl91bmxpbmtfZmJpKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIpOwotCiB2b2lkIGRy bV9mYl9oZWxwZXJfZGVmZXJyZWRfaW8oc3RydWN0IGZiX2luZm8gKmluZm8sCiAJCQkgICAgICAg c3RydWN0IGxpc3RfaGVhZCAqcGFnZWxpc3QpOwogCkBAIC0zNTYsMTAgKzM1NCw2IEBAIHN0YXRp YyBpbmxpbmUgaW50IGRybV9mYl9oZWxwZXJfaW9jdGwoc3RydWN0IGZiX2luZm8gKmluZm8sIHVu c2lnbmVkIGludCBjbWQsCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbmxpbmUgdm9pZCBkcm1f ZmJfaGVscGVyX3VubGlua19mYmkoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcikKLXsK LX0KLQogc3RhdGljIGlubGluZSB2b2lkIGRybV9mYl9oZWxwZXJfZGVmZXJyZWRfaW8oc3RydWN0 IGZiX2luZm8gKmluZm8sCiAJCQkJCSAgICAgc3RydWN0IGxpc3RfaGVhZCAqcGFnZWxpc3QpCiB7 Ci0tIAoyLjIzLjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bA==