From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Devarsh Thakkar <devarsh.thakkar@xilinx.com>
Cc: rsk@xilinx.com, vcu-team@xilinx.com, dshah@xilinx.com,
dri-devel@lists.freedesktop.org, varunkum@xilinx.com,
satishna@xilinx.com
Subject: Re: [PATCH libdrm v3] modetest: Add support for setting mode having floating vertical refresh rate
Date: Tue, 12 Nov 2019 18:50:20 +0200 [thread overview]
Message-ID: <20191112165020.GR1208@intel.com> (raw)
In-Reply-To: <1573472842-4626-1-git-send-email-devarsh.thakkar@xilinx.com>
On Mon, Nov 11, 2019 at 03:47:22AM -0800, Devarsh Thakkar wrote:
> For the scenario where user may require to modeset with a mode
> supporting a fractional value for vertical refresh-rate,
> appropriate mode can be selected by searching for mode
> having matching fractional vertical refresh rate using
> below equation.
>
> vrefresh = (1000 * pixel clock) / (htotal * vtotal) Hz.
>
> We do this way since driver doesn't return float value of vrefresh
> as it use int for vrefresh in struct drm_mode_info, but we can derive
> the actual value using pixel clock, horizontal total size and
> vertical total size values.
>
> So for e.g. if user want to select mode having 59.94 Hz as refresh rate
> then with this patch it be can done as shown in below command,
> given there is an appropriate mode is available :
>
> modetest -M xlnx -s 39:1920x1080-59.94@BG24 -v
>
> NOTE: Above command was tested on xilinx DRM driver with DP
> monitor which was supporting mode having 59.94 Hz refresh rate.
>
> Signed-off-by: Devarsh Thakkar <devarsh.thakkar@xilinx.com>
> ---
> V2: Update commit message
> V3: Update with below changes as per review comments :
> 1) Use epsilon for vrefresh comparison
> 2) Use implicit type-casting wherever possible
Please keep these in the commit msg proper. We prefer these things
to hang around even when the patch gets pushed.
Patch lgtm.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
You should do something to eliminate this. Doesn't make sense for
open source stuff.
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-11-12 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 11:47 [PATCH libdrm v3] modetest: Add support for setting mode having floating vertical refresh rate Devarsh Thakkar
2019-11-12 16:50 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112165020.GR1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=devarsh.thakkar@xilinx.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dshah@xilinx.com \
--cc=rsk@xilinx.com \
--cc=satishna@xilinx.com \
--cc=varunkum@xilinx.com \
--cc=vcu-team@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.