From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2F5C17440 for ; Tue, 12 Nov 2019 20:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F4E1206A3 for ; Tue, 12 Nov 2019 20:45:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AsvHvDs3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbfKLUov (ORCPT ); Tue, 12 Nov 2019 15:44:51 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37265 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726936AbfKLUov (ORCPT ); Tue, 12 Nov 2019 15:44:51 -0500 Received: by mail-qt1-f196.google.com with SMTP id g50so21301374qtb.4 for ; Tue, 12 Nov 2019 12:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XIC1APSxWrFcW1GblyShF0CTBN3WBCz4HlbvzX3i8nA=; b=AsvHvDs3axCMUqe+N7mXppqZcG4z4QzjW7DgwuxQQSvowjzw09zSM8n30iqPxyhiVG Xh8VyKwma0MzyaZ4I7in3iXleDEuEusIaoOY6nDlenNeAk67Wg5jNcvcitJtB14ouZSU jEwtlMvkVKE/9wAQOETCpzIOvdkPz6MUeIKWQaYMSrFJbWX7VcVwtA5CNXlEKm0VsyqY ifzvXwANYm60xkTRX8oLmVVhv+FGDqeTm28/AUUM6Qiw102m5SB7HZ3RG7baH2DiI3v+ pcZdlJkq9BzOBgC+D5ynKGUuwhq6rk47T2j6RjHfuuaJ84S/d0bRcfAl5P4tkZR1pUiM WWGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XIC1APSxWrFcW1GblyShF0CTBN3WBCz4HlbvzX3i8nA=; b=Ln0PXTyab18pP53xaj8s3a6u1QaKltGFPZGLXgXGrVXufxYTerxgcmsb36hnnL4oqm wVMWHM0gsOp9F7IQGTpdkvtQZlc+cZTk8UXXRmFfk6QMiKnkk6/cF+qH6Tlq+gCr9Zhu KFOy95OZ8A2YbZDvs/du9GLetR3CZg0DLNzyWfrCTYIFB/2XQEV00OYNeYIPENdZFoP8 H07EnfsUrVsrITlHfShXIceeJv+kk8TVkCxjAOSBuTYaM5xXIY0Voxv1C3CA2RacCIOh uFL2xihgp9P4ZD+riWMbO5aV1AKnMYyiU5dCuA8KwuvPOmA7gBCvXyhnoIIu0qYOn9Z5 vuPw== X-Gm-Message-State: APjAAAVItcAyKTe2/0EGPOsLDnzjLMutpOOFp1Pzre628c+Vlsr/jVtd KBWhDeIZAvPz+HZ30KBVyvq/Rg== X-Google-Smtp-Source: APXvYqxT1AevYU83mBSAAzVL5cKCr9RO3QTTsZEZsQx1j+Xe2+nGL/UnUh0Po7qNt16fHJ031L5RZg== X-Received: by 2002:ac8:6641:: with SMTP id j1mr34362241qtp.48.1573591490500; Tue, 12 Nov 2019 12:44:50 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id u67sm4906223qkf.115.2019.11.12.12.44.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 12:44:49 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iUd1t-00047P-Dy; Tue, 12 Nov 2019 16:44:49 -0400 Date: Tue, 12 Nov 2019 16:44:49 -0400 From: Jason Gunthorpe To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jens Axboe , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v3 11/23] IB/{core,hw,umem}: set FOLL_PIN, FOLL_LONGTERM via pin_longterm_pages*() Message-ID: <20191112204449.GF5584@ziepe.ca> References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-12-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112000700.3455038-12-jhubbard@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Nov 11, 2019 at 04:06:48PM -0800, John Hubbard wrote: > @@ -542,7 +541,7 @@ static int ib_umem_odp_map_dma_single_page( > } > > out: > - put_user_page(page); > + put_page(page); > > if (remove_existing_mapping) { > ib_umem_notifier_start_account(umem_odp); > @@ -639,13 +638,14 @@ int ib_umem_odp_map_dma_pages(struct ib_umem_odp *umem_odp, u64 user_virt, > /* > * Note: this might result in redundent page getting. We can > * avoid this by checking dma_list to be 0 before calling > - * get_user_pages. However, this make the code much more > - * complex (and doesn't gain us much performance in most use > - * cases). > + * get_user_pages. However, this makes the code much > + * more complex (and doesn't gain us much performance in most > + * use cases). > */ > npages = get_user_pages_remote(owning_process, owning_mm, > - user_virt, gup_num_pages, > - flags, local_page_list, NULL, NULL); > + user_virt, gup_num_pages, > + flags, local_page_list, NULL, > + NULL); > up_read(&owning_mm->mmap_sem); This is just whitespace churn? Drop it.. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF639C43331 for ; Tue, 12 Nov 2019 20:49:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 795E92067B for ; Tue, 12 Nov 2019 20:49:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AsvHvDs3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 795E92067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47CKbf261gzF4YZ for ; Wed, 13 Nov 2019 07:49:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ziepe.ca (client-ip=2607:f8b0:4864:20::844; helo=mail-qt1-x844.google.com; envelope-from=jgg@ziepe.ca; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.b="AsvHvDs3"; dkim-atps=neutral Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47CKVv1QL3zF4H2 for ; Wed, 13 Nov 2019 07:44:54 +1100 (AEDT) Received: by mail-qt1-x844.google.com with SMTP id y39so21353579qty.0 for ; Tue, 12 Nov 2019 12:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XIC1APSxWrFcW1GblyShF0CTBN3WBCz4HlbvzX3i8nA=; b=AsvHvDs3axCMUqe+N7mXppqZcG4z4QzjW7DgwuxQQSvowjzw09zSM8n30iqPxyhiVG Xh8VyKwma0MzyaZ4I7in3iXleDEuEusIaoOY6nDlenNeAk67Wg5jNcvcitJtB14ouZSU jEwtlMvkVKE/9wAQOETCpzIOvdkPz6MUeIKWQaYMSrFJbWX7VcVwtA5CNXlEKm0VsyqY ifzvXwANYm60xkTRX8oLmVVhv+FGDqeTm28/AUUM6Qiw102m5SB7HZ3RG7baH2DiI3v+ pcZdlJkq9BzOBgC+D5ynKGUuwhq6rk47T2j6RjHfuuaJ84S/d0bRcfAl5P4tkZR1pUiM WWGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XIC1APSxWrFcW1GblyShF0CTBN3WBCz4HlbvzX3i8nA=; b=Hs6rRjf4IEfUAnLI+zz4Kvyko+QDPNIxhXVVTrtz/epgoiLGXiwbLie4zbouUCJPSp WvNknkSjLv6YtH/8qKjRdZNb3xXWMWF0PQyQrgaOwAe1VsOnqhEr5X0tgO9j1swlm6G8 Gfq4YzxU/E5/lA/IbIcMyxaxn5eyW4VTJz99QdGzQy8Rp6mbcKFyMUyhmiIO84yvBmgK jEGMI3DGLXG9g5ricyVp7i+SDJ8z+NX6bdtD1rERkmme3doH5m59+Jj2qxmazTAZYDDx Eq1/huIvZkVCYCHFi+Qpnr8U4zNR0M2+yXcYi1CwwJlwTx98i1ADXWaBToEoI3QVslSA Xqrw== X-Gm-Message-State: APjAAAVDOT6DUpWvq8DEUH/9oQybvGgAeCQ6fKcEmaEADKKDZhH04vFD u53tCfoc++Gksyrxj6fAmhngPw== X-Google-Smtp-Source: APXvYqxT1AevYU83mBSAAzVL5cKCr9RO3QTTsZEZsQx1j+Xe2+nGL/UnUh0Po7qNt16fHJ031L5RZg== X-Received: by 2002:ac8:6641:: with SMTP id j1mr34362241qtp.48.1573591490500; Tue, 12 Nov 2019 12:44:50 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id u67sm4906223qkf.115.2019.11.12.12.44.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 12:44:49 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iUd1t-00047P-Dy; Tue, 12 Nov 2019 16:44:49 -0400 Date: Tue, 12 Nov 2019 16:44:49 -0400 From: Jason Gunthorpe To: John Hubbard Subject: Re: [PATCH v3 11/23] IB/{core,hw,umem}: set FOLL_PIN, FOLL_LONGTERM via pin_longterm_pages*() Message-ID: <20191112204449.GF5584@ziepe.ca> References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-12-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112000700.3455038-12-jhubbard@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Christoph Hellwig , Vlastimil Babka , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , Daniel Vetter , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Nov 11, 2019 at 04:06:48PM -0800, John Hubbard wrote: > @@ -542,7 +541,7 @@ static int ib_umem_odp_map_dma_single_page( > } > > out: > - put_user_page(page); > + put_page(page); > > if (remove_existing_mapping) { > ib_umem_notifier_start_account(umem_odp); > @@ -639,13 +638,14 @@ int ib_umem_odp_map_dma_pages(struct ib_umem_odp *umem_odp, u64 user_virt, > /* > * Note: this might result in redundent page getting. We can > * avoid this by checking dma_list to be 0 before calling > - * get_user_pages. However, this make the code much more > - * complex (and doesn't gain us much performance in most use > - * cases). > + * get_user_pages. However, this makes the code much > + * more complex (and doesn't gain us much performance in most > + * use cases). > */ > npages = get_user_pages_remote(owning_process, owning_mm, > - user_virt, gup_num_pages, > - flags, local_page_list, NULL, NULL); > + user_virt, gup_num_pages, > + flags, local_page_list, NULL, > + NULL); > up_read(&owning_mm->mmap_sem); This is just whitespace churn? Drop it.. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 11/23] IB/{core,hw,umem}: set FOLL_PIN, FOLL_LONGTERM via pin_longterm_pages*() Date: Tue, 12 Nov 2019 16:44:49 -0400 Message-ID: <20191112204449.GF5584@ziepe.ca> References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-12-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191112000700.3455038-12-jhubbard@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jens Axboe , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman List-Id: dri-devel@lists.freedesktop.org On Mon, Nov 11, 2019 at 04:06:48PM -0800, John Hubbard wrote: > @@ -542,7 +541,7 @@ static int ib_umem_odp_map_dma_single_page( > } > > out: > - put_user_page(page); > + put_page(page); > > if (remove_existing_mapping) { > ib_umem_notifier_start_account(umem_odp); > @@ -639,13 +638,14 @@ int ib_umem_odp_map_dma_pages(struct ib_umem_odp *umem_odp, u64 user_virt, > /* > * Note: this might result in redundent page getting. We can > * avoid this by checking dma_list to be 0 before calling > - * get_user_pages. However, this make the code much more > - * complex (and doesn't gain us much performance in most use > - * cases). > + * get_user_pages. However, this makes the code much > + * more complex (and doesn't gain us much performance in most > + * use cases). > */ > npages = get_user_pages_remote(owning_process, owning_mm, > - user_virt, gup_num_pages, > - flags, local_page_list, NULL, NULL); > + user_virt, gup_num_pages, > + flags, local_page_list, NULL, > + NULL); > up_read(&owning_mm->mmap_sem); This is just whitespace churn? Drop it.. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33639C17442 for ; Wed, 13 Nov 2019 07:56:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15B4E222C1 for ; Wed, 13 Nov 2019 07:56:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15B4E222C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 569EE6E5B4; Wed, 13 Nov 2019 07:55:50 +0000 (UTC) Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by gabe.freedesktop.org (Postfix) with ESMTPS id 587A56EBD4 for ; Tue, 12 Nov 2019 20:44:51 +0000 (UTC) Received: by mail-qt1-x843.google.com with SMTP id o49so21306196qta.7 for ; Tue, 12 Nov 2019 12:44:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XIC1APSxWrFcW1GblyShF0CTBN3WBCz4HlbvzX3i8nA=; b=kY4XF86iWmV9VSW8kxC2vXUAyC8t+nw6yOoXCeG7ZcJo5auA3yJbT0gyZYgRlQgpwI 4DPd/4qvGI9co0YXNtJC6px1doL7deTyngLRgelP2T4i5ZN23LnmEiVZdQdlbK1ZKIYa KnUKemRnN22M2HQAOxc2cG3Q7gSUmE7+64jn2uMyy4fInyrOKK9Q6LqvsxxZgzibkt3R VvEoJ2Yp6uS7F96n/qPn1FhQim2f15S6LJzUHmoulpx2S/gGlSZEk5A7Q8P02Tfh4oZ7 y3+bw7d1gUizJuHq+kO6Cv8VAJ+Aj4cBePvDJxNlRLF5+u+WLgQKbymzmO69kNgdslE6 1hQg== X-Gm-Message-State: APjAAAVOcCoc4QzDyznAQo6Be9c2TZOq/SU5WvSwrpOgE0cbz94vzJyh OuGKavG2aS60nLuTBmV1xsHing== X-Google-Smtp-Source: APXvYqxT1AevYU83mBSAAzVL5cKCr9RO3QTTsZEZsQx1j+Xe2+nGL/UnUh0Po7qNt16fHJ031L5RZg== X-Received: by 2002:ac8:6641:: with SMTP id j1mr34362241qtp.48.1573591490500; Tue, 12 Nov 2019 12:44:50 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id u67sm4906223qkf.115.2019.11.12.12.44.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 12:44:49 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iUd1t-00047P-Dy; Tue, 12 Nov 2019 16:44:49 -0400 Date: Tue, 12 Nov 2019 16:44:49 -0400 From: Jason Gunthorpe To: John Hubbard Subject: Re: [PATCH v3 11/23] IB/{core,hw,umem}: set FOLL_PIN, FOLL_LONGTERM via pin_longterm_pages*() Message-ID: <20191112204449.GF5584@ziepe.ca> References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-12-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112000700.3455038-12-jhubbard@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Wed, 13 Nov 2019 07:55:45 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XIC1APSxWrFcW1GblyShF0CTBN3WBCz4HlbvzX3i8nA=; b=AsvHvDs3axCMUqe+N7mXppqZcG4z4QzjW7DgwuxQQSvowjzw09zSM8n30iqPxyhiVG Xh8VyKwma0MzyaZ4I7in3iXleDEuEusIaoOY6nDlenNeAk67Wg5jNcvcitJtB14ouZSU jEwtlMvkVKE/9wAQOETCpzIOvdkPz6MUeIKWQaYMSrFJbWX7VcVwtA5CNXlEKm0VsyqY ifzvXwANYm60xkTRX8oLmVVhv+FGDqeTm28/AUUM6Qiw102m5SB7HZ3RG7baH2DiI3v+ pcZdlJkq9BzOBgC+D5ynKGUuwhq6rk47T2j6RjHfuuaJ84S/d0bRcfAl5P4tkZR1pUiM WWGA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Vlastimil Babka , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191112204449.XSPW0uprW_Dorwp4owfAWK4MoHv4_B2VL_FFeuPBlDs@z> T24gTW9uLCBOb3YgMTEsIDIwMTkgYXQgMDQ6MDY6NDhQTSAtMDgwMCwgSm9obiBIdWJiYXJkIHdy b3RlOgo+IEBAIC01NDIsNyArNTQxLDcgQEAgc3RhdGljIGludCBpYl91bWVtX29kcF9tYXBfZG1h X3NpbmdsZV9wYWdlKAo+ICAJfQo+ICAKPiAgb3V0Ogo+IC0JcHV0X3VzZXJfcGFnZShwYWdlKTsK PiArCXB1dF9wYWdlKHBhZ2UpOwo+ICAKPiAgCWlmIChyZW1vdmVfZXhpc3RpbmdfbWFwcGluZykg ewo+ICAJCWliX3VtZW1fbm90aWZpZXJfc3RhcnRfYWNjb3VudCh1bWVtX29kcCk7Cj4gQEAgLTYz OSwxMyArNjM4LDE0IEBAIGludCBpYl91bWVtX29kcF9tYXBfZG1hX3BhZ2VzKHN0cnVjdCBpYl91 bWVtX29kcCAqdW1lbV9vZHAsIHU2NCB1c2VyX3ZpcnQsCj4gIAkJLyoKPiAgCQkgKiBOb3RlOiB0 aGlzIG1pZ2h0IHJlc3VsdCBpbiByZWR1bmRlbnQgcGFnZSBnZXR0aW5nLiBXZSBjYW4KPiAgCQkg KiBhdm9pZCB0aGlzIGJ5IGNoZWNraW5nIGRtYV9saXN0IHRvIGJlIDAgYmVmb3JlIGNhbGxpbmcK PiAtCQkgKiBnZXRfdXNlcl9wYWdlcy4gSG93ZXZlciwgdGhpcyBtYWtlIHRoZSBjb2RlIG11Y2gg bW9yZQo+IC0JCSAqIGNvbXBsZXggKGFuZCBkb2Vzbid0IGdhaW4gdXMgbXVjaCBwZXJmb3JtYW5j ZSBpbiBtb3N0IHVzZQo+IC0JCSAqIGNhc2VzKS4KPiArCQkgKiBnZXRfdXNlcl9wYWdlcy4gSG93 ZXZlciwgdGhpcyBtYWtlcyB0aGUgY29kZSBtdWNoCj4gKwkJICogbW9yZSBjb21wbGV4IChhbmQg ZG9lc24ndCBnYWluIHVzIG11Y2ggcGVyZm9ybWFuY2UgaW4gbW9zdAo+ICsJCSAqIHVzZSBjYXNl cykuCj4gIAkJICovCj4gIAkJbnBhZ2VzID0gZ2V0X3VzZXJfcGFnZXNfcmVtb3RlKG93bmluZ19w cm9jZXNzLCBvd25pbmdfbW0sCj4gLQkJCQl1c2VyX3ZpcnQsIGd1cF9udW1fcGFnZXMsCj4gLQkJ CQlmbGFncywgbG9jYWxfcGFnZV9saXN0LCBOVUxMLCBOVUxMKTsKPiArCQkJCQkgICAgICAgdXNl cl92aXJ0LCBndXBfbnVtX3BhZ2VzLAo+ICsJCQkJCSAgICAgICBmbGFncywgbG9jYWxfcGFnZV9s aXN0LCBOVUxMLAo+ICsJCQkJCSAgICAgICBOVUxMKTsKPiAgCQl1cF9yZWFkKCZvd25pbmdfbW0t Pm1tYXBfc2VtKTsKClRoaXMgaXMganVzdCB3aGl0ZXNwYWNlIGNodXJuPyBEcm9wIGl0Li4KCkph c29uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==