From: Wolfram Sang <wsa@the-dreams.de>
To: Eugeniu Rosca <erosca@de.adit-jv.com>
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Simon Horman" <horms+renesas@verge.net.au>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
"Eugeniu Rosca" <roscaeugeniu@gmail.com>,
"Harish Jenny K N" <harish_kandiga@mentor.com>,
"Andrew Gabbasov" <andrew_gabbasov@mentor.com>
Subject: Re: [PATCH] mmc: renesas_sdhi_internal_dmac: Add MMC_CAP_ERASE to Gen3 SoCs
Date: Tue, 12 Nov 2019 21:49:52 +0100 [thread overview]
Message-ID: <20191112204952.GA2976@kunai> (raw)
In-Reply-To: <20191112134808.23546-1-erosca@de.adit-jv.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Tue, Nov 12, 2019 at 02:48:08PM +0100, Eugeniu Rosca wrote:
> From: Harish Jenny K N <harish_kandiga@mentor.com>
>
> Enable MMC_CAP_ERASE capability in the driver to allow
> erase/discard/trim requests.
>
> Suggested-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
> [erosca: Forward-port and test on v5.4-rc7 using H3ULCB-KF:
> "blkdiscard /dev/mmcblk0" passes with this patch applied
> and complains otherwise:
> "BLKDISCARD ioctl failed: Operation not supported"]
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Looks good to me. Just a generic question, probably more for Ulf:
Why does this CAP_ERASE exist? As I understand, the driver only needs to
set the flag and no further handling is required. Why would a driver not
set this flag and not support erase/trim commands?
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-11-12 20:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 13:48 [PATCH] mmc: renesas_sdhi_internal_dmac: Add MMC_CAP_ERASE to Gen3 SoCs Eugeniu Rosca
2019-11-12 13:48 ` Eugeniu Rosca
2019-11-12 20:49 ` Wolfram Sang [this message]
2019-11-14 10:56 ` Ulf Hansson
2019-11-14 11:37 ` Eugeniu Rosca
2019-11-14 12:48 ` Ulf Hansson
2019-11-14 20:15 ` Wolfram Sang
2019-11-15 9:19 ` Ulf Hansson
2019-11-15 10:12 ` Wolfram Sang
2019-11-15 10:38 ` Ulf Hansson
2019-11-14 22:07 ` Eugeniu Rosca
2019-11-15 9:27 ` Ulf Hansson
2019-11-15 12:51 ` Eugeniu Rosca
2019-11-15 13:54 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112204952.GA2976@kunai \
--to=wsa@the-dreams.de \
--cc=andrew_gabbasov@mentor.com \
--cc=erosca@de.adit-jv.com \
--cc=geert@linux-m68k.org \
--cc=harish_kandiga@mentor.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=roscaeugeniu@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.