All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] package/qemu: add host-python as an explicit dependency
Date: Tue, 12 Nov 2019 22:05:34 +0100	[thread overview]
Message-ID: <20191112220534.531a470f@windsurf> (raw)
In-Reply-To: <20191111213154.19409-2-avraham.shukron@gmail.com>

On Mon, 11 Nov 2019 23:31:46 +0200
Avi Shukron <avraham.shukron@gmail.com> wrote:

> qemu requires python in its configre script. Yet host-python was
> not listed as one of the package's dependencies. If no other package
> requested host-python, then configuring this package will fail since
> it won't find any executable named python in the host dir.
> 
> In order to reproduce this issue you must not have python2 installed
> on your host machine.
> 
> Signed-off-by: Avi Shukron <avraham.shukron@gmail.com>

qemu needs python 2 *or* python 3, so we can do something like this:

QEMU_DEPENDENCIES = host-pkgconf libglib2 zlib pixman $(if $(BR2_PACKAGE_PYTHON3),host-python3,host-python)

This way, if you have Python 3.x enabled for the target (and therefore
you are already building host-python3), it will use host-python3.

Could you test this in a configuration that has BR2_PACKAGE_QEMU=y and
BR2_PACKAGE_PYTHON3=y, and check it works properly ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-11-12 21:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 21:31 [Buildroot] [PATCH v2 1/2] package/ninja: invoke python3 explicitly to configure the package Avi Shukron
2019-11-11 21:31 ` [Buildroot] [PATCH v2 2/2] package/qemu: add host-python as an explicit dependency Avi Shukron
2019-11-12 21:05   ` Thomas Petazzoni [this message]
2019-11-13 20:22     ` Avraham Shukron
2019-11-15 21:08       ` Thomas Petazzoni
2019-11-15 22:04         ` Avraham Shukron
2019-11-15 22:51           ` Thomas Petazzoni
2019-11-16 11:59             ` Avraham Shukron
2019-11-16 13:49               ` [Buildroot] [PATCH v4] package/qemu: add host-python3 " Avi Shukron
2019-11-15 20:19     ` [Buildroot] [PATCH v3] package/qemu: add host-python " Avi Shukron
2019-11-18 22:22       ` Thomas Petazzoni
2019-11-12 21:04 ` [Buildroot] [PATCH v2 1/2] package/ninja: invoke python3 explicitly to configure the package Thomas Petazzoni
2019-11-18 13:00 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112220534.531a470f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.