From: Greg KH <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 5/9] staging: rtl8723bs: Add necessary braces
Date: Wed, 13 Nov 2019 00:04:05 +0100 [thread overview]
Message-ID: <20191112230405.GA1904763@kroah.com> (raw)
In-Reply-To: <9653d1c5ea7ebd7b4137edea4f5eef74ea65703b.1573577309.git.jarias.linux@gmail.com>
On Tue, Nov 12, 2019 at 11:54:32AM -0500, Javier F. Arias wrote:
> This patchset adds braces when they should be used on all arms of
> the statement.
> Issue found by Checkpatch.
>
> Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 31 +++++++++++++++--------
> 1 file changed, 20 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index fdb585ff5925..42bd5d8362fa 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -370,8 +370,9 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame *
> /* Other fragments are protected by previous fragment. */
> /* So we only need to check the length of first fragment. */
> if (pmlmeext->cur_wireless_mode < WIRELESS_11_24N || padapter->registrypriv.wifi_spec) {
> - if (sz > padapter->registrypriv.rts_thresh)
> + if (sz > padapter->registrypriv.rts_thresh) {
> pattrib->vcs_mode = RTS_CTS;
> + }
> else {
The } should be on the same line as the "else {"
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-12 23:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 16:52 [PATCH 0/9] staging: rtl8723bs: cleanup patches Javier F. Arias
2019-11-12 16:53 ` [PATCH 1/9] staging: rtl8723bs: Remove multiple blank lines Javier F. Arias
2019-11-12 16:53 ` [PATCH 2/9] staging: rtl8723bs: Remove blank lines before a close brace Javier F. Arias
2019-11-12 16:53 ` [PATCH 3/9] staging: rtl8723bs: Remove blank lines after an open brace Javier F. Arias
2019-11-12 16:54 ` [PATCH 4/9] staging: rtl8723bs: Remove unnecessary braces Javier F. Arias
2019-11-12 16:54 ` [PATCH 5/9] staging: rtl8723bs: Add necessary braces Javier F. Arias
2019-11-12 23:04 ` Greg KH [this message]
2019-11-13 0:22 ` [Outreachy kernel] " Javier F. Arias
2019-11-12 16:54 ` [PATCH 6/9] staging: rtl8723bs: Fix unbalanced braces Javier F. Arias
2019-11-12 16:55 ` [PATCH 7/9] staging: rtl8723bs: Fix incorrect type in argument warnings Javier F. Arias
2019-11-12 17:11 ` Joe Perches
2019-11-12 23:00 ` [Outreachy kernel] " Javier F. Arias
2019-11-12 20:33 ` Greg KH
2019-11-13 1:12 ` [Outreachy kernel] " Javier F. Arias
2019-11-12 16:55 ` [PATCH 8/9] staging: rtl8723bs: Remove unnecessary conditional block Javier F. Arias
2019-11-12 16:56 ` [PATCH 9/9] staging: rtl8723bs: Rename variable Javier F. Arias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112230405.GA1904763@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.