From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A19FEC17441 for ; Tue, 12 Nov 2019 23:42:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FB5E206A3 for ; Tue, 12 Nov 2019 23:42:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="it8jHl8A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727073AbfKLXmx (ORCPT ); Tue, 12 Nov 2019 18:42:53 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:33418 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbfKLXmx (ORCPT ); Tue, 12 Nov 2019 18:42:53 -0500 Received: by mail-qt1-f196.google.com with SMTP id y39so522698qty.0 for ; Tue, 12 Nov 2019 15:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vZiC7XI6w4qmcJhiszw5fcLLfKl81FBqJhCu/q1OZew=; b=it8jHl8Aeod0zYq+Skrwrg8GwHh9Iu8Lk4aklL2UU1A7NrkgqGz5TacHTvuZENKCSO zX5vQsxL6WoNuMWNKkEQjxDubFJia3lLQ6vtybpi5bU815x8TqvUIIt9Kr2Uo5cBSRzI 2VZYj93gQX0itc+geQUWbcwpbx7dsR+jspiqHjxUKDMEHdunGEQMz6R4qhshIz6xtcbf Zhwk9IxmoxlDCj68H/K3Yi1WAV8gDwI3vnoSzzJ5OjxNZ+oTEONNaXk9owbEXpdua0Ac Ytg9ljas4ej2TjoNx1nr1x9pd15vss2zsUb9mCqXq0UcPC7FIXHufZoDuL/IWSFTzLDE UAww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vZiC7XI6w4qmcJhiszw5fcLLfKl81FBqJhCu/q1OZew=; b=Bi580Hq9pEvVDS4IVFS2bandTDPrDcWDVZxSKfDeGEvsj5I65FYfqX170s6fTKZ/aA fCOcoV02SRaQc+gsQgl/8PRfdVrvTWAU9u6QuFtFZnxNqivDYfDx6BojmWRF3dww+HYh LBbNgwXf3ksYSFlN3uDAe5+NeqPdytWLIwQKNPXtYkW4N6hB+WIU7sTg+PUe9JBKzoEB Bjc+yDY4jPy9JqFtTtZ/vXWO313BVeFC48Ab3gZzF2tbUKuMU7oG9IbSe29SZO+Kk+zA CJ91FDKQoTLPct61MS4OmOpyNIZdZXq83G5cx4P1Iul6wZee1F6s+eUdhTyWg7LvV8SK BkKQ== X-Gm-Message-State: APjAAAUEYiKhhtj2qSFGt/Pl5zVIeXayuBQuuxcwBPKA/Ig7IVZgBujs Hixo9rrPYj9vqgHAnznDzgXi2w== X-Google-Smtp-Source: APXvYqz3aftIVfOw8Wxd6a6UdmY0tmO8rvvaAb/aUmwkho+fgsveWFsBhLgURBNyxpICpzEXHNU+vQ== X-Received: by 2002:aed:26e2:: with SMTP id q89mr18576100qtd.391.1573602171951; Tue, 12 Nov 2019 15:42:51 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id u11sm212203qtg.11.2019.11.12.15.42.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 15:42:51 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iUfoA-0005Um-OB; Tue, 12 Nov 2019 19:42:50 -0400 Date: Tue, 12 Nov 2019 19:42:50 -0400 From: Jason Gunthorpe To: Dan Williams Cc: John Hubbard , Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jens Axboe , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, Maling list - DRI developers , KVM list , linux-block@vger.kernel.org, Linux Doc Mailing List , linux-fsdevel , linux-kselftest@vger.kernel.org, "Linux-media@vger.kernel.org" , linux-rdma , linuxppc-dev , Netdev , Linux MM , LKML Subject: Re: [PATCH v3 08/23] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM Message-ID: <20191112234250.GA19615@ziepe.ca> References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-9-jhubbard@nvidia.com> <20191112204338.GE5584@ziepe.ca> <0db36e86-b779-01af-77e7-469af2a2e19c@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Nov 12, 2019 at 02:45:51PM -0800, Dan Williams wrote: > On Tue, Nov 12, 2019 at 2:43 PM John Hubbard wrote: > > > > On 11/12/19 12:43 PM, Jason Gunthorpe wrote: > > ... > > >> - } > > >> + ret = get_user_pages_remote(NULL, mm, vaddr, 1, flags | FOLL_LONGTERM, > > >> + page, vmas, NULL); > > >> + /* > > >> + * The lifetime of a vaddr_get_pfn() page pin is > > >> + * userspace-controlled. In the fs-dax case this could > > >> + * lead to indefinite stalls in filesystem operations. > > >> + * Disallow attempts to pin fs-dax pages via this > > >> + * interface. > > >> + */ > > >> + if (ret > 0 && vma_is_fsdax(vmas[0])) { > > >> + ret = -EOPNOTSUPP; > > >> + put_page(page[0]); > > >> } > > > > > > AFAIK this chunk is redundant now as it is some hack to emulate > > > FOLL_LONGTERM? So vmas can be deleted too. > > > > Let me first make sure I understand what Dan has in mind for the vma > > checking, in the other thread... > > It's not redundant relative to upstream which does not do anything the > FOLL_LONGTERM in the gup-slow path... but I have not looked at patches > 1-7 to see if something there made it redundant. Oh, the hunk John had below for get_user_pages_remote() also needs to call __gup_longterm_locked() when FOLL_LONGTERM is specified, then that calls check_dax_vmas() which duplicates the vma_is_fsdax() check above. Certainly no caller of FOLL_LONGTERM should have to do dax specific VMA checking. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A3C5C43331 for ; Tue, 12 Nov 2019 23:45:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAD42206A3 for ; Tue, 12 Nov 2019 23:45:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="it8jHl8A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAD42206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47CPWW1HC2zF5k2 for ; Wed, 13 Nov 2019 10:45:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ziepe.ca (client-ip=2607:f8b0:4864:20::843; helo=mail-qt1-x843.google.com; envelope-from=jgg@ziepe.ca; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.b="it8jHl8A"; dkim-atps=neutral Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47CPSK3VqHzDqVx for ; Wed, 13 Nov 2019 10:42:55 +1100 (AEDT) Received: by mail-qt1-x843.google.com with SMTP id n4so511758qte.2 for ; Tue, 12 Nov 2019 15:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vZiC7XI6w4qmcJhiszw5fcLLfKl81FBqJhCu/q1OZew=; b=it8jHl8Aeod0zYq+Skrwrg8GwHh9Iu8Lk4aklL2UU1A7NrkgqGz5TacHTvuZENKCSO zX5vQsxL6WoNuMWNKkEQjxDubFJia3lLQ6vtybpi5bU815x8TqvUIIt9Kr2Uo5cBSRzI 2VZYj93gQX0itc+geQUWbcwpbx7dsR+jspiqHjxUKDMEHdunGEQMz6R4qhshIz6xtcbf Zhwk9IxmoxlDCj68H/K3Yi1WAV8gDwI3vnoSzzJ5OjxNZ+oTEONNaXk9owbEXpdua0Ac Ytg9ljas4ej2TjoNx1nr1x9pd15vss2zsUb9mCqXq0UcPC7FIXHufZoDuL/IWSFTzLDE UAww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vZiC7XI6w4qmcJhiszw5fcLLfKl81FBqJhCu/q1OZew=; b=HA7sMTiq9goFc4xACcHPmSHPLaU9ryBmZC9SntXjTiRJBhvADVDut3DxSkYqtHXa4C QSHw9/+3XWwy0FX5jSk6Eao+yuR68veX8GphQGDkWIVRdmEWAukpkGotUnjRJMpbXH8a 6QrWFD1NJrPBMUgObcawQ/LkiHD9Z+e+tEK+qlytEGy6BQLgVFadxA5kCbPiWYPGRmAW 8Reis/t+QkrwqncNL2i/AGWv+w5hOOZWPFMRpftriyQb11pavmUAzOCli0CHyvpqK+gd PeAVY/SlHuM2PDrBlB8qqBTYsf8gOvIgB5Iqi9y/7oub1mJvlTiN/RAsnQDyicMmcBut EQ7Q== X-Gm-Message-State: APjAAAUZ4KdUG2I/OL5k+Zdc2uwSsfSbOy2EujvJOn0aG6ojtIrb/fvg aVbkQnn1yJ7kpLpr+8B8u6yG5A== X-Google-Smtp-Source: APXvYqz3aftIVfOw8Wxd6a6UdmY0tmO8rvvaAb/aUmwkho+fgsveWFsBhLgURBNyxpICpzEXHNU+vQ== X-Received: by 2002:aed:26e2:: with SMTP id q89mr18576100qtd.391.1573602171951; Tue, 12 Nov 2019 15:42:51 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id u11sm212203qtg.11.2019.11.12.15.42.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 15:42:51 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iUfoA-0005Um-OB; Tue, 12 Nov 2019 19:42:50 -0400 Date: Tue, 12 Nov 2019 19:42:50 -0400 From: Jason Gunthorpe To: Dan Williams Subject: Re: [PATCH v3 08/23] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM Message-ID: <20191112234250.GA19615@ziepe.ca> References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-9-jhubbard@nvidia.com> <20191112204338.GE5584@ziepe.ca> <0db36e86-b779-01af-77e7-469af2a2e19c@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , KVM list , Linux Doc Mailing List , David Airlie , Dave Chinner , Maling list - DRI developers , LKML , Linux MM , Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma , Christoph Hellwig , Vlastimil Babka , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , "Linux-media@vger.kernel.org" , Shuah Khan , John Hubbard , linux-block@vger.kernel.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Al Viro , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , Netdev , Alex Williamson , Daniel Vetter , linux-fsdevel , Andrew Morton , linuxppc-dev , "David S . Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Nov 12, 2019 at 02:45:51PM -0800, Dan Williams wrote: > On Tue, Nov 12, 2019 at 2:43 PM John Hubbard wrote: > > > > On 11/12/19 12:43 PM, Jason Gunthorpe wrote: > > ... > > >> - } > > >> + ret = get_user_pages_remote(NULL, mm, vaddr, 1, flags | FOLL_LONGTERM, > > >> + page, vmas, NULL); > > >> + /* > > >> + * The lifetime of a vaddr_get_pfn() page pin is > > >> + * userspace-controlled. In the fs-dax case this could > > >> + * lead to indefinite stalls in filesystem operations. > > >> + * Disallow attempts to pin fs-dax pages via this > > >> + * interface. > > >> + */ > > >> + if (ret > 0 && vma_is_fsdax(vmas[0])) { > > >> + ret = -EOPNOTSUPP; > > >> + put_page(page[0]); > > >> } > > > > > > AFAIK this chunk is redundant now as it is some hack to emulate > > > FOLL_LONGTERM? So vmas can be deleted too. > > > > Let me first make sure I understand what Dan has in mind for the vma > > checking, in the other thread... > > It's not redundant relative to upstream which does not do anything the > FOLL_LONGTERM in the gup-slow path... but I have not looked at patches > 1-7 to see if something there made it redundant. Oh, the hunk John had below for get_user_pages_remote() also needs to call __gup_longterm_locked() when FOLL_LONGTERM is specified, then that calls check_dax_vmas() which duplicates the vma_is_fsdax() check above. Certainly no caller of FOLL_LONGTERM should have to do dax specific VMA checking. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 08/23] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM Date: Tue, 12 Nov 2019 19:42:50 -0400 Message-ID: <20191112234250.GA19615@ziepe.ca> References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-9-jhubbard@nvidia.com> <20191112204338.GE5584@ziepe.ca> <0db36e86-b779-01af-77e7-469af2a2e19c@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dan Williams Cc: John Hubbard , Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jens Axboe , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman Mich List-Id: dri-devel@lists.freedesktop.org On Tue, Nov 12, 2019 at 02:45:51PM -0800, Dan Williams wrote: > On Tue, Nov 12, 2019 at 2:43 PM John Hubbard wrote: > > > > On 11/12/19 12:43 PM, Jason Gunthorpe wrote: > > ... > > >> - } > > >> + ret = get_user_pages_remote(NULL, mm, vaddr, 1, flags | FOLL_LONGTERM, > > >> + page, vmas, NULL); > > >> + /* > > >> + * The lifetime of a vaddr_get_pfn() page pin is > > >> + * userspace-controlled. In the fs-dax case this could > > >> + * lead to indefinite stalls in filesystem operations. > > >> + * Disallow attempts to pin fs-dax pages via this > > >> + * interface. > > >> + */ > > >> + if (ret > 0 && vma_is_fsdax(vmas[0])) { > > >> + ret = -EOPNOTSUPP; > > >> + put_page(page[0]); > > >> } > > > > > > AFAIK this chunk is redundant now as it is some hack to emulate > > > FOLL_LONGTERM? So vmas can be deleted too. > > > > Let me first make sure I understand what Dan has in mind for the vma > > checking, in the other thread... > > It's not redundant relative to upstream which does not do anything the > FOLL_LONGTERM in the gup-slow path... but I have not looked at patches > 1-7 to see if something there made it redundant. Oh, the hunk John had below for get_user_pages_remote() also needs to call __gup_longterm_locked() when FOLL_LONGTERM is specified, then that calls check_dax_vmas() which duplicates the vma_is_fsdax() check above. Certainly no caller of FOLL_LONGTERM should have to do dax specific VMA checking. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49D7C43331 for ; Wed, 13 Nov 2019 07:56:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2CC1222C1 for ; Wed, 13 Nov 2019 07:56:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2CC1222C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 89CD66EA46; Wed, 13 Nov 2019 07:56:17 +0000 (UTC) Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02BDB6EC31 for ; Tue, 12 Nov 2019 23:42:52 +0000 (UTC) Received: by mail-qt1-x842.google.com with SMTP id t20so460634qtn.9 for ; Tue, 12 Nov 2019 15:42:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vZiC7XI6w4qmcJhiszw5fcLLfKl81FBqJhCu/q1OZew=; b=oICCMuhGpvELF3EH15c+prhBj2v2+k5A0tXdlZHtozdW8UzKNbCin/uc2hnz4MeZcV erLp+UPlfMGeV7T05xiamnwEvN9bCFr9LpLkQyblIVDrGNxYETWlekFuQ0Kf5ufRI32/ eUDM3QQxoiIkzkc0GuYw6c7eSMfxF4F6N3izpYTYqDsr0QkczLJqQdJjVaV4EERSoDxC DSMKOBubk/5r7dk8kZZOa/xzZp5hH0SJPqsL+w/R+0zXIHJi1OeiICFQ5PT3Dh54A/0u gjPrEql6qob6r2CYOyK7UuXsxVftbt49iyb4i+b9yPKncylB05XkBxupyAul3DQECcSD JrLQ== X-Gm-Message-State: APjAAAWoPGqRpluB/mdYMGL/uwIeCGFB8Ag5BEdEYyw8kV+96MNIAkxa noiNPVPOXckZOszY0lcaWrHyTQ== X-Google-Smtp-Source: APXvYqz3aftIVfOw8Wxd6a6UdmY0tmO8rvvaAb/aUmwkho+fgsveWFsBhLgURBNyxpICpzEXHNU+vQ== X-Received: by 2002:aed:26e2:: with SMTP id q89mr18576100qtd.391.1573602171951; Tue, 12 Nov 2019 15:42:51 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id u11sm212203qtg.11.2019.11.12.15.42.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 15:42:51 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iUfoA-0005Um-OB; Tue, 12 Nov 2019 19:42:50 -0400 Date: Tue, 12 Nov 2019 19:42:50 -0400 From: Jason Gunthorpe To: Dan Williams Subject: Re: [PATCH v3 08/23] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM Message-ID: <20191112234250.GA19615@ziepe.ca> References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-9-jhubbard@nvidia.com> <20191112204338.GE5584@ziepe.ca> <0db36e86-b779-01af-77e7-469af2a2e19c@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Wed, 13 Nov 2019 07:55:45 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vZiC7XI6w4qmcJhiszw5fcLLfKl81FBqJhCu/q1OZew=; b=it8jHl8Aeod0zYq+Skrwrg8GwHh9Iu8Lk4aklL2UU1A7NrkgqGz5TacHTvuZENKCSO zX5vQsxL6WoNuMWNKkEQjxDubFJia3lLQ6vtybpi5bU815x8TqvUIIt9Kr2Uo5cBSRzI 2VZYj93gQX0itc+geQUWbcwpbx7dsR+jspiqHjxUKDMEHdunGEQMz6R4qhshIz6xtcbf Zhwk9IxmoxlDCj68H/K3Yi1WAV8gDwI3vnoSzzJ5OjxNZ+oTEONNaXk9owbEXpdua0Ac Ytg9ljas4ej2TjoNx1nr1x9pd15vss2zsUb9mCqXq0UcPC7FIXHufZoDuL/IWSFTzLDE UAww== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , KVM list , Linux Doc Mailing List , David Airlie , Dave Chinner , Maling list - DRI developers , LKML , Linux MM , Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma , Michael Ellerman , Christoph Hellwig , Vlastimil Babka , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , "Linux-media@vger.kernel.org" , Shuah Khan , John Hubbard , linux-block@vger.kernel.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Al Viro , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , Netdev , Alex Williamson , linux-fsdevel , Andrew Morton , linuxppc-dev , "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191112234250.hId3mW8Sj413XV1ImiQo7mkGJg_3clNQOSdxsGQCkhc@z> T24gVHVlLCBOb3YgMTIsIDIwMTkgYXQgMDI6NDU6NTFQTSAtMDgwMCwgRGFuIFdpbGxpYW1zIHdy b3RlOgo+IE9uIFR1ZSwgTm92IDEyLCAyMDE5IGF0IDI6NDMgUE0gSm9obiBIdWJiYXJkIDxqaHVi YmFyZEBudmlkaWEuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiAxMS8xMi8xOSAxMjo0MyBQTSwgSmFz b24gR3VudGhvcnBlIHdyb3RlOgo+ID4gLi4uCj4gPiA+PiAtICAgICAgICAgICAgfQo+ID4gPj4g KyAgICByZXQgPSBnZXRfdXNlcl9wYWdlc19yZW1vdGUoTlVMTCwgbW0sIHZhZGRyLCAxLCBmbGFn cyB8IEZPTExfTE9OR1RFUk0sCj4gPiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBwYWdlLCB2bWFzLCBOVUxMKTsKPiA+ID4+ICsgICAgLyoKPiA+ID4+ICsgICAgICogVGhlIGxp ZmV0aW1lIG9mIGEgdmFkZHJfZ2V0X3BmbigpIHBhZ2UgcGluIGlzCj4gPiA+PiArICAgICAqIHVz ZXJzcGFjZS1jb250cm9sbGVkLiBJbiB0aGUgZnMtZGF4IGNhc2UgdGhpcyBjb3VsZAo+ID4gPj4g KyAgICAgKiBsZWFkIHRvIGluZGVmaW5pdGUgc3RhbGxzIGluIGZpbGVzeXN0ZW0gb3BlcmF0aW9u cy4KPiA+ID4+ICsgICAgICogRGlzYWxsb3cgYXR0ZW1wdHMgdG8gcGluIGZzLWRheCBwYWdlcyB2 aWEgdGhpcwo+ID4gPj4gKyAgICAgKiBpbnRlcmZhY2UuCj4gPiA+PiArICAgICAqLwo+ID4gPj4g KyAgICBpZiAocmV0ID4gMCAmJiB2bWFfaXNfZnNkYXgodm1hc1swXSkpIHsKPiA+ID4+ICsgICAg ICAgICAgICByZXQgPSAtRU9QTk9UU1VQUDsKPiA+ID4+ICsgICAgICAgICAgICBwdXRfcGFnZShw YWdlWzBdKTsKPiA+ID4+ICAgICAgfQo+ID4gPgo+ID4gPiBBRkFJSyB0aGlzIGNodW5rIGlzIHJl ZHVuZGFudCBub3cgYXMgaXQgaXMgc29tZSBoYWNrIHRvIGVtdWxhdGUKPiA+ID4gRk9MTF9MT05H VEVSTT8gU28gdm1hcyBjYW4gYmUgZGVsZXRlZCB0b28uCj4gPgo+ID4gTGV0IG1lIGZpcnN0IG1h a2Ugc3VyZSBJIHVuZGVyc3RhbmQgd2hhdCBEYW4gaGFzIGluIG1pbmQgZm9yIHRoZSB2bWEKPiA+ IGNoZWNraW5nLCBpbiB0aGUgb3RoZXIgdGhyZWFkLi4uCj4gCj4gSXQncyBub3QgcmVkdW5kYW50 IHJlbGF0aXZlIHRvIHVwc3RyZWFtIHdoaWNoIGRvZXMgbm90IGRvIGFueXRoaW5nIHRoZQo+IEZP TExfTE9OR1RFUk0gaW4gdGhlIGd1cC1zbG93IHBhdGguLi4gYnV0IEkgaGF2ZSBub3QgbG9va2Vk IGF0IHBhdGNoZXMKPiAxLTcgdG8gc2VlIGlmIHNvbWV0aGluZyB0aGVyZSBtYWRlIGl0IHJlZHVu ZGFudC4KCk9oLCB0aGUgaHVuayBKb2huIGhhZCBiZWxvdyBmb3IgZ2V0X3VzZXJfcGFnZXNfcmVt b3RlKCkgYWxzbyBuZWVkcyB0bwpjYWxsIF9fZ3VwX2xvbmd0ZXJtX2xvY2tlZCgpIHdoZW4gRk9M TF9MT05HVEVSTSBpcyBzcGVjaWZpZWQsIHRoZW4KdGhhdCBjYWxscyBjaGVja19kYXhfdm1hcygp IHdoaWNoIGR1cGxpY2F0ZXMgdGhlIHZtYV9pc19mc2RheCgpIGNoZWNrCmFib3ZlLgoKQ2VydGFp bmx5IG5vIGNhbGxlciBvZiBGT0xMX0xPTkdURVJNIHNob3VsZCBoYXZlIHRvIGRvIGRheCBzcGVj aWZpYwpWTUEgY2hlY2tpbmcuCgpKYXNvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWw=