From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Date: Wed, 13 Nov 2019 01:55:56 +0000 Subject: [PATCH AUTOSEL 4.14 089/115] backlight: lm3639: Unconditionally call led_classdev_unregister Message-Id: <20191113015622.11592-89-sashal@kernel.org> List-Id: References: <20191113015622.11592-1-sashal@kernel.org> In-Reply-To: <20191113015622.11592-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sasha Levin , Daniel Thompson , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Lee Jones From: Nathan Chancellor [ Upstream commit 7cea645ae9c5a54aa7904fddb2cdf250acd63a6c ] Clang warns that the address of a pointer will always evaluated as true in a boolean context. drivers/video/backlight/lm3639_bl.c:403:14: warning: address of 'pchip->cdev_torch' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&pchip->cdev_torch) ~~ ~~~~~~~^~~~~~~~~~ drivers/video/backlight/lm3639_bl.c:405:14: warning: address of 'pchip->cdev_flash' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&pchip->cdev_flash) ~~ ~~~~~~~^~~~~~~~~~ 2 warnings generated. These statements have been present since 2012, introduced by commit 0f59858d5119 ("backlight: add new lm3639 backlight driver"). Given that they have been called unconditionally since then presumably without any issues, removing the always true if statements to fix the warnings without any real world changes. Link: https://github.com/ClangBuiltLinux/linux/issues/119 Signed-off-by: Nathan Chancellor Reviewed-by: Daniel Thompson Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/video/backlight/lm3639_bl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c index cd50df5807ead..086611c7bc03c 100644 --- a/drivers/video/backlight/lm3639_bl.c +++ b/drivers/video/backlight/lm3639_bl.c @@ -400,10 +400,8 @@ static int lm3639_remove(struct i2c_client *client) regmap_write(pchip->regmap, REG_ENABLE, 0x00); - if (&pchip->cdev_torch) - led_classdev_unregister(&pchip->cdev_torch); - if (&pchip->cdev_flash) - led_classdev_unregister(&pchip->cdev_flash); + led_classdev_unregister(&pchip->cdev_torch); + led_classdev_unregister(&pchip->cdev_flash); if (pchip->bled) device_remove_file(&(pchip->bled->dev), &dev_attr_bled_mode); return 0; -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH AUTOSEL 4.14 089/115] backlight: lm3639: Unconditionally call led_classdev_unregister Date: Tue, 12 Nov 2019 20:55:56 -0500 Message-ID: <20191113015622.11592-89-sashal@kernel.org> References: <20191113015622.11592-1-sashal@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 196306EC51 for ; Wed, 13 Nov 2019 01:58:52 +0000 (UTC) In-Reply-To: <20191113015622.11592-1-sashal@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sasha Levin , Daniel Thompson , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Lee Jones List-Id: dri-devel@lists.freedesktop.org RnJvbTogTmF0aGFuIENoYW5jZWxsb3IgPG5hdGVjaGFuY2VsbG9yQGdtYWlsLmNvbT4KClsgVXBz dHJlYW0gY29tbWl0IDdjZWE2NDVhZTljNWE1NGFhNzkwNGZkZGIyY2RmMjUwYWNkNjNhNmMgXQoK Q2xhbmcgd2FybnMgdGhhdCB0aGUgYWRkcmVzcyBvZiBhIHBvaW50ZXIgd2lsbCBhbHdheXMgZXZh bHVhdGVkIGFzIHRydWUKaW4gYSBib29sZWFuIGNvbnRleHQuCgpkcml2ZXJzL3ZpZGVvL2JhY2ts aWdodC9sbTM2MzlfYmwuYzo0MDM6MTQ6IHdhcm5pbmc6IGFkZHJlc3Mgb2YKJ3BjaGlwLT5jZGV2 X3RvcmNoJyB3aWxsIGFsd2F5cyBldmFsdWF0ZSB0byAndHJ1ZScKWy1XcG9pbnRlci1ib29sLWNv bnZlcnNpb25dCiAgICAgICAgaWYgKCZwY2hpcC0+Y2Rldl90b3JjaCkKICAgICAgICB+fiAgIH5+ fn5+fn5efn5+fn5+fn5+CmRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xtMzYzOV9ibC5jOjQwNTox NDogd2FybmluZzogYWRkcmVzcyBvZgoncGNoaXAtPmNkZXZfZmxhc2gnIHdpbGwgYWx3YXlzIGV2 YWx1YXRlIHRvICd0cnVlJwpbLVdwb2ludGVyLWJvb2wtY29udmVyc2lvbl0KICAgICAgICBpZiAo JnBjaGlwLT5jZGV2X2ZsYXNoKQogICAgICAgIH5+ICAgfn5+fn5+fl5+fn5+fn5+fn4KMiB3YXJu aW5ncyBnZW5lcmF0ZWQuCgpUaGVzZSBzdGF0ZW1lbnRzIGhhdmUgYmVlbiBwcmVzZW50IHNpbmNl IDIwMTIsIGludHJvZHVjZWQgYnkKY29tbWl0IDBmNTk4NThkNTExOSAoImJhY2tsaWdodDogYWRk IG5ldyBsbTM2MzkgYmFja2xpZ2h0CmRyaXZlciIpLiBHaXZlbiB0aGF0IHRoZXkgaGF2ZSBiZWVu IGNhbGxlZCB1bmNvbmRpdGlvbmFsbHkgc2luY2UKdGhlbiBwcmVzdW1hYmx5IHdpdGhvdXQgYW55 IGlzc3VlcywgcmVtb3ZpbmcgdGhlIGFsd2F5cyB0cnVlIGlmCnN0YXRlbWVudHMgdG8gZml4IHRo ZSB3YXJuaW5ncyB3aXRob3V0IGFueSByZWFsIHdvcmxkIGNoYW5nZXMuCgpMaW5rOiBodHRwczov L2dpdGh1Yi5jb20vQ2xhbmdCdWlsdExpbnV4L2xpbnV4L2lzc3Vlcy8xMTkKU2lnbmVkLW9mZi1i eTogTmF0aGFuIENoYW5jZWxsb3IgPG5hdGVjaGFuY2VsbG9yQGdtYWlsLmNvbT4KUmV2aWV3ZWQt Ynk6IERhbmllbCBUaG9tcHNvbiA8ZGFuaWVsLnRob21wc29uQGxpbmFyby5vcmc+ClNpZ25lZC1v ZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ClNpZ25lZC1vZmYtYnk6IFNh c2hhIExldmluIDxzYXNoYWxAa2VybmVsLm9yZz4KLS0tCiBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdo dC9sbTM2MzlfYmwuYyB8IDYgKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp LCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xt MzYzOV9ibC5jIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG0zNjM5X2JsLmMKaW5kZXggY2Q1 MGRmNTgwN2VhZC4uMDg2NjExYzdiYzAzYyAxMDA2NDQKLS0tIGEvZHJpdmVycy92aWRlby9iYWNr bGlnaHQvbG0zNjM5X2JsLmMKKysrIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG0zNjM5X2Js LmMKQEAgLTQwMCwxMCArNDAwLDggQEAgc3RhdGljIGludCBsbTM2MzlfcmVtb3ZlKHN0cnVjdCBp MmNfY2xpZW50ICpjbGllbnQpCiAKIAlyZWdtYXBfd3JpdGUocGNoaXAtPnJlZ21hcCwgUkVHX0VO QUJMRSwgMHgwMCk7CiAKLQlpZiAoJnBjaGlwLT5jZGV2X3RvcmNoKQotCQlsZWRfY2xhc3NkZXZf dW5yZWdpc3RlcigmcGNoaXAtPmNkZXZfdG9yY2gpOwotCWlmICgmcGNoaXAtPmNkZXZfZmxhc2gp Ci0JCWxlZF9jbGFzc2Rldl91bnJlZ2lzdGVyKCZwY2hpcC0+Y2Rldl9mbGFzaCk7CisJbGVkX2Ns YXNzZGV2X3VucmVnaXN0ZXIoJnBjaGlwLT5jZGV2X3RvcmNoKTsKKwlsZWRfY2xhc3NkZXZfdW5y ZWdpc3RlcigmcGNoaXAtPmNkZXZfZmxhc2gpOwogCWlmIChwY2hpcC0+YmxlZCkKIAkJZGV2aWNl X3JlbW92ZV9maWxlKCYocGNoaXAtPmJsZWQtPmRldiksICZkZXZfYXR0cl9ibGVkX21vZGUpOwog CXJldHVybiAwOwotLSAKMi4yMC4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83417C43331 for ; Wed, 13 Nov 2019 01:58:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 587BC222CF for ; Wed, 13 Nov 2019 01:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573610337; bh=julWjBlCYWiwOVW4slF5Jvmglxdu1fcIEx8uEPF98IM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rMdOCMZrPiUIC6wrDqcrUlNfnOLuGMnMmPT3WgTyQxIewrZKyYKQAqrFtVVAvLgSD n8PqJAHoURy8ZlpZfHwievIPXtM/azrpdTHdA36GUnW4Oeks3AX8MN7hQdNlVzx+aZ GqN5SHSyGoab9IQt3JMtfKZ0XpqNVyaB49awXCi4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730156AbfKMB64 (ORCPT ); Tue, 12 Nov 2019 20:58:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:52914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730137AbfKMB6w (ORCPT ); Tue, 12 Nov 2019 20:58:52 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B77F2053B; Wed, 13 Nov 2019 01:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573610332; bh=julWjBlCYWiwOVW4slF5Jvmglxdu1fcIEx8uEPF98IM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rz85SUw0HPQniBrnhFbttQ8T+VTbWibRrOEH0yo1qL2Dfgg5UpB3r7ujqj2exI5oF 2hUgMuknH6a6VJCALdiLf/+pRjnyfF9VeZwiWsJx6aPl5Jij3sIcHKiMBWaYk4CfYT OXIXrsMc+/HU1vmwDsYO0Zp2Jd3CGqzmI318XL9k= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nathan Chancellor , Daniel Thompson , Lee Jones , Sasha Levin , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH AUTOSEL 4.14 089/115] backlight: lm3639: Unconditionally call led_classdev_unregister Date: Tue, 12 Nov 2019 20:55:56 -0500 Message-Id: <20191113015622.11592-89-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113015622.11592-1-sashal@kernel.org> References: <20191113015622.11592-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor [ Upstream commit 7cea645ae9c5a54aa7904fddb2cdf250acd63a6c ] Clang warns that the address of a pointer will always evaluated as true in a boolean context. drivers/video/backlight/lm3639_bl.c:403:14: warning: address of 'pchip->cdev_torch' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&pchip->cdev_torch) ~~ ~~~~~~~^~~~~~~~~~ drivers/video/backlight/lm3639_bl.c:405:14: warning: address of 'pchip->cdev_flash' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&pchip->cdev_flash) ~~ ~~~~~~~^~~~~~~~~~ 2 warnings generated. These statements have been present since 2012, introduced by commit 0f59858d5119 ("backlight: add new lm3639 backlight driver"). Given that they have been called unconditionally since then presumably without any issues, removing the always true if statements to fix the warnings without any real world changes. Link: https://github.com/ClangBuiltLinux/linux/issues/119 Signed-off-by: Nathan Chancellor Reviewed-by: Daniel Thompson Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/video/backlight/lm3639_bl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c index cd50df5807ead..086611c7bc03c 100644 --- a/drivers/video/backlight/lm3639_bl.c +++ b/drivers/video/backlight/lm3639_bl.c @@ -400,10 +400,8 @@ static int lm3639_remove(struct i2c_client *client) regmap_write(pchip->regmap, REG_ENABLE, 0x00); - if (&pchip->cdev_torch) - led_classdev_unregister(&pchip->cdev_torch); - if (&pchip->cdev_flash) - led_classdev_unregister(&pchip->cdev_flash); + led_classdev_unregister(&pchip->cdev_torch); + led_classdev_unregister(&pchip->cdev_flash); if (pchip->bled) device_remove_file(&(pchip->bled->dev), &dev_attr_bled_mode); return 0; -- 2.20.1