diff for duplicates of <20191113025941.GE26530@ZenIV.linux.org.uk> diff --git a/a/content_digest b/N1/content_digest index 4dbf653..861f75f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -26,7 +26,30 @@ Chanho Min <chanho.min@lge.com> Oleg Nesterov <oleg@redhat.com> Rasmus Villemoes <linux@rasmusvillemoes.dk> - " Alexan\0" + Alexander Shishkin <alexander.shishkin@linux.intel.com> + Jiri Olsa <jolsa@redhat.com> + Namhyung Kim <namhyung@kernel.org> + Christian Brauner <christian@brauner.io> + Aleksa Sarai <asarai@suse.de> + Linus Torvalds <torvalds@linux-foundation.org> + containers@lists.linux-foundation.org + linux-alpha@vger.kernel.org + linux-api@vger.kernel.org + libc-alpha@sourceware.org + linux-arch@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-fsdevel@vger.kernel.org + linux-ia64@vger.kernel.org + linux-kernel@vger.kernel.org + linux-kselftest@vger.kernel.org + linux-m68k@lists.linux-m68k.org + linux-mips@vger.kernel.org + linux-parisc@vger.kernel.org + linuxppc-dev@lists.ozlabs.org + linux-s390@vger.kernel.org + linux-sh@vger.kernel.org + linux-xtensa@linux-xtensa.org + " sparclinux@vger.kernel.org\0" "\00:1\0" "b\0" "On Wed, Nov 13, 2019 at 01:44:14PM +1100, Aleksa Sarai wrote:\n" @@ -67,4 +90,4 @@ "absolute pathname into *s == '/' && !(flags & LOOKUP_IN_ROOT) and be\n" done with that. -fb3febc32b91d205fabc7110552316b0b820fc5515e366ec6a8de3296b69653e +e941a56df9f79c25aa2b6a74275d42879781bca75586eaa8827093c80c3e2d6b
diff --git a/a/1.txt b/N2/1.txt index 7e678b6..14e6e1f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -7,11 +7,11 @@ On Wed, Nov 13, 2019 at 01:44:14PM +1100, Aleksa Sarai wrote: > > > nd->m_seq = read_seqbegin(&mount_lock); > > > > > > - /* Figure out the starting path and root (if needed). */ -> > > - if (*s == '/') { +> > > - if (*s = '/') { > > > + /* Absolute pathname -- fetch the root. */ > > > + if (flags & LOOKUP_IN_ROOT) { > > > + /* With LOOKUP_IN_ROOT, act as a relative path. */ -> > > + while (*s == '/') +> > > + while (*s = '/') > > > + s++; > > > > Er... Why bother skipping slashes? I mean, not only link_path_walk() @@ -33,5 +33,5 @@ in case of that flag very early in the entire thing, so that later the normal logics for absolute/relative would DTRT". Since your check is right next to checking for absolute pathnames (and not in the very beginning of path_init()), we might as well turn the check for -absolute pathname into *s == '/' && !(flags & LOOKUP_IN_ROOT) and be +absolute pathname into *s = '/' && !(flags & LOOKUP_IN_ROOT) and be done with that. diff --git a/a/content_digest b/N2/content_digest index 4dbf653..e3cf094 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -38,11 +38,11 @@ "> > > \tnd->m_seq = read_seqbegin(&mount_lock);\n" "> > > \n" "> > > -\t/* Figure out the starting path and root (if needed). */\n" - "> > > -\tif (*s == '/') {\n" + "> > > -\tif (*s = '/') {\n" "> > > +\t/* Absolute pathname -- fetch the root. */\n" "> > > +\tif (flags & LOOKUP_IN_ROOT) {\n" "> > > +\t\t/* With LOOKUP_IN_ROOT, act as a relative path. */\n" - "> > > +\t\twhile (*s == '/')\n" + "> > > +\t\twhile (*s = '/')\n" "> > > +\t\t\ts++;\n" "> > \n" "> > Er... Why bother skipping slashes? I mean, not only link_path_walk()\n" @@ -64,7 +64,7 @@ "normal logics for absolute/relative would DTRT\". Since your check is\n" "right next to checking for absolute pathnames (and not in the very\n" "beginning of path_init()), we might as well turn the check for\n" - "absolute pathname into *s == '/' && !(flags & LOOKUP_IN_ROOT) and be\n" + "absolute pathname into *s = '/' && !(flags & LOOKUP_IN_ROOT) and be\n" done with that. -fb3febc32b91d205fabc7110552316b0b820fc5515e366ec6a8de3296b69653e +4e3d11965099ed2b49249747d6bfb8acaaec7a5c590f973067f29bc5105fef75
diff --git a/a/content_digest b/N3/content_digest index 4dbf653..ec5a489 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -6,27 +6,50 @@ "Subject\0Re: [PATCH v15 5/9] namei: LOOKUP_IN_ROOT: chroot-like scoped resolution\0" "Date\0Wed, 13 Nov 2019 02:59:41 +0000\0" "To\0Aleksa Sarai <cyphar@cyphar.com>\0" - "Cc\0Jeff Layton <jlayton@kernel.org>" - J. Bruce Fields <bfields@fieldses.org> - Arnd Bergmann <arnd@arndb.de> + "Cc\0linux-ia64@vger.kernel.org" + linux-sh@vger.kernel.org + Peter Zijlstra <peterz@infradead.org> + Rasmus Villemoes <linux@rasmusvillemoes.dk> + Alexei Starovoitov <ast@kernel.org> + linux-kernel@vger.kernel.org David Howells <dhowells@redhat.com> + linux-kselftest@vger.kernel.org + sparclinux@vger.kernel.org + Christian Brauner <christian.brauner@ubuntu.com> + Jiri Olsa <jolsa@redhat.com> + linux-arch@vger.kernel.org + linux-s390@vger.kernel.org + Tycho Andersen <tycho@tycho.ws> + Aleksa Sarai <asarai@suse.de> Shuah Khan <shuah@kernel.org> - Shuah Khan <skhan@linuxfoundation.org> + Alexander Shishkin <alexander.shishkin@linux.intel.com> Ingo Molnar <mingo@redhat.com> - Peter Zijlstra <peterz@infradead.org> - Christian Brauner <christian.brauner@ubuntu.com> - Eric Biederman <ebiederm@xmission.com> - Andy Lutomirski <luto@kernel.org> - Andrew Morton <akpm@linux-foundation.org> - Alexei Starovoitov <ast@kernel.org> + linux-arm-kernel@lists.infradead.org + linux-mips@vger.kernel.org + linux-xtensa@linux-xtensa.org Kees Cook <keescook@chromium.org> + Arnd Bergmann <arnd@arndb.de> Jann Horn <jannh@google.com> - Tycho Andersen <tycho@tycho.ws> + linuxppc-dev@lists.ozlabs.org + linux-m68k@lists.linux-m68k.org + Andy Lutomirski <luto@kernel.org> + Shuah Khan <skhan@linuxfoundation.org> + Namhyung Kim <namhyung@kernel.org> David Drysdale <drysdale@google.com> + Christian Brauner <christian@brauner.io> + J. Bruce Fields <bfields@fieldses.org> + libc-alpha@sourceware.org + linux-parisc@vger.kernel.org + linux-api@vger.kernel.org Chanho Min <chanho.min@lge.com> + Jeff Layton <jlayton@kernel.org> Oleg Nesterov <oleg@redhat.com> - Rasmus Villemoes <linux@rasmusvillemoes.dk> - " Alexan\0" + Eric Biederman <ebiederm@xmission.com> + linux-alpha@vger.kernel.org + linux-fsdevel@vger.kernel.org + Andrew Morton <akpm@linux-foundation.org> + Linus Torvalds <torvalds@linux-foundation.org> + " containers@lists.linux-foundation.org\0" "\00:1\0" "b\0" "On Wed, Nov 13, 2019 at 01:44:14PM +1100, Aleksa Sarai wrote:\n" @@ -67,4 +90,4 @@ "absolute pathname into *s == '/' && !(flags & LOOKUP_IN_ROOT) and be\n" done with that. -fb3febc32b91d205fabc7110552316b0b820fc5515e366ec6a8de3296b69653e +95622e0cda0631c2d8363edef86ba9afd790ef7fc60a7708d48664bae39102ac
diff --git a/a/1.txt b/N4/1.txt index 7e678b6..4045a34 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -35,3 +35,8 @@ right next to checking for absolute pathnames (and not in the very beginning of path_init()), we might as well turn the check for absolute pathname into *s == '/' && !(flags & LOOKUP_IN_ROOT) and be done with that. + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N4/content_digest index 4dbf653..f6e8cb4 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -6,27 +6,50 @@ "Subject\0Re: [PATCH v15 5/9] namei: LOOKUP_IN_ROOT: chroot-like scoped resolution\0" "Date\0Wed, 13 Nov 2019 02:59:41 +0000\0" "To\0Aleksa Sarai <cyphar@cyphar.com>\0" - "Cc\0Jeff Layton <jlayton@kernel.org>" - J. Bruce Fields <bfields@fieldses.org> - Arnd Bergmann <arnd@arndb.de> + "Cc\0linux-ia64@vger.kernel.org" + linux-sh@vger.kernel.org + Peter Zijlstra <peterz@infradead.org> + Rasmus Villemoes <linux@rasmusvillemoes.dk> + Alexei Starovoitov <ast@kernel.org> + linux-kernel@vger.kernel.org David Howells <dhowells@redhat.com> + linux-kselftest@vger.kernel.org + sparclinux@vger.kernel.org + Christian Brauner <christian.brauner@ubuntu.com> + Jiri Olsa <jolsa@redhat.com> + linux-arch@vger.kernel.org + linux-s390@vger.kernel.org + Tycho Andersen <tycho@tycho.ws> + Aleksa Sarai <asarai@suse.de> Shuah Khan <shuah@kernel.org> - Shuah Khan <skhan@linuxfoundation.org> + Alexander Shishkin <alexander.shishkin@linux.intel.com> Ingo Molnar <mingo@redhat.com> - Peter Zijlstra <peterz@infradead.org> - Christian Brauner <christian.brauner@ubuntu.com> - Eric Biederman <ebiederm@xmission.com> - Andy Lutomirski <luto@kernel.org> - Andrew Morton <akpm@linux-foundation.org> - Alexei Starovoitov <ast@kernel.org> + linux-arm-kernel@lists.infradead.org + linux-mips@vger.kernel.org + linux-xtensa@linux-xtensa.org Kees Cook <keescook@chromium.org> + Arnd Bergmann <arnd@arndb.de> Jann Horn <jannh@google.com> - Tycho Andersen <tycho@tycho.ws> + linuxppc-dev@lists.ozlabs.org + linux-m68k@lists.linux-m68k.org + Andy Lutomirski <luto@kernel.org> + Shuah Khan <skhan@linuxfoundation.org> + Namhyung Kim <namhyung@kernel.org> David Drysdale <drysdale@google.com> + Christian Brauner <christian@brauner.io> + J. Bruce Fields <bfields@fieldses.org> + libc-alpha@sourceware.org + linux-parisc@vger.kernel.org + linux-api@vger.kernel.org Chanho Min <chanho.min@lge.com> + Jeff Layton <jlayton@kernel.org> Oleg Nesterov <oleg@redhat.com> - Rasmus Villemoes <linux@rasmusvillemoes.dk> - " Alexan\0" + Eric Biederman <ebiederm@xmission.com> + linux-alpha@vger.kernel.org + linux-fsdevel@vger.kernel.org + Andrew Morton <akpm@linux-foundation.org> + Linus Torvalds <torvalds@linux-foundation.org> + " containers@lists.linux-foundation.org\0" "\00:1\0" "b\0" "On Wed, Nov 13, 2019 at 01:44:14PM +1100, Aleksa Sarai wrote:\n" @@ -65,6 +88,11 @@ "right next to checking for absolute pathnames (and not in the very\n" "beginning of path_init()), we might as well turn the check for\n" "absolute pathname into *s == '/' && !(flags & LOOKUP_IN_ROOT) and be\n" - done with that. + "done with that.\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -fb3febc32b91d205fabc7110552316b0b820fc5515e366ec6a8de3296b69653e +88a358f6974510c7465484045dad33a9c963de8eede2c44365bf0ccd40c5b3d1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.