From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFA2C43331 for ; Wed, 13 Nov 2019 03:53:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68024222CA for ; Wed, 13 Nov 2019 03:53:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="sw9G9qsj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727666AbfKMDxY (ORCPT ); Tue, 12 Nov 2019 22:53:24 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:37402 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726936AbfKMDxY (ORCPT ); Tue, 12 Nov 2019 22:53:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UbomPZ/cdhIHFL3pRSaxl/jnZn5brFylQEK6Jb6pvyw=; b=sw9G9qsjOlpBwKdbOGkjYaz7HX 7f1GNkLEHrW+UDRQbR2wYc+X3SYvk0tqXpikIJs6U+D0G+iT3+WE/8s6QB8Mjd6m7YLqoMNsbLXB9 6AoVqaLO3vdLb5ctdj4b7bvKc7oIV2B+WNM3VLXHM7gXZGlg/L32FXz7a/G25gfaoRso=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iUjib-00054i-I6; Wed, 13 Nov 2019 04:53:21 +0100 Date: Wed, 13 Nov 2019 04:53:21 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: f.fainelli@gmail.com, vivien.didelot@gmail.com, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: sja1105: Print the reset reason Message-ID: <20191113035321.GC16688@lunn.ch> References: <20191112212200.5572-1-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112212200.5572-1-olteanv@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 12, 2019 at 11:22:00PM +0200, Vladimir Oltean wrote: > Sometimes it can be quite opaque even for me why the driver decided to > reset the switch. So instead of adding dump_stack() calls each time for > debugging, just add a reset reason to sja1105_static_config_reload > calls which gets printed to the console. > +int sja1105_static_config_reload(struct sja1105_private *priv, > + enum sja1105_reset_reason reason) > { > struct ptp_system_timestamp ptp_sts_before; > struct ptp_system_timestamp ptp_sts_after; > @@ -1405,6 +1413,10 @@ int sja1105_static_config_reload(struct sja1105_private *priv) > out_unlock_ptp: > mutex_unlock(&priv->ptp_data.lock); > > + dev_info(priv->ds->dev, > + "Reset switch and programmed static config. Reason: %s\n", > + sja1105_reset_reasons[reason]); If this is for debugging, maybe dev_dbg() would be better? Andrew