All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] Virtio pci legacy support
Date: Wed, 13 Nov 2019 13:21:56 +0800	[thread overview]
Message-ID: <20191113052156.GA5892@___> (raw)
In-Reply-To: <20191112092331.1285dda4@shemminger-XPS-13-9360>

On Tue, Nov 12, 2019 at 09:23:31AM -0800, Stephen Hemminger wrote:
> Since Linux kernel is going to drop support for iopl real soon now.
> Is there any ongoing effort to either drop Legacy virtio support, 

I think it's not a good idea to drop the legacy virtio
support at present.

> or replace iopl with ioperm,

+1. This looks like the most straightforward way for now.

> or at least test with iopl failing?

The iopl failing test was just moved to rte_pci_ioport_map()
by below series:

https://patches.dpdk.org/cover/61627/

> 
> Note: it looks like the current code does not match comment.
> 
> /*
>  * Request iopl privilege for all RPL, returns 0 on success
>  * iopl() call is mostly for the i386 architecture. For other architectures,
>  * return -1 to indicate IO privilege can't be changed in this way.
>  */
> int
> rte_eal_iopl_init(void)
> {
> #if defined(RTE_ARCH_X86)
> 	if (iopl(3) != 0)
> 		return -1;
> #endif
> 	return 0;
> }

      reply	other threads:[~2019-11-13  5:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 17:23 [dpdk-dev] Virtio pci legacy support Stephen Hemminger
2019-11-13  5:21 ` Tiwei Bie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113052156.GA5892@___ \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.