Re: [PATCH] xfs: devirtualize ->m_dirnameops

[Christoph Hellwig <hch@lst.de>]

On Tue, Nov 12, 2019 at 08:22:47PM -0800, Darrick J. Wong wrote:
> > @@ -718,7 +718,7 @@ xfs_dir2_block_lookup_int(
> >  		 * and buffer. If it's the first case-insensitive match, store
> >  		 * the index and buffer and continue looking for an exact match.
> >  		 */
> > -		cmp = mp->m_dirnameops->compname(args, dep->name, dep->namelen);
> > +		cmp = xfs_dir2_compname(args, dep->name, dep->namelen);
> 
> gcc complains about the unused @mp variable here.  With that fixed the
> rest looks ok, so:

What gcc version do you use?  I see a consistent pattern lately that
yours (correctly) find initialized but unused variable, but neither my
local one nor the build bot does..