Re: [PATCH net-next v2] net: macb: convert to phylink

[Antoine Tenart <antoine.tenart@bootlin.com>]

Hi David,

On Tue, Nov 12, 2019 at 11:43:57AM -0800, David Miller wrote:
> From: Antoine Tenart <antoine.tenart@bootlin.com>
> Date: Tue, 12 Nov 2019 15:25:48 +0100
> 
> > This patch converts the MACB Ethernet driver to the Phylink framework.
> > The MAC configuration is moved to the Phylink ops and Phylink helpers
> > are now used in the ethtools functions. This helps to access the flow
> > control and pauseparam logic and this will be helpful in the future
> > for boards using this controller with SFP cages.
> > 
> > Tested-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
> 
> Things like pulling out the buffer init code into a helper function are
> separate from the actual phylink conversion, so please split these changes
> out into separate patches and make this a bonafide patch series.
> 
> Please do not forget to provide an appropriate patch series header
> posting when you do this.

Will do for v3.

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com