From: David Teigland <teigland@redhat.com>
To: Heming Zhao <heming.zhao@suse.com>
Cc: "thornber@redhat.com" <thornber@redhat.com>,
"linux-lvm@redhat.com" <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] resend patch - bcache may mistakenly write data to another disk when writes error
Date: Wed, 13 Nov 2019 09:41:26 -0600 [thread overview]
Message-ID: <20191113154126.GA27038@redhat.com> (raw)
In-Reply-To: <667efc9f-1001-37cc-c0af-b352ff366c03@suse.com>
On Wed, Nov 13, 2019 at 02:23:42AM +0000, Heming Zhao wrote:
> label_write // @ lib/label/label.c
> +-> dev_write_bytes //
> | +-> if (!bcache_flush()) //when failed, call below invalidate
> | label_scan_invalidate // will set fd=-1 in _scan_dev_close()
> +-> dev_unset_last_byte // with fd: -1
> +-> bcache_unset_last_byte
> +-> _last_byte_fd != fd(-1), the _last_byte_xx never clean.
> ```
> So all bcache_unset_last_byte which after dev_write_bytes should be modified.
> For detail code fix, please check my V2 patch which I sent on Oct 28th.
Got it, thanks for your work on that, please check I got all the necessary
lines from your patch.
https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=13c254fc05386d05ab6bbda2806f9ca4d3358a0c
> Would you have any plan/schedule to backport bcache bug fixes to stable-2.02 branch?
I'll try to apply them all today.
next prev parent reply other threads:[~2019-11-13 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fc8ca0d7-23d9-8145-05e5-27a7ea2a7682@suse.com>
[not found] ` <872328cd-3d51-97bb-1c50-b54cc194c6f2@suse.com>
2019-11-12 15:21 ` [linux-lvm] resend patch - bcache may mistakenly write data to another disk when writes error David Teigland
[not found] ` <667efc9f-1001-37cc-c0af-b352ff366c03@suse.com>
2019-11-13 15:41 ` David Teigland [this message]
2019-10-22 9:47 Heming Zhao
2019-10-23 21:31 ` Joe Thornber
2019-10-24 3:06 ` Heming Zhao
2019-10-28 15:43 ` Joe Thornber
2019-10-29 5:07 ` Heming Zhao
2019-10-29 9:46 ` Heming Zhao
2019-10-29 11:05 ` Joe Thornber
2019-10-29 11:47 ` Heming Zhao
2019-10-29 14:41 ` Joe Thornber
2019-10-29 11:01 ` Joe Thornber
2019-10-29 11:41 ` Heming Zhao
2019-10-24 3:13 ` Heming Zhao
2019-10-28 8:38 ` Heming Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113154126.GA27038@redhat.com \
--to=teigland@redhat.com \
--cc=heming.zhao@suse.com \
--cc=linux-lvm@redhat.com \
--cc=thornber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.