From: Eric Biggers <ebiggers@kernel.org>
To: David Sterba <dsterba@suse.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 0/7] BLAKE2b cleanups
Date: Wed, 13 Nov 2019 12:51:35 -0800 [thread overview]
Message-ID: <20191113205134.GJ221701@gmail.com> (raw)
In-Reply-To: <cover.1573553665.git.dsterba@suse.com>
On Tue, Nov 12, 2019 at 11:20:23AM +0100, David Sterba wrote:
> Hi,
>
> the patchset implements cleanups suggested by Eric in
> https://lore.kernel.org/linux-crypto/20191025051550.GA103313@sol.localdomain/
>
> The diff is almost the same, split into pieces with some additional
> comments where it would help understand the simplifications. This is
> based on v7 of the BLAKE2b patchset.
>
> The self-tests have been run for each patch on x86_64.
>
> V2:
> - rename digest_setkey to blake2b_setkey, this is in patch 7 that also
> does a rename, to avoid a too-trivial separate patch
> - minor withespace fix in patch 6
>
> David Sterba (7):
> crypto: blake2b: merge _final implementation to callback
> crypto: blake2b: merge blake2 init to api callback
> crypto: blake2b: simplify key init
> crypto: blake2b: delete unused structs or members
> crypto: blake2b: open code set last block helper
> crypto: blake2b: merge _update to api callback
> crypto: blake2b: rename tfm context and _setkey callback
>
> crypto/blake2b_generic.c | 279 ++++++++++++---------------------------
> 1 file changed, 82 insertions(+), 197 deletions(-)
For the series:
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
next prev parent reply other threads:[~2019-11-13 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 10:20 [PATCH v2 0/7] BLAKE2b cleanups David Sterba
2019-11-12 10:20 ` [PATCH v2 1/7] crypto: blake2b: merge _final implementation to callback David Sterba
2019-11-12 10:20 ` [PATCH v2 2/7] crypto: blake2b: merge blake2 init to api callback David Sterba
2019-11-12 10:20 ` [PATCH v2 3/7] crypto: blake2b: simplify key init David Sterba
2019-11-12 10:20 ` [PATCH v2 4/7] crypto: blake2b: delete unused structs or members David Sterba
2019-11-12 10:20 ` [PATCH v2 5/7] crypto: blake2b: open code set last block helper David Sterba
2019-11-12 10:20 ` [PATCH v2 6/7] crypto: blake2b: merge _update to api callback David Sterba
2019-11-12 10:20 ` [PATCH v2 7/7] crypto: blake2b: rename tfm context and _setkey callback David Sterba
2019-11-13 20:51 ` Eric Biggers [this message]
2019-11-22 11:02 ` [PATCH v2 0/7] BLAKE2b cleanups Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113205134.GJ221701@gmail.com \
--to=ebiggers@kernel.org \
--cc=dsterba@suse.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.