Re: [PATCHv5] serial-uartlite: Remove ULITE_NR_PORTS macro

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Nov 13, 2019 at 04:38:46PM +0100, Johan Hovold wrote:
> On Wed, Nov 13, 2019 at 12:00:08PM +0000, shubhrajyoti.datta@gmail.com wrote:
> > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > 
> > This patch is removing ULITE_NR_PORTS macro which limits number of
> > ports which can be used. Every instance is registering own struct
> > uart_driver with minor number which corresponds to alias ID (or 0 now).
> > and with 1 uart port. The same alias ID is saved to
> > tty_driver->name_base which is key field for creating ttyULX name.
> > 
> > Because name_base and minor number are setup already there is no need to
> > setup any port->line number because 0 is the right value.
> > 
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > ---
> > v4: patch addition
> > v5: Merge the patch so that all the patches compile
> 
> Greg, 
> 
> Please do not merge this. This is a hack which really needs to be
> reconsidered as I've pointed before
> 
> 	 https://lkml.kernel.org/r/20190523091839.GC568@localhost
> 
> I suggest you also drop the first two patches that you applied to
> tty-testing earlier today.

Oops, my fault, will go drop all of these, thanks.

> Shubhrajyoti, please keep on CC with these changes. I'll try to review
> this again and get back to you shortly.

I think we should also revert all the previous changes as well, as you
have pointed out.  This driver needs a good overhaul, but not in this
way :(

thanks,

greg k-h