From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA53C432C3 for ; Thu, 14 Nov 2019 06:07:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66769206D6 for ; Thu, 14 Nov 2019 06:07:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="OLJ+O93w"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OVL3/BdK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66769206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47D9xv35vCzF49r for ; Thu, 14 Nov 2019 17:07:47 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kroah.com (client-ip=66.111.4.29; helo=out5-smtp.messagingengine.com; envelope-from=greg@kroah.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kroah.com header.i=@kroah.com header.b="OLJ+O93w"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="OVL3/BdK"; dkim-atps=neutral Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47D9r16bF5zF3bv for ; Thu, 14 Nov 2019 17:02:41 +1100 (AEDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1360C21C39; Thu, 14 Nov 2019 01:02:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 14 Nov 2019 01:02:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=QwzVKI6tbra34TY6z9msluLBFLL DyCMl9KOPaMBmeK8=; b=OLJ+O93w/O7Wp5kWCE+tvkvr2WFCNVT5+nBYEaDSHQ4 /ox/ufRmWDzcrokhj76Wnxwjid/BeRG1XLBGHslRwElaWBsZ/mn6LjoJAQtkml2c SH2sLydouvS5C0HsvbdYeZLkHjTmcFf4a/jt7H2sg9WMZjZEB55gXf/lsyFdJvni Uf4OlfVHuxAKcZdyh9IwS7dIi6z9BHbYJt2cOtsnVBT1atWLSDPNMdHg7sPD989N 82PetVNqe8NNEacSYxXFLN/vFhEb+fQ9udUsolp5pZUACCZjMDgd5yXippMXU3HH zLwf2gKj1oadM22rckdgPvgpXGm9oV5WEB6wUfO2uHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=QwzVKI 6tbra34TY6z9msluLBFLLDyCMl9KOPaMBmeK8=; b=OVL3/BdKpNr5udch4gDTyu 0aIqgJpBFPMfbV++7uwtRL9RyeURuSz8QCv7ZetiHOU8yDDZBfmTm7eHod1rf7cL CXZa+6nTnofYMOgw21ZsNhlT1OFu2LnvYNo++GM/16ngkzXTOv+096ffY3izP0Yj KSwFKjeeT5X7nFHejSJvjrvBPHgkvZ+Ze2pxiz4bbgRRVKBInQ8/u4FCy2STC4/t YfY7xlT3zcCsQQmJ+5rUQA+eVvTuArYu0P1bI7nFSx3XmxOd7F4KceURu3jyDD9k AZlIZfSRmJqUxjsSbubtZRDhewU4az1s4tJQ7HGbea48QHexAFBEBWfx3KA+nXWw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudefvddgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdtredttdervdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeduvdegrddvudelrdefud drleefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhen ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (unknown [124.219.31.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 5772A3060062; Thu, 14 Nov 2019 01:02:38 -0500 (EST) Date: Thu, 14 Nov 2019 14:02:36 +0800 From: Greg KH To: Andrew Donnellan Subject: Re: [PATCH stable 4.4] powerpc/boot: Request no dynamic linker for boot wrapper Message-ID: <20191114060236.GD353293@kroah.com> References: <20191112065941.9548-1-ajd@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112065941.9548-1-ajd@linux.ibm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, stable@vger.kernel.org, Anton Blanchard Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Nov 12, 2019 at 05:59:41PM +1100, Andrew Donnellan wrote: > From: Nicholas Piggin > > Commit ff45000fcb56b5b0f1a14a865d3541746d838a0a upstream. > > The boot wrapper performs its own relocations and does not require > PT_INTERP segment. However currently we don't tell the linker that. > > Prior to binutils 2.28 that works OK. But since binutils commit > 1a9ccd70f9a7 ("Fix the linker so that it will not silently generate ELF > binaries with invalid program headers. Fix readelf to report such > invalid binaries.") binutils tries to create a program header segment > due to PT_INTERP, and the link fails because there is no space for it: > > ld: arch/powerpc/boot/zImage.pseries: Not enough room for program headers, try linking with -N > ld: final link failed: Bad value > > So tell the linker not to do that, by passing --no-dynamic-linker. > > Cc: stable@vger.kernel.org > Reported-by: Anton Blanchard > Signed-off-by: Nicholas Piggin > [mpe: Drop dependency on ld-version.sh and massage change log] > Signed-off-by: Michael Ellerman > [ajd: backport to v4.4 (resolve conflict with a comment line)] > Signed-off-by: Andrew Donnellan > --- > arch/powerpc/boot/wrapper | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) Now queud up, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF314C432C3 for ; Thu, 14 Nov 2019 06:02:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A96E9206B6 for ; Thu, 14 Nov 2019 06:02:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="OLJ+O93w"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OVL3/BdK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbfKNGCk (ORCPT ); Thu, 14 Nov 2019 01:02:40 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:58933 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbfKNGCk (ORCPT ); Thu, 14 Nov 2019 01:02:40 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1360C21C39; Thu, 14 Nov 2019 01:02:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 14 Nov 2019 01:02:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=QwzVKI6tbra34TY6z9msluLBFLL DyCMl9KOPaMBmeK8=; b=OLJ+O93w/O7Wp5kWCE+tvkvr2WFCNVT5+nBYEaDSHQ4 /ox/ufRmWDzcrokhj76Wnxwjid/BeRG1XLBGHslRwElaWBsZ/mn6LjoJAQtkml2c SH2sLydouvS5C0HsvbdYeZLkHjTmcFf4a/jt7H2sg9WMZjZEB55gXf/lsyFdJvni Uf4OlfVHuxAKcZdyh9IwS7dIi6z9BHbYJt2cOtsnVBT1atWLSDPNMdHg7sPD989N 82PetVNqe8NNEacSYxXFLN/vFhEb+fQ9udUsolp5pZUACCZjMDgd5yXippMXU3HH zLwf2gKj1oadM22rckdgPvgpXGm9oV5WEB6wUfO2uHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=QwzVKI 6tbra34TY6z9msluLBFLLDyCMl9KOPaMBmeK8=; b=OVL3/BdKpNr5udch4gDTyu 0aIqgJpBFPMfbV++7uwtRL9RyeURuSz8QCv7ZetiHOU8yDDZBfmTm7eHod1rf7cL CXZa+6nTnofYMOgw21ZsNhlT1OFu2LnvYNo++GM/16ngkzXTOv+096ffY3izP0Yj KSwFKjeeT5X7nFHejSJvjrvBPHgkvZ+Ze2pxiz4bbgRRVKBInQ8/u4FCy2STC4/t YfY7xlT3zcCsQQmJ+5rUQA+eVvTuArYu0P1bI7nFSx3XmxOd7F4KceURu3jyDD9k AZlIZfSRmJqUxjsSbubtZRDhewU4az1s4tJQ7HGbea48QHexAFBEBWfx3KA+nXWw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudefvddgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdtredttdervdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeduvdegrddvudelrdefud drleefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhen ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (unknown [124.219.31.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 5772A3060062; Thu, 14 Nov 2019 01:02:38 -0500 (EST) Date: Thu, 14 Nov 2019 14:02:36 +0800 From: Greg KH To: Andrew Donnellan Cc: stable@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, mpe@ellerman.id.au, Anton Blanchard Subject: Re: [PATCH stable 4.4] powerpc/boot: Request no dynamic linker for boot wrapper Message-ID: <20191114060236.GD353293@kroah.com> References: <20191112065941.9548-1-ajd@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112065941.9548-1-ajd@linux.ibm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Nov 12, 2019 at 05:59:41PM +1100, Andrew Donnellan wrote: > From: Nicholas Piggin > > Commit ff45000fcb56b5b0f1a14a865d3541746d838a0a upstream. > > The boot wrapper performs its own relocations and does not require > PT_INTERP segment. However currently we don't tell the linker that. > > Prior to binutils 2.28 that works OK. But since binutils commit > 1a9ccd70f9a7 ("Fix the linker so that it will not silently generate ELF > binaries with invalid program headers. Fix readelf to report such > invalid binaries.") binutils tries to create a program header segment > due to PT_INTERP, and the link fails because there is no space for it: > > ld: arch/powerpc/boot/zImage.pseries: Not enough room for program headers, try linking with -N > ld: final link failed: Bad value > > So tell the linker not to do that, by passing --no-dynamic-linker. > > Cc: stable@vger.kernel.org > Reported-by: Anton Blanchard > Signed-off-by: Nicholas Piggin > [mpe: Drop dependency on ld-version.sh and massage change log] > Signed-off-by: Michael Ellerman > [ajd: backport to v4.4 (resolve conflict with a comment line)] > Signed-off-by: Andrew Donnellan > --- > arch/powerpc/boot/wrapper | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) Now queud up, thanks. greg k-h