From: Boris Brezillon <boris.brezillon@collabora.com>
To: Przemyslaw Gaj <pgaj@cadence.com>
Cc: linux-i3c@lists.infradead.org, vitor.soares@synopsys.com,
rafalc@cadence.com, agolec@cadence.com, bbrezillon@kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: i3c: Document data hold delay feature
Date: Thu, 14 Nov 2019 10:15:49 +0100 [thread overview]
Message-ID: <20191114101549.0d6d08f3@collabora.com> (raw)
In-Reply-To: <20191114055155.20446-3-pgaj@cadence.com>
On Thu, 14 Nov 2019 06:51:54 +0100
Przemyslaw Gaj <pgaj@cadence.com> wrote:
> Documenting THD_DEL (Data Hold Delay) feature of Cadence I3C
> master controller.
>
> Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com>
> ---
> Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt b/Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt
> index 1cf6182f888c..7d6349354390 100644
> --- a/Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt
> +++ b/Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt
> @@ -21,6 +21,12 @@ Documentation/devicetree/bindings/i3c/i3c.txt for more details):
> - i2c-scl-hz
> - i3c-scl-hz
>
> +Optional properties, Cadence I3C master controller specific:
> +
> +- thd_del: Data Hold Delay. Sets data hold delay (i.e. SDA_OUT data
> + line will change its value with extra delay that specified
> + in this register).
If it's a Cadence specific property, it should be prefixed with 'cdns,':
- cdns,thd-delay
Quick question about this delay, is it related to the IP integration in
a SoC or is it board specific? In former case, I'd recommend attaching
this piece of information to the compatible and have one compatible per
SoC.
> +
> I3C device connected on the bus follow the generic description (see
> Documentation/devicetree/bindings/i3c/i3c.txt for more details).
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-11-14 9:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 5:51 [PATCH 0/3] Add data hold delay support Przemyslaw Gaj
2019-11-14 5:51 ` [PATCH 1/3] i3c: master: add " Przemyslaw Gaj
2019-11-14 13:38 ` Vitor Soares
2019-11-14 5:51 ` [PATCH 2/3] dt-bindings: i3c: Document data hold delay feature Przemyslaw Gaj
2019-11-14 9:15 ` Boris Brezillon [this message]
2019-11-14 9:26 ` Boris Brezillon
2019-11-14 10:54 ` Przemyslaw Gaj
2019-11-14 11:09 ` Boris Brezillon
2019-11-14 11:35 ` Przemyslaw Gaj
2019-11-14 5:51 ` [PATCH 3/3] MAINTAINERS: add myself as maintainer of Cadence I3C master controller driver Przemyslaw Gaj
2019-11-15 5:09 ` Boris Brezillon
2019-11-14 11:58 ` [PATCH 0/3] Add data hold delay support Vitor Soares
2019-11-14 12:48 ` Przemyslaw Gaj
2019-11-14 13:31 ` Vitor Soares
2019-11-14 13:46 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114101549.0d6d08f3@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=agolec@cadence.com \
--cc=bbrezillon@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=pgaj@cadence.com \
--cc=rafalc@cadence.com \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.