From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:53190 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726482AbfKNRMf (ORCPT ); Thu, 14 Nov 2019 12:12:35 -0500 Date: Thu, 14 Nov 2019 18:12:31 +0100 From: Joerg Roedel Subject: Re: [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all() Message-ID: <20191114171231.GA21753@suse.de> References: <20191113095530.228959-1-shile.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113095530.228959-1-shile.zhang@linux.alibaba.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Shile Zhang Cc: Andrew Morton , linux-mm@kvack.org, linux-kbuild@vger.kernel.org On Wed, Nov 13, 2019 at 05:55:30PM +0800, Shile Zhang wrote: > +#if defined(CONFIG_X86_32) && defined(CONFIG_X86_PAE) > /* > * First make sure the mappings are removed from all page-tables > * before they are freed. > + * > + * This is only needed on x86-32 with !SHARED_KERNEL_PMD, which is > + * the case on a PAE kernel with PTI enabled. > */ > - vmalloc_sync_all(); > + if (!SHARED_KERNEL_PMD && boot_cpu_has(X86_FEATURE_PTI)) > + vmalloc_sync_all(); > +#endif I already submitted another fix for this quite some time ago: https://lore.kernel.org/lkml/20191009124418.8286-1-joro@8bytes.org/ Regards, Joerg