From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Ritesh Harjani <riteshh@linux.ibm.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>,
Eric Whitney <enwlinux@gmail.com>
Subject: Re: [PATCH] ext4: deaccount delayed allocations at freeing inode in ext4_evict_inode()
Date: Thu, 14 Nov 2019 19:27:09 -0500 [thread overview]
Message-ID: <20191115002709.GA9640@mit.edu> (raw)
In-Reply-To: <20191108115420.GI20863@quack2.suse.cz>
> From ee27836b579d3bf750d45cd7081d3433ea6fedd5 Mon Sep 17 00:00:00 2001
> From: Jan Kara <jack@suse.cz>
> Date: Fri, 8 Nov 2019 12:45:11 +0100
> Subject: [PATCH] ext4: Fix leak of quota reservations
>
> Commit 8fcc3a580651 ("ext4: rework reserved cluster accounting when
> invalidating pages") moved freeing of delayed allocation reservations
> from dirty page invalidation time to time when we evict corresponding
> status extent from extent status tree. For inodes which don't have any
> blocks allocated this may actually happen only in ext4_clear_blocks()
> which is after we've dropped references to quota structures from the
> inode. Thus reservation of quota leaked. Fix the problem by clearing
> quota information from the inode only after evicting extent status tree
> in ext4_clear_inode().
>
> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: 8fcc3a580651 ("ext4: rework reserved cluster accounting when invalidating pages")
> Signed-off-by: Jan Kara <jack@suse.cz>
OK, I've applied this patch.
- Ted
prev parent reply other threads:[~2019-11-15 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 7:17 [PATCH] ext4: deaccount delayed allocations at freeing inode in ext4_evict_inode() Konstantin Khlebnikov
2019-10-29 7:20 ` Konstantin Khlebnikov
2019-11-07 17:58 ` Konstantin Khlebnikov
2019-11-08 2:08 ` Ritesh Harjani
2019-11-08 8:30 ` Konstantin Khlebnikov
2019-11-08 11:54 ` Jan Kara
2019-11-15 0:27 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115002709.GA9640@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=enwlinux@gmail.com \
--cc=jack@suse.cz \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.