From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH] staging: rtl*: Remove tasklet callback casts
Date: Fri, 15 Nov 2019 08:49:24 -0800 [thread overview]
Message-ID: <201911150848.4518DFCA1@keescook> (raw)
In-Reply-To: <20191115061610.GA1034830@kroah.com>
On Fri, Nov 15, 2019 at 02:16:10PM +0800, Greg Kroah-Hartman wrote:
> On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote:
> > In order to make the entire kernel usable under Clang's Control Flow
> > Integrity protections, function prototype casts need to be avoided
> > because this will trip CFI checks at runtime (i.e. a mismatch between
> > the caller's expected function prototype and the destination function's
> > prototype). Many of these cases can be found with -Wcast-function-type,
> > which found that the rtl wifi drivers had a bunch of needless function
> > casts. Remove function casts for tasklet callbacks in the various drivers.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
> > drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 3 +--
> > drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 3 +--
> > drivers/staging/rtl8188eu/include/rtl8188e_recv.h | 2 +-
> > drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 2 +-
> > drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 4 ++--
> > drivers/staging/rtl8192e/rtllib_softmac.c | 7 +++----
> > .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +++----
> > drivers/staging/rtl8192u/r8192U_core.c | 8 ++++----
> > drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
> > drivers/staging/rtl8712/rtl871x_xmit.c | 5 ++---
> > drivers/staging/rtl8712/rtl871x_xmit.h | 2 +-
> > drivers/staging/rtl8712/usb_ops_linux.c | 4 ++--
> > drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 11 ++++-------
> > 13 files changed, 30 insertions(+), 39 deletions(-)
>
> This fails to apply to my staging-next branch of staging.git. Can you
> rebase and resend?
Ah, hrm, sorry. I think I was based on Linus's master. I will adjust!
--
Kees Cook
next prev parent reply other threads:[~2019-11-15 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 5:39 [PATCH] staging: rtl*: Remove tasklet callback casts Kees Cook
2019-11-15 6:16 ` Greg Kroah-Hartman
2019-11-15 16:49 ` Kees Cook [this message]
2019-11-15 7:40 ` Dan Carpenter
2019-11-15 7:42 ` Dan Carpenter
2019-11-15 16:48 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911150848.4518DFCA1@keescook \
--to=keescook@chromium.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.