From: "Liang, Ma" <liang.j.ma@intel.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: david.hunt@intel.com, dev@dpdk.org, alan.carew@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled
Date: Fri, 15 Nov 2019 12:23:22 +0000 [thread overview]
Message-ID: <20191115122321.GA1082@sivswdev09.ir.intel.com> (raw)
In-Reply-To: <20191114141036.31317-1-mattias.ronnblom@ericsson.com>
Hi Mattias,
On 14 Nov 15:10, Mattias Rönnblom wrote:
> Calling pstate's or acpi's rte_power_freq_up() when on the highest
> non-turbo frequency results in an error, if turbo is disabled. The
> error is in the form of a return code and a RTE_LOG() entry on the ERR
> level.
>
> According to the API documentation, the frequency is scaled up
> "according to the available frequencies". In case turbo is disabled,
> that frequency is not available. This patch's rte_power_freq_up()
> behaviour is also consistent with how rte_power_freq_max() is
> implemented (i.e. the highest non-turbo frequency is set, in case
> turbo is disabled).
>
> Fixes: 445c6528b55f ("power: common interface for guest and host")
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> ---
Thanks for your patches. I reviewed it and I'm OK with that changes.
Reviewed-by: Liang Ma <liang.j.ma@intel.com>
prev parent reply other threads:[~2019-11-15 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 14:10 [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled Mattias Rönnblom
2019-11-14 16:23 ` Hunt, David
2019-11-20 23:53 ` Thomas Monjalon
2019-11-15 12:23 ` Liang, Ma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115122321.GA1082@sivswdev09.ir.intel.com \
--to=liang.j.ma@intel.com \
--cc=alan.carew@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.