From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iVb8c-0000DX-1x for mharc-grub-devel@gnu.org; Fri, 15 Nov 2019 07:55:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47633) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVb8Y-0000AB-UK for grub-devel@gnu.org; Fri, 15 Nov 2019 07:55:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVb8X-0003qd-NV for grub-devel@gnu.org; Fri, 15 Nov 2019 07:55:42 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:35573) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iVb8X-0003pe-2R for grub-devel@gnu.org; Fri, 15 Nov 2019 07:55:41 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0B4BE589; Fri, 15 Nov 2019 07:55:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 15 Nov 2019 07:55:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=hUCIiaUBV/C61xgfqIj3HomJtfW g7Ya/gyHDOwWDXsI=; b=EMKlD+9buw4LXYe3njg2PRN618dcUCDXCN6QuHjnheD aerByzl08cUhfKGCjxoofv1WOHXgNNC+LxkY5anmTU6q045NAizVRhXW/HXhzFix hQTHfTWqwPlavKQDrVoG+MykHKQnKhnTd9u9KCKYhqxnqgXSCbXQikJW9GUe0zFl DZl8ZPjxh92aLIBiiakgUBJfDtq2Zs/KJbw1xKiKdBVUaXO9vMnAVAS1eyXWwrWS B0lGu30tyfUkyYZ8r+LcjmHqgXoKNnUFCRU9th+l7E4aAUUsEj4s8tHtlOeyG2Wr o9we3V5L8sl/tQFtQPCra7e15XZVEiEtcTuj9kxb14A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hUCIia UBV/C61xgfqIj3HomJtfWg7Ya/gyHDOwWDXsI=; b=kmhhsXC2LvCkdsoj5d++oC sZmQea58xhrdDseqOpO2GNb6UqQwpe5PsQjQlPYcd8sbdNZMNMndK/QvZ/PWdBRe FGSayEzif9Z6CyVUy7F0hPrl2yqekjNXiAyZMvNTPrkw+o5AsvdiT0+P0ZYd1seq xu+wZJIIos1QV2HejdIQbHAG6lOA/G05zWNedV/5T7FvLr9GwEV3BZm3qWYhbEPQ XFCl7FnCOG4kvgitHcDflB2Dwox/zxq5vwqPhOtF552qNq+sk2NmHD4vWN3LYoV1 FBqnU1gwGBqQ+xkeEH30iC0PqGnZPjjF0TFo5R37igyMVABDpttXtZRWflicHaDQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudefhedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucffohhmrghinhepth gvgihirdhishenucfkphepkeelrddugedrvdefiedrvddtieenucfrrghrrghmpehmrghi lhhfrhhomhepphhssehpkhhsrdhimhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from NSJAIL (x590eecce.dyn.telefonica.de [89.14.236.206]) by mail.messagingengine.com (Postfix) with ESMTPA id A2FDC80064; Fri, 15 Nov 2019 07:55:37 -0500 (EST) Received: from localhost ( [10.192.0.11]) by NSJAIL (OpenSMTPD) with ESMTPSA id 445c1f94 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 15 Nov 2019 12:55:36 +0000 (UTC) Date: Fri, 15 Nov 2019 13:55:38 +0100 From: Patrick Steinhardt To: Daniel Kiper Cc: grub-devel@gnu.org, Max Tottenham Subject: Re: [PATCH v3 6/6] disk: Implement support for LUKS2 Message-ID: <20191115125538.GB2733@ncase> References: <9d88fcbab11f94f04365e3636b1002542a55cb99.1573651222.git.ps@pks.im> <20191115123100.dihbfkafa2qxkyfu@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3uo+9/B/ebqu+fSQ" Content-Disposition: inline In-Reply-To: <20191115123100.dihbfkafa2qxkyfu@tomti.i.net-space.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.21 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Nov 2019 12:55:44 -0000 --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 15, 2019 at 01:31:00PM +0100, Daniel Kiper wrote: > On Wed, Nov 13, 2019 at 02:22:38PM +0100, Patrick Steinhardt wrote: [snip] > > + /* Merge the decrypted key material to get the candidate master key.= */ > > + gcry_err =3D AF_merge (hash, split_key, out_key, k->key_size, k->af.= stripes); > > + if (gcry_err) > > + { > > + err =3D grub_crypto_gcry_error (gcry_err); > > + goto err; > > + } > > + > > + grub_dprintf ("luks2", "Candidate key recovered\n"); > > + > > +err: >=20 > One space before label please. Out of sheer curiosity: I didn't see this leading space anywhere else and didn't see it described in grub-dev.texi. Is this documented somewhere? Patrick --3uo+9/B/ebqu+fSQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl3OoEoACgkQEXxntp6r 8SxjZQ/+LThJrHsT45IrE0nm3ISvYcRGosq2RgXhEbIl7U9kguQiEZ9pafSVU1SL rwMaNqHYVQT9bTnlcZ1msk/u0LCdO6Omt/v2FzJXabDHzzov30LyPY9i1km6eyTS VHyGBwTIl0I7P2JcNsTmBcdtN4vfkp0KBDG82Q1UxhAHAF9xzok+UdhVAvDT9oCC SAgOdlnwF1s3KZGAY4j73oE3hdjLG8FuMkkSyOpfbWnihyeglDngYfysonRUfB/G Tx9SEabaiCr4ppfWOEDLxmcjnr5t6ymE8oDw829vWGvuCaPy1Lw9KKpm0dfyzrDr iuYtW4B2D6szS2xygFIc4fXW3Jb25s8SluiTMXsh4xMQMEmHgf7qHHIE85odiV5d e/anEA7kE+wEt5yRXNJb1SFzV1Z/OKwr4EPlzVVrlZIuZtbSnOOBFE34W6lFuRqb Ds8IVG/kPTFY2k3hIPY6v5pK3X2vBArFjsbK3M3S8vxG5SVwmp91fZI3o+o9iJsl lubu/l/6jLHDMvXueuxYyksL2Gmr+8RXcl4ohtco7uth77Y55u0NBGdki021/tqo v92+3F6i4b4YGwK2TcO+zip7TUz+9nTI+zg/vRMcQ5b1HnMhK2X5Dmqnwyvt0Bu0 c9l0GBWpnmX+7e0KggwvEyeiNhE8Fp6v6cattkUPkG0rCDQBGtE= =SZ1T -----END PGP SIGNATURE----- --3uo+9/B/ebqu+fSQ--