From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Taniya Das <tdas@codeaurora.org>
Cc: David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v1 7/7] clk: qcom: Add video clock controller driver for SC7180
Date: Fri, 15 Nov 2019 21:51:17 -0800 [thread overview]
Message-ID: <20191116055118.2FCD120729@mail.kernel.org> (raw)
In-Reply-To: <80e79595-0672-1d16-f251-717dbe449c57@codeaurora.org>
Quoting Taniya Das (2019-11-15 00:11:31)
> Hi Stephen,
>
> Thanks for the review.
>
> On 11/6/2019 6:09 AM, Stephen Boyd wrote:
> > Quoting Taniya Das (2019-10-31 05:21:13)
> >> diff --git a/drivers/clk/qcom/videocc-sc7180.c b/drivers/clk/qcom/videocc-sc7180.c
> >> new file mode 100644
> >> index 0000000..bef034b
> >> --- /dev/null
> >> +++ b/drivers/clk/qcom/videocc-sc7180.c
> >> @@ -0,0 +1,263 @@
> >
> >> + video_pll0_config.alpha = 0x4000;
> >> + video_pll0_config.user_ctl_val = 0x00000001;
> >> + video_pll0_config.user_ctl_hi_val = 0x00004805;
> >
> > Same question, why on stack?
> >
>
> Will update the same.
Sounds like nothing to do.
>
> >> +
> >> + clk_fabia_pll_configure(&video_pll0, regmap, &video_pll0_config);
> >> +
> >> + /* video_cc_xo_clk */
> >
> > What are we doing? Enabling it?
> >
>
> yes, enabling it. Did not model and mark it CRITICAL.
Ok. Please describe that in the comment.
> >> +}
> >> +module_exit(video_cc_sc7180_exit);
> >
> > Same question, module platform driver perhaps?
> >
>
> I will move it to subsys_initcall().
>
Hmm ok.
prev parent reply other threads:[~2019-11-16 5:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 12:21 [PATCH v1 0/7] Add GPU & Video Clock controller driver for SC7180 Taniya Das
2019-10-31 12:21 ` [PATCH v1 1/7] clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration Taniya Das
2019-11-06 0:36 ` Stephen Boyd
2019-11-15 8:11 ` Taniya Das
2019-11-07 4:24 ` Doug Anderson
2019-11-15 8:11 ` Taniya Das
2019-10-31 12:21 ` [PATCH v1 2/7] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings Taniya Das
2019-11-06 0:26 ` Stephen Boyd
2019-11-06 3:18 ` Rob Herring
2019-10-31 12:21 ` [PATCH v1 3/7] dt-bindings: clock: Introduce QCOM Graphics " Taniya Das
2019-11-06 3:59 ` Rob Herring
2019-10-31 12:21 ` [PATCH v1 4/7] clk: qcom: Add graphics clock controller driver for SC7180 Taniya Das
2019-11-06 0:30 ` Stephen Boyd
2019-11-15 8:11 ` Taniya Das
2019-11-16 5:50 ` Stephen Boyd
2019-10-31 12:21 ` [PATCH v1 5/7] dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings Taniya Das
2019-11-06 4:00 ` Rob Herring
2019-10-31 12:21 ` [PATCH v1 6/7] dt-bindings: clock: Introduce QCOM Video " Taniya Das
2019-11-06 0:37 ` Stephen Boyd
2019-10-31 12:21 ` [PATCH v1 7/7] clk: qcom: Add video clock controller driver for SC7180 Taniya Das
2019-11-06 0:39 ` Stephen Boyd
2019-11-15 8:11 ` Taniya Das
2019-11-16 5:51 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191116055118.2FCD120729@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.