Re: [PATCH 1/3] iio: adc: ltc2496: provide device tree binding document

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 12 Nov 2019 11:56:52 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Tue, 2019-11-12 at 08:04 +0100, Uwe Kleine-König wrote:
> > [External]
> > 
> > Hello Alexandru,
> > 
> > On Tue, Nov 12, 2019 at 06:57:49AM +0000, Ardelean, Alexandru wrote:  
> > > On Mon, 2019-11-11 at 22:40 +0100, Uwe Kleine-König wrote:  
> > > > The ADC only requires the standard stuff for spi devices and a
> > > > reference
> > > > voltage.  
> > > 
> > > DT bindings must be in YAML format.  
> > 
> > Yeah, I noticed this trend. But given that I only saw .txt files for
> > iio, I thought I'd stick to that.
> >   
> > > But in this case, you can probably extend the existing
> > > "Documentation/devicetree/bindings/iio/adc/ltc2497.txt".  
> > 
> > I considered that shortly, but as the ltc2497 is an i2c device and the
> > ltc2496 uses spi I chose to create another simple document instead of
> > complicating the existing one by describing two nearly orthogonal sets
> > of properties.  
> 
> There are dt-bindings that cover both SPI & I2C.
> I think ADXL372 does that too.
True, but in that case no real choice as the same part does both
bus types.  Here it's probably cleaner to just have a second document.

Thanks,

Jonathan

> 
> 
> > 
> > Best regards
> > Uwe
> >