From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C7D0C432C0 for ; Sun, 17 Nov 2019 11:02:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2FE0206D6 for ; Sun, 17 Nov 2019 11:02:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zx9e/HXZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2FE0206D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xYcBQHYEqWPuRMmc8r6GgKjKW1Pma9BoHAEK5v1Obrc=; b=Zx9e/HXZRfnfoY 5eh2iNIYo1AlZzn4JBWc18mOeWJr7X9Ztz6gFDXIyh2i/3cvqs3M/H3X8iowCki4sEGBaB8Dug9kA wnvJUJ9p2rUnU4nDshDnVxbHYNqIqiqiRI4WKRvRnDTexTkYt/jK+UDmeHMJ1YHVbyMCV9L4xVLb0 FzuOI1XRo6NrMXTwOBOYFepl82IQprLVufXDN+9V1NJlBGZtm2XOMSxXj8e5EdEUK2LwtqSSP2Gr3 vcFwVPkREyEUpBz3yP16uUrHlB5if9xpk9gDcg32VRr7ZbAMoypBQxGp63VQ8kBx4TpSGR6PvTI8s A74nrhFP8VQg7YOMw7gA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWIK1-0006o4-6v; Sun, 17 Nov 2019 11:02:25 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWIJx-0006nh-IW; Sun, 17 Nov 2019 11:02:22 +0000 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iWIJs-0002Zx-8i; Sun, 17 Nov 2019 12:02:16 +0100 Date: Sun, 17 Nov 2019 11:02:14 +0000 From: Marc Zyngier To: Andreas =?UTF-8?Q?F=C3=A4rber?= Subject: Re: [PATCH v3 8/8] ARM: realtek: Enable RTD1195 arch timer Message-ID: <20191117110214.6b160b2e@why> In-Reply-To: <20191117072109.20402-9-afaerber@suse.de> References: <20191117072109.20402-1-afaerber@suse.de> <20191117072109.20402-9-afaerber@suse.de> Organization: Approximate X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: afaerber@suse.de, linux-realtek-soc@lists.infradead.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191117_030221_756962_27353100 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAxNyBOb3YgMjAxOSAwODoyMTowOSArMDEwMApBbmRyZWFzIEbDpHJiZXIgPGFmYWVy YmVyQHN1c2UuZGU+IHdyb3RlOgoKPiBXaXRob3V0IHRoaXMgbWFnaWMgd3JpdGUgdGhlIHRpbWVy IGRvZXNuJ3Qgd29yayBhbmQgYm9vdCBnZXRzIHN0dWNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFu ZHJlYXMgRsOkcmJlciA8YWZhZXJiZXJAc3VzZS5kZT4KPiAtLS0KPiAgV2hhdCBpcyB0aGUgbmFt ZSBvZiB0aGUgcmVnaXN0ZXIgMHhmZjAxODAwMD8KPiAgSXMgMHgxIGEgQklUKDApIHdyaXRlLCBv ciBob3cgYXJlIHRoZSByZWdpc3RlciBiaXRzIGRlZmluZWQ/Cj4gIElzIHRoaXMgYSByZXNldCBv ciBhIGNsb2NrIGdhdGU/IEhvdyBzaG91bGQgd2UgbW9kZWwgaXQgaW4gRFQ/Cj4gIAo+ICB2MiAt PiB2MzogVW5jaGFuZ2VkCj4gIAo+ICB2MjogTmV3Cj4gIAo+ICBhcmNoL2FybS9tYWNoLXJlYWx0 ZWsvcnRkMTE5NS5jIHwgMTYgKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTYg aW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9tYWNoLXJlYWx0ZWsvcnRk MTE5NS5jIGIvYXJjaC9hcm0vbWFjaC1yZWFsdGVrL3J0ZDExOTUuYwo+IGluZGV4IGIzMWE0MDY2 YmU4Ny4uMDUzMjM3OWM3NGY1IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL21hY2gtcmVhbHRlay9y dGQxMTk1LmMKPiArKysgYi9hcmNoL2FybS9tYWNoLXJlYWx0ZWsvcnRkMTE5NS5jCj4gQEAgLTUs NiArNSw5IEBACj4gICAqIENvcHlyaWdodCAoYykgMjAxNy0yMDE5IEFuZHJlYXMgRsOkcmJlcgo+ ICAgKi8KPiAgCj4gKyNpbmNsdWRlIDxsaW51eC9jbGstcHJvdmlkZXIuaD4KPiArI2luY2x1ZGUg PGxpbnV4L2Nsb2Nrc291cmNlLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9pby5oPgo+ICAjaW5jbHVk ZSA8bGludXgvbWVtYmxvY2suaD4KPiAgI2luY2x1ZGUgPGFzbS9tYWNoL2FyY2guaD4KPiAgCj4g QEAgLTI0LDYgKzI3LDE4IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBydGQxMTk1X3Jlc2VydmUodm9p ZCkKPiAgCXJ0ZDExOTVfbWVtYmxvY2tfcmVtb3ZlKDB4MTgxMDAwMDAsIDB4MDEwMDAwMDApOwo+ ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBfX2luaXQgcnRkMTE5NV9pbml0X3RpbWUodm9pZCkKPiAr ewo+ICsJdm9pZCBfX2lvbWVtICpiYXNlOwo+ICsKPiArCWJhc2UgPSBpb3JlbWFwKDB4ZmYwMTgw MDAsIDQpOwo+ICsJd3JpdGVsKDB4MSwgYmFzZSk7Cj4gKwlpb3VubWFwKGJhc2UpOwo+ICsKPiAr CW9mX2Nsa19pbml0KE5VTEwpOwo+ICsJdGltZXJfcHJvYmUoKTsKPiArfQoKR2F3ZC4uLiBXaHkg aXNuJ3QgdGhpcyBzZXQgZnJvbSB0aGUgYm9vdGxvYWRlcj8gQnkgdGhlIHRpbWUgdGhlIGtlcm5l bApzdGFydHMsIGV2ZXJ5dGhpbmcgc2hvdWxkIGJlIHVwIGFuZCBydW5uaW5nLiBXaGF0IGlzIGl0 IGdvaW5nIHRvIGRvCndoZW4geW91IGtleGVjPyBTaG91bGRuJ3QgdGhpcyBiZSBhIHJlYWQvbW9k aWZ5L3dyaXRlIHNlcXVlbmNlPwoKCU0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNt ZWxscyBmdW5ueS4uLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D151FC432C0 for ; Sun, 17 Nov 2019 11:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C03E206D6 for ; Sun, 17 Nov 2019 11:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573988540; bh=LPcvXNw1mLuXrOg82i2tbZ63dHq4jTPmRO2gOYtV0Tc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=1yL8LPPBJEIJQ62mFALT94tpBBgzDB2We3d2/CYp1UFZ37qAPyS8wMJ8l660H5k+o qo/lwLHl+c//Px7tc+uldn9+Lxthu53LK7kyN0ju646JZlEsU84deVhPyWLeg8qo4r AGHMYjpr+zMoa+P9YHAX1xsXRLOECxGcXaF9A4/I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbfKQLCT convert rfc822-to-8bit (ORCPT ); Sun, 17 Nov 2019 06:02:19 -0500 Received: from inca-roads.misterjones.org ([213.251.177.50]:54195 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbfKQLCT (ORCPT ); Sun, 17 Nov 2019 06:02:19 -0500 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iWIJs-0002Zx-8i; Sun, 17 Nov 2019 12:02:16 +0100 Date: Sun, 17 Nov 2019 11:02:14 +0000 From: Marc Zyngier To: Andreas =?UTF-8?Q?F=C3=A4rber?= Cc: linux-realtek-soc@lists.infradead.org, Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 8/8] ARM: realtek: Enable RTD1195 arch timer Message-ID: <20191117110214.6b160b2e@why> In-Reply-To: <20191117072109.20402-9-afaerber@suse.de> References: <20191117072109.20402-1-afaerber@suse.de> <20191117072109.20402-9-afaerber@suse.de> Organization: Approximate X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: afaerber@suse.de, linux-realtek-soc@lists.infradead.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 17 Nov 2019 08:21:09 +0100 Andreas Färber wrote: > Without this magic write the timer doesn't work and boot gets stuck. > > Signed-off-by: Andreas Färber > --- > What is the name of the register 0xff018000? > Is 0x1 a BIT(0) write, or how are the register bits defined? > Is this a reset or a clock gate? How should we model it in DT? > > v2 -> v3: Unchanged > > v2: New > > arch/arm/mach-realtek/rtd1195.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/mach-realtek/rtd1195.c b/arch/arm/mach-realtek/rtd1195.c > index b31a4066be87..0532379c74f5 100644 > --- a/arch/arm/mach-realtek/rtd1195.c > +++ b/arch/arm/mach-realtek/rtd1195.c > @@ -5,6 +5,9 @@ > * Copyright (c) 2017-2019 Andreas Färber > */ > > +#include > +#include > +#include > #include > #include > > @@ -24,6 +27,18 @@ static void __init rtd1195_reserve(void) > rtd1195_memblock_remove(0x18100000, 0x01000000); > } > > +static void __init rtd1195_init_time(void) > +{ > + void __iomem *base; > + > + base = ioremap(0xff018000, 4); > + writel(0x1, base); > + iounmap(base); > + > + of_clk_init(NULL); > + timer_probe(); > +} Gawd... Why isn't this set from the bootloader? By the time the kernel starts, everything should be up and running. What is it going to do when you kexec? Shouldn't this be a read/modify/write sequence? M. -- Jazz is not dead. It just smells funny...