From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MIME_BASE64_TEXT,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B31C432C3 for ; Mon, 18 Nov 2019 05:47:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77A1420722 for ; Mon, 18 Nov 2019 05:47:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="HUV8LWcE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726140AbfKRFre (ORCPT ); Mon, 18 Nov 2019 00:47:34 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:61530 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725816AbfKRFre (ORCPT ); Mon, 18 Nov 2019 00:47:34 -0500 X-UUID: ee90d34a165a443a8d730f19011d0a9d-20191118 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=NlWDv9SeYsgi2iRUgyMRzJCtwYNFcrKvnRskCn7RxFw=; b=HUV8LWcEufP3lgh09H4dCiX+4K0hRxp3bJ/Dw+nSRccYU0KBjKIfvG+vtmWYU+rR+gCIuiz4wIugjDYN/USwG55arzRspi98G27k3+dGN/JS647FsfQ0TpQomdBMSgbHx6JYapYWPcr1PTwRztB++WgARTUhlr9bMzijZ5sIeAM=; X-UUID: ee90d34a165a443a8d730f19011d0a9d-20191118 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 667588555; Mon, 18 Nov 2019 13:47:30 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 18 Nov 2019 13:47:24 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 18 Nov 2019 13:47:37 +0800 From: Miles Chen To: Dmitry Torokhov CC: , , , , Miles Chen Subject: [PATCH] Input: evdev - convert kzalloc()/vzalloc() to kvzalloc() Date: Mon, 18 Nov 2019 13:47:27 +0800 Message-ID: <20191118054727.31045-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org V2Ugb2JzZXJ2ZWQgYSBsYXJnZShvcmRlci0zKSBhbGxvY2F0aW9uIGluIGV2ZGV2X29wZW4oKSBh bmQgaXQgbWF5DQpjYXVzZSBhbiBPT00ga2VucmVsIHBhbmljIGluIGt6YWxsb2MoKSwgYmVmb3Jl IHdlIGdldHRpbmcgdG8gdGhlDQp2emFsbG9jKCkgZmFsbGJhY2suDQoNCkZpeCBpdCBieSBjb252 ZXJ0aW5nIGt6YWxsb2MoKS92emFsbG9jKCkgdG8ga3Z6YWxsb2MoKSB0byBhdm9pZCB0aGUNCk9P TSBraWxsZXIgbG9naWMgYXMgd2UgaGF2ZSBhIHZtYWxsb2MgZmFsbGJhY2suDQoNCklucHV0UmVh ZGVyIGludm9rZWQgb29tLWtpbGxlcjogZ2ZwX21hc2s9MHgyNDBjMmMwDQooR0ZQX0tFUk5FTHxf X0dGUF9OT1dBUk58X19HRlBfQ09NUHxfX0dGUF9aRVJPKSwgbm9kZW1hc2s9MCwgb3JkZXI9MywN Cm9vbV9zY29yZV9hZGo9LTkwMA0KLi4uDQooZHVtcF9iYWNrdHJhY2UpIGZyb20gKHNob3dfc3Rh Y2srMHgxOC8weDFjKQ0KKHNob3dfc3RhY2spIGZyb20gKGR1bXBfc3RhY2srMHg5NC8weGE4KQ0K KGR1bXBfc3RhY2spIGZyb20gKGR1bXBfaGVhZGVyKzB4N2MvMHhlNCkNCihkdW1wX2hlYWRlcikg ZnJvbSAob3V0X29mX21lbW9yeSsweDMzNC8weDM0OCkNCihvdXRfb2ZfbWVtb3J5KSBmcm9tIChf X2FsbG9jX3BhZ2VzX25vZGVtYXNrKzB4ZTljLzB4ZWI4KQ0KKF9fYWxsb2NfcGFnZXNfbm9kZW1h c2spIGZyb20gKGttYWxsb2Nfb3JkZXJfdHJhY2UrMHgzNC8weDEyOCkNCihrbWFsbG9jX29yZGVy X3RyYWNlKSBmcm9tIChfX2ttYWxsb2MrMHgyNTgvMHgzNmMpDQooX19rbWFsbG9jKSBmcm9tIChl dmRldl9vcGVuKzB4NWMvMHgxN2MpDQooZXZkZXZfb3BlbikgZnJvbSAoY2hyZGV2X29wZW4rMHgx MDAvMHgyMDQpDQooY2hyZGV2X29wZW4pIGZyb20gKGRvX2RlbnRyeV9vcGVuKzB4MjFjLzB4MzU0 KQ0KKGRvX2RlbnRyeV9vcGVuKSBmcm9tICh2ZnNfb3BlbisweDU4LzB4ODQpDQoodmZzX29wZW4p IGZyb20gKHBhdGhfb3BlbmF0KzB4NjQwLzB4Yzk4KQ0KKHBhdGhfb3BlbmF0KSBmcm9tIChkb19m aWxwX29wZW4rMHg3OC8weDExYykNCihkb19maWxwX29wZW4pIGZyb20gKGRvX3N5c19vcGVuKzB4 MTMwLzB4MjQ0KQ0KKGRvX3N5c19vcGVuKSBmcm9tIChTeVNfb3BlbmF0KzB4MTQvMHgxOCkNCihT eVNfb3BlbmF0KSBmcm9tIChfX3N5c190cmFjZV9yZXR1cm4rMHgwLzB4MTApDQouLi4NCk5vcm1h bDogMTI0ODgqNGtCIChVTUVIKSA2OTg0KjhrQiAoVU1FSCkgMjEwMSoxNmtCIChVTUVIKSAwKjMy a0INCjAqNjRrQiAwKjEyOGtCIDAqMjU2a0IgMCo1MTJrQiAwKjEwMjRrQiAwKjIwNDhrQiAwKjQw OTZrQiA9IDEzOTQ0MGtCDQpIaWdoTWVtOiAyMDYqNGtCIChIKSAxMzEqOGtCIChIKSA0MioxNmtC IChIKSAyKjMya0IgKEgpIDAqNjRrQg0KMCoxMjhrQiAwKjI1NmtCIDAqNTEya0IgMCoxMDI0a0Ig MCoyMDQ4a0IgMCo0MDk2a0IgPSAyNjA4a0INCi4uLg0KS2VybmVsIHBhbmljIC0gbm90IHN5bmNp bmc6IE91dCBvZiBtZW1vcnkgYW5kIG5vIGtpbGxhYmxlIHByb2Nlc3Nlcy4uLg0KDQpTaWduZWQt b2ZmLWJ5OiBNaWxlcyBDaGVuIDxtaWxlcy5jaGVuQG1lZGlhdGVrLmNvbT4NCi0tLQ0KIGRyaXZl cnMvaW5wdXQvZXZkZXYuYyB8IDUgKy0tLS0NCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDQgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2lucHV0L2V2ZGV2LmMg Yi9kcml2ZXJzL2lucHV0L2V2ZGV2LmMNCmluZGV4IGQ3ZGQ2ZmNmMmRiMC4uY2Y1ZDdkNjNmZDQ4 IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbnB1dC9ldmRldi5jDQorKysgYi9kcml2ZXJzL2lucHV0 L2V2ZGV2LmMNCkBAIC00ODQsMTAgKzQ4NCw3IEBAIHN0YXRpYyBpbnQgZXZkZXZfb3BlbihzdHJ1 Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3QgZmlsZSAqZmlsZSkNCiAJc3RydWN0IGV2ZGV2X2NsaWVu dCAqY2xpZW50Ow0KIAlpbnQgZXJyb3I7DQogDQotCWNsaWVudCA9IGt6YWxsb2Moc3RydWN0X3Np emUoY2xpZW50LCBidWZmZXIsIGJ1ZnNpemUpLA0KLQkJCSBHRlBfS0VSTkVMIHwgX19HRlBfTk9X QVJOKTsNCi0JaWYgKCFjbGllbnQpDQotCQljbGllbnQgPSB2emFsbG9jKHN0cnVjdF9zaXplKGNs aWVudCwgYnVmZmVyLCBidWZzaXplKSk7DQorCWNsaWVudCA9IGt2emFsbG9jKHN0cnVjdF9zaXpl KGNsaWVudCwgYnVmZmVyLCBidWZzaXplKSwgR0ZQX0tFUk5FTCk7DQogCWlmICghY2xpZW50KQ0K IAkJcmV0dXJuIC1FTk9NRU07DQogDQotLSANCjIuMTguMA0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CB2C432C0 for ; Mon, 18 Nov 2019 05:47:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D157820722 for ; Mon, 18 Nov 2019 05:47:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c+cRpwuN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="HUV8LWcE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D157820722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=d69AfcXoiyU3ZU6VKRof0Aljl0f6nXasKetl7GqaL2M=; b=c+cRpwuNEQ460C 5W6M34DIJAqTUn6ySBV6+yHwo9mQCsWc3tck0qO/QVnfifSW9UOz779v0LPx4ahaSZllASn7KZObA jVjVyhi4QRnOM7zrx+0wHO6hOZLlASH8X1+z+xTW7K9hpQ+MQ8xBZMeCdpjqWi44t3H6r61+wYcD0 ezMh8PRGLu1eUL+dkIkgZNusJk2eXFxk2JqnTNa7qdBDubFYx4rXMq0di9apTHKQRfbHPU1GDLLod Xky/KyCjgG7LuPIos8f/mFUoGViGrzOm9tjMyfOipNk86A65GcRGh00Tip7ztroDElXjnDrjf5HeO Z1ZKuBb/C9An3KsRVftg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWZsw-0007v6-4Z; Mon, 18 Nov 2019 05:47:38 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWZsu-0007th-3q for linux-mediatek@lists.infradead.org; Mon, 18 Nov 2019 05:47:37 +0000 X-UUID: 7dfb54345832421e883878f4e902ac6c-20191117 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=NlWDv9SeYsgi2iRUgyMRzJCtwYNFcrKvnRskCn7RxFw=; b=HUV8LWcEufP3lgh09H4dCiX+4K0hRxp3bJ/Dw+nSRccYU0KBjKIfvG+vtmWYU+rR+gCIuiz4wIugjDYN/USwG55arzRspi98G27k3+dGN/JS647FsfQ0TpQomdBMSgbHx6JYapYWPcr1PTwRztB++WgARTUhlr9bMzijZ5sIeAM=; X-UUID: 7dfb54345832421e883878f4e902ac6c-20191117 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1325576084; Sun, 17 Nov 2019 21:47:32 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 17 Nov 2019 21:47:43 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 18 Nov 2019 13:47:24 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 18 Nov 2019 13:47:37 +0800 From: Miles Chen To: Dmitry Torokhov Subject: [PATCH] Input: evdev - convert kzalloc()/vzalloc() to kvzalloc() Date: Mon, 18 Nov 2019 13:47:27 +0800 Message-ID: <20191118054727.31045-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191117_214736_166127_D7384938 X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miles Chen , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com, linux-input@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org We observed a large(order-3) allocation in evdev_open() and it may cause an OOM kenrel panic in kzalloc(), before we getting to the vzalloc() fallback. Fix it by converting kzalloc()/vzalloc() to kvzalloc() to avoid the OOM killer logic as we have a vmalloc fallback. InputReader invoked oom-killer: gfp_mask=0x240c2c0 (GFP_KERNEL|__GFP_NOWARN|__GFP_COMP|__GFP_ZERO), nodemask=0, order=3, oom_score_adj=-900 ... (dump_backtrace) from (show_stack+0x18/0x1c) (show_stack) from (dump_stack+0x94/0xa8) (dump_stack) from (dump_header+0x7c/0xe4) (dump_header) from (out_of_memory+0x334/0x348) (out_of_memory) from (__alloc_pages_nodemask+0xe9c/0xeb8) (__alloc_pages_nodemask) from (kmalloc_order_trace+0x34/0x128) (kmalloc_order_trace) from (__kmalloc+0x258/0x36c) (__kmalloc) from (evdev_open+0x5c/0x17c) (evdev_open) from (chrdev_open+0x100/0x204) (chrdev_open) from (do_dentry_open+0x21c/0x354) (do_dentry_open) from (vfs_open+0x58/0x84) (vfs_open) from (path_openat+0x640/0xc98) (path_openat) from (do_filp_open+0x78/0x11c) (do_filp_open) from (do_sys_open+0x130/0x244) (do_sys_open) from (SyS_openat+0x14/0x18) (SyS_openat) from (__sys_trace_return+0x0/0x10) ... Normal: 12488*4kB (UMEH) 6984*8kB (UMEH) 2101*16kB (UMEH) 0*32kB 0*64kB 0*128kB 0*256kB 0*512kB 0*1024kB 0*2048kB 0*4096kB = 139440kB HighMem: 206*4kB (H) 131*8kB (H) 42*16kB (H) 2*32kB (H) 0*64kB 0*128kB 0*256kB 0*512kB 0*1024kB 0*2048kB 0*4096kB = 2608kB ... Kernel panic - not syncing: Out of memory and no killable processes... Signed-off-by: Miles Chen --- drivers/input/evdev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index d7dd6fcf2db0..cf5d7d63fd48 100644 --- a/drivers/input/evdev.c +++ b/drivers/input/evdev.c @@ -484,10 +484,7 @@ static int evdev_open(struct inode *inode, struct file *file) struct evdev_client *client; int error; - client = kzalloc(struct_size(client, buffer, bufsize), - GFP_KERNEL | __GFP_NOWARN); - if (!client) - client = vzalloc(struct_size(client, buffer, bufsize)); + client = kvzalloc(struct_size(client, buffer, bufsize), GFP_KERNEL); if (!client) return -ENOMEM; -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek