All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: patrick.rudolph@9elements.com
Cc: linux-kernel@vger.kernel.org, coreboot@coreboot.org,
	Alexios Zavras <alexios.zavras@intel.com>,
	Allison Randal <allison@lohutok.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Arthur Heymans <arthur@aheymans.xyz>
Subject: Re: [Patch v2 1/3] firmware: google: Release devices before unregistering the bus
Date: Mon, 18 Nov 2019 09:59:33 +0100	[thread overview]
Message-ID: <20191118085933.GA150384@kroah.com> (raw)
In-Reply-To: <20191118083903.19311-1-patrick.rudolph@9elements.com>

On Mon, Nov 18, 2019 at 09:38:58AM +0100, patrick.rudolph@9elements.com wrote:
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> 
> Fix a bug where the kernel module can't be loaded after it has been
> unloaded as the devices are still present and conflicting with the
> to be created coreboot devices.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
>  drivers/firmware/google/coreboot_table.c | 7 +++++++
>  1 file changed, 7 insertions(+)

You forgot to document what changed from v1 of this patch and/or series
somewhere :(

Usually it just goes below the --- line on each patch.

Can you fix that up and send a v3 of this series?

thanks

greg k-h

      parent reply	other threads:[~2019-11-18  8:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18  8:38 [Patch v2 1/3] firmware: google: Release devices before unregistering the bus patrick.rudolph
2019-11-18  8:38 ` [Patch v2 2/3] firmware: google: Unregister driver_info on failure and exit in gsmi patrick.rudolph
2019-11-18  8:39 ` [Patch v2 3/3] firmware: google: Probe for a GSMI handler in firmware patrick.rudolph
2019-11-18  8:59 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191118085933.GA150384@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexios.zavras@intel.com \
    --cc=allison@lohutok.net \
    --cc=arthur@aheymans.xyz \
    --cc=coreboot@coreboot.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick.rudolph@9elements.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.