From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Mon, 18 Nov 2019 18:02:22 +0000 Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-Id: <20191118180222.GC5984@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> In-Reply-To: <20191116000139.GB18146@mit.edu> To: "Theodore Y. Ts'o" , g@linux.intel.com Cc: Eric Biggers , linux-fscrypt@vger.kernel.org, Jaegeuk Kim , Paul Crowley , Paul Lawrence , keyrings@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, David Howells , Ondrej Mosnacek , Ondrej Kozina On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > I'm working on an xfstest for this: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id$ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > are any issues from that, I'll hear about it. > > > > Cool. Can you combine this patch and matching test (once it is done) to > > a patch set? > > That's generally not done since the test goes to a different repo > (xfstests.git) which has a different review process from the kernel > change. OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That is why I'm looking into setting up test environment so that I can review these patches with a sane judgement. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6FD1C43215 for ; Mon, 18 Nov 2019 18:02:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A359D21844 for ; Mon, 18 Nov 2019 18:02:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726475AbfKRSCe (ORCPT ); Mon, 18 Nov 2019 13:02:34 -0500 Received: from mga18.intel.com ([134.134.136.126]:41416 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbfKRSCe (ORCPT ); Mon, 18 Nov 2019 13:02:34 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 10:02:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,321,1569308400"; d="scan'208";a="380733937" Received: from cooperwu-mobl.gar.corp.intel.com (HELO localhost) ([10.252.3.195]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 10:02:23 -0800 Date: Mon, 18 Nov 2019 20:02:22 +0200 From: Jarkko Sakkinen To: "Theodore Y. Ts'o" , g@linux.intel.com Cc: Eric Biggers , linux-fscrypt@vger.kernel.org, Jaegeuk Kim , Paul Crowley , Paul Lawrence , keyrings@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, David Howells , Ondrej Mosnacek , Ondrej Kozina Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-ID: <20191118180222.GC5984@linux.intel.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191116000139.GB18146@mit.edu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > I'm working on an xfstest for this: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > are any issues from that, I'll hear about it. > > > > Cool. Can you combine this patch and matching test (once it is done) to > > a patch set? > > That's generally not done since the test goes to a different repo > (xfstests.git) which has a different review process from the kernel > change. OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That is why I'm looking into setting up test environment so that I can review these patches with a sane judgement. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F46C432C0 for ; Mon, 18 Nov 2019 18:02:51 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 715DB217F9; Mon, 18 Nov 2019 18:02:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="IPcAz5g/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="DFd6ZwZo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 715DB217F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iWlMR-0008VT-1R; Mon, 18 Nov 2019 18:02:51 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iWlMP-0008VL-KM for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Nov 2019 18:02:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3TPllAOv4Lo4S7bZQWHqmlat5e2VChoiW+6NC8u6fOo=; b=IPcAz5g/S0hnxcjDY5v+4IcwOo RKV9PjoMfMOJVTzdyculj0HxpniTXtkZYZCBBVs2csF99N2g0yW+WKhZ+lDM7qBBDKe/QWFvFRwMa kEH3bm3NNPMPI4K09zf+yWbH4cPUZpEUEp54uCnr1YbWNOen0uy+E9Nyg0b5EK08GBj4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3TPllAOv4Lo4S7bZQWHqmlat5e2VChoiW+6NC8u6fOo=; b=DFd6ZwZohyIGfdnVPJOd+NpoVN Kt1XiWLuGewoL9SOCuHFRUpKcMS6HDEV6U2EBm7aa65Qs+QcMGZPglniNeiQ6VrObgoS8y7boC+g4 I9KxszAW2maz7WvpXOPAIpTuDFNuuFue0oUnc7nN4Rp76gubW8WFq6lthkpCDnUNVOXs=; Received: from mga07.intel.com ([134.134.136.100]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iWlMO-0053SW-39 for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Nov 2019 18:02:49 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 10:02:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,321,1569308400"; d="scan'208";a="380733937" Received: from cooperwu-mobl.gar.corp.intel.com (HELO localhost) ([10.252.3.195]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 10:02:23 -0800 Date: Mon, 18 Nov 2019 20:02:22 +0200 From: Jarkko Sakkinen To: "Theodore Y. Ts'o" , g@linux.intel.com Message-ID: <20191118180222.GC5984@linux.intel.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191116000139.GB18146@mit.edu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1iWlMO-0053SW-39 Subject: Re: [f2fs-dev] [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Lawrence , David Howells , Ondrej Mosnacek , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, Ondrej Kozina , Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > I'm working on an xfstest for this: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > are any issues from that, I'll hear about it. > > > > Cool. Can you combine this patch and matching test (once it is done) to > > a patch set? > > That's generally not done since the test goes to a different repo > (xfstests.git) which has a different review process from the kernel > change. OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That is why I'm looking into setting up test environment so that I can review these patches with a sane judgement. /Jarkko _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0EFC432C0 for ; Mon, 18 Nov 2019 18:02:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 828FF217F9 for ; Mon, 18 Nov 2019 18:02:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dWeAPQIm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 828FF217F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kdyzL+c2cM/D6kJ40zEprmgMlT1h9Hn3rLn14+56Hw8=; b=dWeAPQImp0gf9x uIlZg8vK5Bx89ZTv0nM/E/5Qw3C65NLEOsm1CqwMwuKqKMCi0rD9NJpYjLcjq+NLe9kAAipl+izLt VSUKJJlojcJ2gG8JvOrg0p09ZpO7k5lmFO4pIn6z4c82MYTu2O5RFewh5+4IjwogpiMVEnYLr2y2t 1nXqq3VBZPnorCdk5V2ZQbR+6gzsSu8hVpzNC6zNGpPKWUpE2tnXzAHySbkc3cAReb76OL3oGwtdE W8fgZxrdKkpIkS6BTPudUNzX5su1NQLxHckNjh1TK23cGSFz/aFmZ2tH27Vcv/m9+Naf7mA+Lw02d sbG8yYRpbseDVvnQa7Xw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWlM7-0008PK-Bt; Mon, 18 Nov 2019 18:02:31 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWlM4-0008Ok-DM for linux-mtd@lists.infradead.org; Mon, 18 Nov 2019 18:02:29 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 10:02:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,321,1569308400"; d="scan'208";a="380733937" Received: from cooperwu-mobl.gar.corp.intel.com (HELO localhost) ([10.252.3.195]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 10:02:23 -0800 Date: Mon, 18 Nov 2019 20:02:22 +0200 From: Jarkko Sakkinen To: "Theodore Y. Ts'o" , g@linux.intel.com Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-ID: <20191118180222.GC5984@linux.intel.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191116000139.GB18146@mit.edu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191118_100228_462061_E5907A16 X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Lawrence , David Howells , Ondrej Mosnacek , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, Ondrej Kozina , Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > I'm working on an xfstest for this: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > are any issues from that, I'll hear about it. > > > > Cool. Can you combine this patch and matching test (once it is done) to > > a patch set? > > That's generally not done since the test goes to a different repo > (xfstests.git) which has a different review process from the kernel > change. OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That is why I'm looking into setting up test environment so that I can review these patches with a sane judgement. /Jarkko ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/