From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Mon, 18 Nov 2019 18:05:16 +0000 Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-Id: <20191118180516.GD5984@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> <20191118180222.GC5984@linux.intel.com> In-Reply-To: <20191118180222.GC5984@linux.intel.com> To: "Theodore Y. Ts'o" , g@linux.intel.com Cc: Eric Biggers , linux-fscrypt@vger.kernel.org, Jaegeuk Kim , Paul Crowley , Paul Lawrence , keyrings@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, David Howells , Ondrej Mosnacek , Ondrej Kozina On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > I'm working on an xfstest for this: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id$ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > are any issues from that, I'll hear about it. > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > a patch set? > > > > That's generally not done since the test goes to a different repo > > (xfstests.git) which has a different review process from the kernel > > change. > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > is why I'm looking into setting up test environment so that I can review > these patches with a sane judgement. And also since I've just barely started to help David on co-maintaining keyring it is better to put extra emphasis on testing even for the most trivial patches. That is fastest way to learn different interactions. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6683C43215 for ; Mon, 18 Nov 2019 18:05:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC1B42195D for ; Mon, 18 Nov 2019 18:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726336AbfKRSF3 (ORCPT ); Mon, 18 Nov 2019 13:05:29 -0500 Received: from mga01.intel.com ([192.55.52.88]:26231 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbfKRSF3 (ORCPT ); Mon, 18 Nov 2019 13:05:29 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 10:05:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,321,1569308400"; d="scan'208";a="380734916" Received: from cooperwu-mobl.gar.corp.intel.com (HELO localhost) ([10.252.3.195]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 10:05:18 -0800 Date: Mon, 18 Nov 2019 20:05:16 +0200 From: Jarkko Sakkinen To: "Theodore Y. Ts'o" , g@linux.intel.com Cc: Eric Biggers , linux-fscrypt@vger.kernel.org, Jaegeuk Kim , Paul Crowley , Paul Lawrence , keyrings@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, David Howells , Ondrej Mosnacek , Ondrej Kozina Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-ID: <20191118180516.GD5984@linux.intel.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> <20191118180222.GC5984@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191118180222.GC5984@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > I'm working on an xfstest for this: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > are any issues from that, I'll hear about it. > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > a patch set? > > > > That's generally not done since the test goes to a different repo > > (xfstests.git) which has a different review process from the kernel > > change. > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > is why I'm looking into setting up test environment so that I can review > these patches with a sane judgement. And also since I've just barely started to help David on co-maintaining keyring it is better to put extra emphasis on testing even for the most trivial patches. That is fastest way to learn different interactions. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56757C432C0 for ; Mon, 18 Nov 2019 18:05:38 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2008D218AF; Mon, 18 Nov 2019 18:05:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="FPHzIBUB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="O2JBtmGP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2008D218AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iWlP7-0004nn-KA; Mon, 18 Nov 2019 18:05:37 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iWlP6-0004nG-AM for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Nov 2019 18:05:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IuWW1XzOXy8qpBJZO+mVLfA6oK8fpL7AEmxWeFeoKLk=; b=FPHzIBUBXwHMnsgVUr9WY53935 29rLL9GiBx70SHAxt1H0ZjYjpnBFFg3akYsk0rjLXb1KVUeb+/omLh8SgW8PAivK/CPFsyMWgGaSY tE0N1y/qiWYvfe72wwfbCF0MTWjvgsOwPym3bzh88zW0VcZSmr69HsuBQhRVfzEYsU8k=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IuWW1XzOXy8qpBJZO+mVLfA6oK8fpL7AEmxWeFeoKLk=; b=O2JBtmGPAWfQRArls/TptHVlP7 WJMxRUAfsW833qmoV3OkZRGSyn5CvYLPwSd2WHwDI6OwPvEykPF59nJMo4fhpPW82byvlHSe7s4al rzbrNoziGew+6Sw/xTK3b2x+cD9kkmjtg/IPFvQFCbohxBCZkDbpwG1sf+Kq8/JTEbPo=; Received: from mga07.intel.com ([134.134.136.100]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iWlP1-0053gv-Bc for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Nov 2019 18:05:36 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 10:05:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,321,1569308400"; d="scan'208";a="380734916" Received: from cooperwu-mobl.gar.corp.intel.com (HELO localhost) ([10.252.3.195]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 10:05:18 -0800 Date: Mon, 18 Nov 2019 20:05:16 +0200 From: Jarkko Sakkinen To: "Theodore Y. Ts'o" , g@linux.intel.com Message-ID: <20191118180516.GD5984@linux.intel.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> <20191118180222.GC5984@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191118180222.GC5984@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1iWlP1-0053gv-Bc Subject: Re: [f2fs-dev] [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Lawrence , David Howells , Ondrej Mosnacek , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, Ondrej Kozina , Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > I'm working on an xfstest for this: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > are any issues from that, I'll hear about it. > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > a patch set? > > > > That's generally not done since the test goes to a different repo > > (xfstests.git) which has a different review process from the kernel > > change. > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > is why I'm looking into setting up test environment so that I can review > these patches with a sane judgement. And also since I've just barely started to help David on co-maintaining keyring it is better to put extra emphasis on testing even for the most trivial patches. That is fastest way to learn different interactions. /Jarkko _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC98C432C0 for ; Mon, 18 Nov 2019 18:05:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08CA6218AF for ; Mon, 18 Nov 2019 18:05:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q8h7A4QS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08CA6218AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tRxcbKA/8XJQTy3wrELU+T39V167ZKJZCGNvdPdwQ0o=; b=Q8h7A4QSmtU/4U MyeYvSV+QvGKgbIQCvvEgopnv33wMRAXZuP0mWbzYEcv9FKF8TWO5n2JNx+xNFpu88A2Tzi8qcu71 XHb05eJBOA6BgCCx2FaXiUzfb6bIumS7WQSwQ16QEDgfRfpyq739KAXmReQi2wEVOqYRFjCLPecLM hTIZNGHTp2BgDqqpV7pTsCuQp3d7olAXgAEBWYCbAHvzJKsKjQZ1eA1LyD5rypIXVYedkIHxITA26 neVIiD9ZWCfsEmSTCG8hMPGl6nqlVDNeyqSE+FqHtkFJMtFNhJ+f5q1Gt1pTYOuVq5PZUwr6vrnu5 W4gFp7FB3FsczFtibgwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWlOz-0001sY-VR; Mon, 18 Nov 2019 18:05:29 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWlOx-0001s6-Dl for linux-mtd@lists.infradead.org; Mon, 18 Nov 2019 18:05:28 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 10:05:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,321,1569308400"; d="scan'208";a="380734916" Received: from cooperwu-mobl.gar.corp.intel.com (HELO localhost) ([10.252.3.195]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 10:05:18 -0800 Date: Mon, 18 Nov 2019 20:05:16 +0200 From: Jarkko Sakkinen To: "Theodore Y. Ts'o" , g@linux.intel.com Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-ID: <20191118180516.GD5984@linux.intel.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> <20191118180222.GC5984@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191118180222.GC5984@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191118_100527_474520_0F67C797 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Lawrence , David Howells , Ondrej Mosnacek , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, Ondrej Kozina , Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > I'm working on an xfstest for this: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > are any issues from that, I'll hear about it. > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > a patch set? > > > > That's generally not done since the test goes to a different repo > > (xfstests.git) which has a different review process from the kernel > > change. > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > is why I'm looking into setting up test environment so that I can review > these patches with a sane judgement. And also since I've just barely started to help David on co-maintaining keyring it is better to put extra emphasis on testing even for the most trivial patches. That is fastest way to learn different interactions. /Jarkko ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/