From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Biggers Date: Mon, 18 Nov 2019 18:27:53 +0000 Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-Id: <20191118182752.GB184560@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> <20191118180222.GC5984@linux.intel.com> <20191118180516.GD5984@linux.intel.com> In-Reply-To: <20191118180516.GD5984@linux.intel.com> To: Jarkko Sakkinen Cc: "Theodore Y. Ts'o" , g@linux.intel.com, linux-fscrypt@vger.kernel.org, Jaegeuk Kim , Paul Crowley , Paul Lawrence , keyrings@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, David Howells , Ondrej Mosnacek , Ondrej Kozina On Mon, Nov 18, 2019 at 08:05:16PM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > > I'm working on an xfstest for this: > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id$ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > > are any issues from that, I'll hear about it. > > > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > > a patch set? > > > > > > That's generally not done since the test goes to a different repo > > > (xfstests.git) which has a different review process from the kernel > > > change. > > > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > > is why I'm looking into setting up test environment so that I can review > > these patches with a sane judgement. > > And also since I've just barely started to help David on co-maintaining > keyring it is better to put extra emphasis on testing even for the most > trivial patches. That is fastest way to learn different interactions. > I gave some tips about kvm-xfstests in my other reply: https://lkml.kernel.org/linux-fscrypt/20191118181359.GA184560@gmail.com/ However, please note that xfstests is really about filesystem testing (including fscrypt), not about testing the keyrings subsystem itself. So while you're certainly welcome to run the fscrypt tests, for most patches you'll encounter as a keyrings maintainer the keyutils testsuite will be more useful. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A310C43141 for ; Mon, 18 Nov 2019 18:27:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 565DD222C1 for ; Mon, 18 Nov 2019 18:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574101677; bh=hgVt0ngLY4LQROiy5izRjuCjb237dxfSwA55PVeCtzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Q9+VH2LklA91k0LheEjeJ2uQceVwYNJOvEbBe5bIYC2zCEsNvEmFK36gmWEAEL9dJ cmnjbjAFYKwKH0RxIEjIM6YMbIMKfCcKW9xSkBjtAqgWlcOA3bJM3VAR+xheI3GsYw jUQaLOXFGqqMG3gMAu2N/Wn395ZByz0YuvQNaeTg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfKRS14 (ORCPT ); Mon, 18 Nov 2019 13:27:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:60694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726322AbfKRS14 (ORCPT ); Mon, 18 Nov 2019 13:27:56 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 523B1222BF; Mon, 18 Nov 2019 18:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574101675; bh=hgVt0ngLY4LQROiy5izRjuCjb237dxfSwA55PVeCtzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l114SmjFfMiCK5ArBiu50w/LTL4XSqt3bVoIVKzINA/oG9Eh2EGM4xiS+QA/Fgv+J mNypcXQpHUUYB5tY0Rr45k0ckpA44+9bEcKlJjm9DuvrhibzFR2abrr8mhumozpFnk s8EdB/fhR/Pqz8BjKwXm8lcS9QbxbklPvJUw0TD0= Date: Mon, 18 Nov 2019 10:27:53 -0800 From: Eric Biggers To: Jarkko Sakkinen Cc: "Theodore Y. Ts'o" , g@linux.intel.com, linux-fscrypt@vger.kernel.org, Jaegeuk Kim , Paul Crowley , Paul Lawrence , keyrings@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, David Howells , Ondrej Mosnacek , Ondrej Kozina Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-ID: <20191118182752.GB184560@gmail.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> <20191118180222.GC5984@linux.intel.com> <20191118180516.GD5984@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191118180516.GD5984@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 18, 2019 at 08:05:16PM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > > I'm working on an xfstest for this: > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > > are any issues from that, I'll hear about it. > > > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > > a patch set? > > > > > > That's generally not done since the test goes to a different repo > > > (xfstests.git) which has a different review process from the kernel > > > change. > > > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > > is why I'm looking into setting up test environment so that I can review > > these patches with a sane judgement. > > And also since I've just barely started to help David on co-maintaining > keyring it is better to put extra emphasis on testing even for the most > trivial patches. That is fastest way to learn different interactions. > I gave some tips about kvm-xfstests in my other reply: https://lkml.kernel.org/linux-fscrypt/20191118181359.GA184560@gmail.com/ However, please note that xfstests is really about filesystem testing (including fscrypt), not about testing the keyrings subsystem itself. So while you're certainly welcome to run the fscrypt tests, for most patches you'll encounter as a keyrings maintainer the keyutils testsuite will be more useful. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96503C432C0 for ; Mon, 18 Nov 2019 18:28:05 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 652CC222BF; Mon, 18 Nov 2019 18:28:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="YPC5xzgq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="bS3LKQYx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l114SmjF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 652CC222BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iWlkq-0005q0-6H; Mon, 18 Nov 2019 18:28:04 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iWlko-0005pt-WC for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Nov 2019 18:28:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bUpaLYWVHmiJTRumraMgioOdCTazzqmZRsbYpWT6fbs=; b=YPC5xzgqu8As3nzblcSshtyK0C tvJ31/+prFZqj9xOAKIzKvue2myBHukcIhrsaUkOlfY+1KZlwA3ODX59xF9wug1tj2W2JnFA3cDO2 17K8ciz02scK0UfetEoUc/F+mLlDCcrz6kc2h96eJPvBqTUMbYwYhCvLD5jgrSFqjRdk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bUpaLYWVHmiJTRumraMgioOdCTazzqmZRsbYpWT6fbs=; b=bS3LKQYx5pAmQ/k84Qf+jYWcn8 zC0Dz74gPQbaHmtl9FUNOsgUP3cUSSOSUyPC9jm5IJ9ZXN5c2ElxHtJMI2t/qAWRk0nA7g8jaCBkd nqlW6UkJ5RW62ZyoDyUotvIIwq8J1sJa9yJxN38bLINn6nCSTWkK/LlvGKYvAKEit/ic=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iWlkn-00555H-AP for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Nov 2019 18:28:02 +0000 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 523B1222BF; Mon, 18 Nov 2019 18:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574101675; bh=hgVt0ngLY4LQROiy5izRjuCjb237dxfSwA55PVeCtzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l114SmjFfMiCK5ArBiu50w/LTL4XSqt3bVoIVKzINA/oG9Eh2EGM4xiS+QA/Fgv+J mNypcXQpHUUYB5tY0Rr45k0ckpA44+9bEcKlJjm9DuvrhibzFR2abrr8mhumozpFnk s8EdB/fhR/Pqz8BjKwXm8lcS9QbxbklPvJUw0TD0= Date: Mon, 18 Nov 2019 10:27:53 -0800 From: Eric Biggers To: Jarkko Sakkinen Message-ID: <20191118182752.GB184560@gmail.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> <20191118180222.GC5984@linux.intel.com> <20191118180516.GD5984@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191118180516.GD5984@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1iWlkn-00555H-AP Subject: Re: [f2fs-dev] [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Howells , "Theodore Y. Ts'o" , Ondrej Mosnacek , linux-f2fs-devel@lists.sourceforge.net, Paul Lawrence , linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, g@linux.intel.com, Ondrej Kozina , Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Nov 18, 2019 at 08:05:16PM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > > I'm working on an xfstest for this: > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > > are any issues from that, I'll hear about it. > > > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > > a patch set? > > > > > > That's generally not done since the test goes to a different repo > > > (xfstests.git) which has a different review process from the kernel > > > change. > > > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > > is why I'm looking into setting up test environment so that I can review > > these patches with a sane judgement. > > And also since I've just barely started to help David on co-maintaining > keyring it is better to put extra emphasis on testing even for the most > trivial patches. That is fastest way to learn different interactions. > I gave some tips about kvm-xfstests in my other reply: https://lkml.kernel.org/linux-fscrypt/20191118181359.GA184560@gmail.com/ However, please note that xfstests is really about filesystem testing (including fscrypt), not about testing the keyrings subsystem itself. So while you're certainly welcome to run the fscrypt tests, for most patches you'll encounter as a keyrings maintainer the keyutils testsuite will be more useful. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FSL_HELO_FAKE,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51E6FC432C3 for ; Mon, 18 Nov 2019 18:28:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EF85222BF for ; Mon, 18 Nov 2019 18:28:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="swtJ0kZi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l114SmjF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EF85222BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F2hc9twmdefZP0smKtWTyD+d+ybFOgJbveS1NGeNC1g=; b=swtJ0kZiu9AzMj Wn75bVgoudPvYbCVferGMItySwTfiTQyR3cVJF9KtJnxAuQUZeSRvGIeH5p8yRsgR4BpGsJ6urEz1 5AO+FKe5p/hM6Lmn3Ii6/bK+43+vGYXiYPXakBJ2Y5ApyPchabOQ4oVF4XGC4dvkhAE1/hclPbAGM 84hNB3BLEqIhBHNpkY1USi/gDFIQLnAanC2s9W3ztrQ6wmQ5/d7e9ymh41syEZHDn0HwfuqkySUdF k2/4TgBM8ir1enlgPplL6qwkBYwuhP2gHzRbXubWnFP4iJMtQ7BgZI8YpUnVmKMnM482Mdat5HLoH ah6W5R9yRSdBFeOD2cag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWlkl-00013j-3i; Mon, 18 Nov 2019 18:27:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWlki-00012j-52 for linux-mtd@lists.infradead.org; Mon, 18 Nov 2019 18:27:57 +0000 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 523B1222BF; Mon, 18 Nov 2019 18:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574101675; bh=hgVt0ngLY4LQROiy5izRjuCjb237dxfSwA55PVeCtzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l114SmjFfMiCK5ArBiu50w/LTL4XSqt3bVoIVKzINA/oG9Eh2EGM4xiS+QA/Fgv+J mNypcXQpHUUYB5tY0Rr45k0ckpA44+9bEcKlJjm9DuvrhibzFR2abrr8mhumozpFnk s8EdB/fhR/Pqz8BjKwXm8lcS9QbxbklPvJUw0TD0= Date: Mon, 18 Nov 2019 10:27:53 -0800 From: Eric Biggers To: Jarkko Sakkinen Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-ID: <20191118182752.GB184560@gmail.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191116000139.GB18146@mit.edu> <20191118180222.GC5984@linux.intel.com> <20191118180516.GD5984@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191118180516.GD5984@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191118_102756_215746_ADCE15EC X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Howells , "Theodore Y. Ts'o" , Ondrej Mosnacek , linux-f2fs-devel@lists.sourceforge.net, Paul Lawrence , linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, g@linux.intel.com, Ondrej Kozina , Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Nov 18, 2019 at 08:05:16PM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > > I'm working on an xfstest for this: > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > > are any issues from that, I'll hear about it. > > > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > > a patch set? > > > > > > That's generally not done since the test goes to a different repo > > > (xfstests.git) which has a different review process from the kernel > > > change. > > > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > > is why I'm looking into setting up test environment so that I can review > > these patches with a sane judgement. > > And also since I've just barely started to help David on co-maintaining > keyring it is better to put extra emphasis on testing even for the most > trivial patches. That is fastest way to learn different interactions. > I gave some tips about kvm-xfstests in my other reply: https://lkml.kernel.org/linux-fscrypt/20191118181359.GA184560@gmail.com/ However, please note that xfstests is really about filesystem testing (including fscrypt), not about testing the keyrings subsystem itself. So while you're certainly welcome to run the fscrypt tests, for most patches you'll encounter as a keyrings maintainer the keyutils testsuite will be more useful. - Eric ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/