From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69553C432C0 for ; Tue, 19 Nov 2019 00:02:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B6892230B for ; Tue, 19 Nov 2019 00:02:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WPyeyP6b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726922AbfKSACv (ORCPT ); Mon, 18 Nov 2019 19:02:51 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:60626 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbfKSACv (ORCPT ); Mon, 18 Nov 2019 19:02:51 -0500 Received: from pendragon.ideasonboard.com (unknown [38.98.37.142]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AB82563; Tue, 19 Nov 2019 01:02:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1574121769; bh=zNIacMfQypz6l5ggJuH3A2Pi6iN+sk8YulgB9+eSy2Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WPyeyP6bjI635H57GIRptaS9WSKmWb6FNq39vQNOPuhHSCAYm+IMKqGx9K3qT3R0M ZmJbvcQPxKcb1JkMJaRrMKCNAfVvk2QPYDEajkbFTBLJMUxTcEf+CmeoR0ZBd6V5pR SdoBU+osBC+Oydps5R2TcL/VhUnFfNGyO23jGBgo= Date: Tue, 19 Nov 2019 02:02:37 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Neil Armstrong , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Andrzej Hajda , Simon Horman , Geert Uytterhoeven , Magnus Damm , Peter Rosin , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Kieran Bingham , Jacopo Mondi Subject: Re: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support Message-ID: <20191119000237.GF5171@pendragon.ideasonboard.com> References: <1573660292-10629-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573660292-10629-7-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1573660292-10629-7-git-send-email-fabrizio.castro@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Wed, Nov 13, 2019 at 03:51:25PM +0000, Fabrizio Castro wrote: > Add support for transparent LVDS decoders by adding a new > compatible string ("lvds-decoder") to the driver. > This patch also adds member connector_type to struct lvds_codec, > and that's because LVDS decoders have a different connector type > from LVDS encoders. We fill this new member up with the data > matching the compatible string. > > Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart > --- > v3->v4: > * New patch > --- > drivers/gpu/drm/bridge/lvds-codec.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c > index b5801a2..c32e125 100644 > --- a/drivers/gpu/drm/bridge/lvds-codec.c > +++ b/drivers/gpu/drm/bridge/lvds-codec.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -17,6 +18,7 @@ struct lvds_codec { > struct drm_bridge bridge; > struct drm_bridge *panel_bridge; > struct gpio_desc *powerdown_gpio; > + u32 connector_type; > }; > > static int lvds_codec_attach(struct drm_bridge *bridge) > @@ -65,6 +67,7 @@ static int lvds_codec_probe(struct platform_device *pdev) > if (!lvds_codec) > return -ENOMEM; > > + lvds_codec->connector_type = (u32)of_device_get_match_data(&pdev->dev); > lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", > GPIOD_OUT_HIGH); > if (IS_ERR(lvds_codec->powerdown_gpio)) { > @@ -105,7 +108,7 @@ static int lvds_codec_probe(struct platform_device *pdev) > > lvds_codec->panel_bridge = > devm_drm_panel_bridge_add_typed(dev, panel, > - DRM_MODE_CONNECTOR_LVDS); > + lvds_codec->connector_type); > if (IS_ERR(lvds_codec->panel_bridge)) > return PTR_ERR(lvds_codec->panel_bridge); > > @@ -133,8 +136,18 @@ static int lvds_codec_remove(struct platform_device *pdev) > } > > static const struct of_device_id lvds_codec_match[] = { > - { .compatible = "lvds-encoder" }, > - { .compatible = "thine,thc63lvdm83d" }, > + { > + .compatible = "lvds-decoder", > + .data = (void *)DRM_MODE_CONNECTOR_DPI, > + }, > + { > + .compatible = "lvds-encoder", > + .data = (void *)DRM_MODE_CONNECTOR_LVDS, > + }, > + { > + .compatible = "thine,thc63lvdm83d", > + .data = (void *)DRM_MODE_CONNECTOR_LVDS, > + }, > {}, > }; > MODULE_DEVICE_TABLE(of, lvds_codec_match); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support Date: Tue, 19 Nov 2019 02:02:37 +0200 Message-ID: <20191119000237.GF5171@pendragon.ideasonboard.com> References: <1573660292-10629-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573660292-10629-7-git-send-email-fabrizio.castro@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DEFF8966B for ; Tue, 19 Nov 2019 00:02:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1573660292-10629-7-git-send-email-fabrizio.castro@bp.renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Mark Rutland , devicetree@vger.kernel.org, Chris Paterson , Geert Uytterhoeven , Simon Horman , Neil Armstrong , David Airlie , Kieran Bingham , Magnus Damm , dri-devel@lists.freedesktop.org, Biju Das , linux-renesas-soc@vger.kernel.org, Rob Herring , Jacopo Mondi , Peter Rosin List-Id: dri-devel@lists.freedesktop.org SGkgRmFicml6aW8sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFdlZCwgTm92IDEzLCAy MDE5IGF0IDAzOjUxOjI1UE0gKzAwMDAsIEZhYnJpemlvIENhc3RybyB3cm90ZToKPiBBZGQgc3Vw cG9ydCBmb3IgdHJhbnNwYXJlbnQgTFZEUyBkZWNvZGVycyBieSBhZGRpbmcgYSBuZXcKPiBjb21w YXRpYmxlIHN0cmluZyAoImx2ZHMtZGVjb2RlciIpIHRvIHRoZSBkcml2ZXIuCj4gVGhpcyBwYXRj aCBhbHNvIGFkZHMgbWVtYmVyIGNvbm5lY3Rvcl90eXBlIHRvIHN0cnVjdCBsdmRzX2NvZGVjLAo+ IGFuZCB0aGF0J3MgYmVjYXVzZSBMVkRTIGRlY29kZXJzIGhhdmUgYSBkaWZmZXJlbnQgY29ubmVj dG9yIHR5cGUKPiBmcm9tIExWRFMgZW5jb2RlcnMuIFdlIGZpbGwgdGhpcyBuZXcgbWVtYmVyIHVw IHdpdGggdGhlIGRhdGEKPiBtYXRjaGluZyB0aGUgY29tcGF0aWJsZSBzdHJpbmcuCj4gCj4gU2ln bmVkLW9mZi1ieTogRmFicml6aW8gQ2FzdHJvIDxmYWJyaXppby5jYXN0cm9AYnAucmVuZXNhcy5j b20+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVh c29uYm9hcmQuY29tPgoKPiAtLS0KPiB2My0+djQ6Cj4gKiBOZXcgcGF0Y2gKPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2JyaWRnZS9sdmRzLWNvZGVjLmMgfCAxOSArKysrKysrKysrKysrKysrLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2x2ZHMtY29kZWMuYyBiL2RyaXZl cnMvZ3B1L2RybS9icmlkZ2UvbHZkcy1jb2RlYy5jCj4gaW5kZXggYjU4MDFhMi4uYzMyZTEyNSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2x2ZHMtY29kZWMuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvbHZkcy1jb2RlYy5jCj4gQEAgLTcsNiArNyw3IEBACj4g ICNpbmNsdWRlIDxsaW51eC9ncGlvL2NvbnN1bWVyLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tb2R1 bGUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L29mLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9vZl9kZXZp Y2UuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L29mX2dyYXBoLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9w bGF0Zm9ybV9kZXZpY2UuaD4KPiAgCj4gQEAgLTE3LDYgKzE4LDcgQEAgc3RydWN0IGx2ZHNfY29k ZWMgewo+ICAJc3RydWN0IGRybV9icmlkZ2UgYnJpZGdlOwo+ICAJc3RydWN0IGRybV9icmlkZ2Ug KnBhbmVsX2JyaWRnZTsKPiAgCXN0cnVjdCBncGlvX2Rlc2MgKnBvd2VyZG93bl9ncGlvOwo+ICsJ dTMyIGNvbm5lY3Rvcl90eXBlOwo+ICB9Owo+ICAKPiAgc3RhdGljIGludCBsdmRzX2NvZGVjX2F0 dGFjaChzdHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlKQo+IEBAIC02NSw2ICs2Nyw3IEBAIHN0YXRp YyBpbnQgbHZkc19jb2RlY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJ aWYgKCFsdmRzX2NvZGVjKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+ICAKPiArCWx2ZHNfY29kZWMt PmNvbm5lY3Rvcl90eXBlID0gKHUzMilvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRl dik7Cj4gIAlsdmRzX2NvZGVjLT5wb3dlcmRvd25fZ3BpbyA9IGRldm1fZ3Bpb2RfZ2V0X29wdGlv bmFsKGRldiwgInBvd2VyZG93biIsCj4gIAkJCQkJCQkgICAgIEdQSU9EX09VVF9ISUdIKTsKPiAg CWlmIChJU19FUlIobHZkc19jb2RlYy0+cG93ZXJkb3duX2dwaW8pKSB7Cj4gQEAgLTEwNSw3ICsx MDgsNyBAQCBzdGF0aWMgaW50IGx2ZHNfY29kZWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKPiAgCj4gIAlsdmRzX2NvZGVjLT5wYW5lbF9icmlkZ2UgPQo+ICAJCWRldm1fZHJt X3BhbmVsX2JyaWRnZV9hZGRfdHlwZWQoZGV2LCBwYW5lbCwKPiAtCQkJCQkJRFJNX01PREVfQ09O TkVDVE9SX0xWRFMpOwo+ICsJCQkJCQlsdmRzX2NvZGVjLT5jb25uZWN0b3JfdHlwZSk7Cj4gIAlp ZiAoSVNfRVJSKGx2ZHNfY29kZWMtPnBhbmVsX2JyaWRnZSkpCj4gIAkJcmV0dXJuIFBUUl9FUlIo bHZkc19jb2RlYy0+cGFuZWxfYnJpZGdlKTsKPiAgCj4gQEAgLTEzMyw4ICsxMzYsMTggQEAgc3Rh dGljIGludCBsdmRzX2NvZGVjX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ ICB9Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBsdmRzX2NvZGVjX21h dGNoW10gPSB7Cj4gLQl7IC5jb21wYXRpYmxlID0gImx2ZHMtZW5jb2RlciIgfSwKPiAtCXsgLmNv bXBhdGlibGUgPSAidGhpbmUsdGhjNjNsdmRtODNkIiB9LAo+ICsJewo+ICsJCS5jb21wYXRpYmxl ID0gImx2ZHMtZGVjb2RlciIsCj4gKwkJLmRhdGEgPSAodm9pZCAqKURSTV9NT0RFX0NPTk5FQ1RP Ul9EUEksCj4gKwl9LAo+ICsJewo+ICsJCS5jb21wYXRpYmxlID0gImx2ZHMtZW5jb2RlciIsCj4g KwkJLmRhdGEgPSAodm9pZCAqKURSTV9NT0RFX0NPTk5FQ1RPUl9MVkRTLAo+ICsJfSwKPiArCXsK PiArCQkuY29tcGF0aWJsZSA9ICJ0aGluZSx0aGM2M2x2ZG04M2QiLAo+ICsJCS5kYXRhID0gKHZv aWQgKilEUk1fTU9ERV9DT05ORUNUT1JfTFZEUywKPiArCX0sCj4gIAl7fSwKPiAgfTsKPiAgTU9E VUxFX0RFVklDRV9UQUJMRShvZiwgbHZkc19jb2RlY19tYXRjaCk7CgotLSAKUmVnYXJkcywKCkxh dXJlbnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs