From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E808DC432C0 for ; Tue, 19 Nov 2019 00:19:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5A3621D7A for ; Tue, 19 Nov 2019 00:19:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="i35tMmEh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726911AbfKSATe (ORCPT ); Mon, 18 Nov 2019 19:19:34 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:32800 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbfKSATe (ORCPT ); Mon, 18 Nov 2019 19:19:34 -0500 Received: from pendragon.ideasonboard.com (unknown [38.98.37.142]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BF3F0563; Tue, 19 Nov 2019 01:19:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1574122771; bh=vlkuKu9sK/q05JyLvuh2kZKytL/A+MShiE20ocAAk4w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i35tMmEh6BW60LUKlcTqtPW3FRbRE1M4KDX4lJqey0kJh4PoV26D8z61OZouuqlF2 bHGTxuHcCeBcFWDc+EAUpRdkMf5QyYhewkInc0df+ob22XIjk9y2khyBamV6YXrNsU ZuDZQAj9qtNjEjLAxvjqfTpKr4Qjus5KBsx/oAF8= Date: Tue, 19 Nov 2019 02:19:08 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Neil Armstrong , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Andrzej Hajda , Simon Horman , Geert Uytterhoeven , Magnus Damm , Peter Rosin , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Kieran Bingham , Jacopo Mondi Subject: Re: [PATCH v4 13/13] [HACK] dt-bindings: display: bridge: lvds-codec: Absorb thine,thc63lvdm83d.txt Message-ID: <20191119001908.GM5171@pendragon.ideasonboard.com> References: <1573660292-10629-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573660292-10629-14-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1573660292-10629-14-git-send-email-fabrizio.castro@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Wed, Nov 13, 2019 at 03:51:32PM +0000, Fabrizio Castro wrote: > At this point in time, compatible string "thine,thc63lvdm83d" is > backed by the lvds-codec driver, and the documentation contained > in thine,thc63lvdm83d.txt is basically the same as the one > contained in lvds-codec.yaml (generic fallback compatible string > aside), therefore absorb thine,thc63lvdm83d.txt. > > Signed-off-by: Fabrizio Castro > > --- > Hi Laurent, > > what do you think about this patch? I think it's good :-) Reviewed-by: Laurent Pinchart It however doesn't address my concern that resulted in patch 12/13. A DTB could still contain only lvds-encoder or lvds-decoder, even if the DT bindings forbid it. Adding a check in the driver would enforce the use of a device-specific compatible string. It adds quite a bit of complexity though :-S > v3->v4: > * New patch > --- > .../bindings/display/bridge/lvds-codec.yaml | 5 +-- > .../bindings/display/bridge/thine,thc63lvdm83d.txt | 50 ---------------------- > 2 files changed, 2 insertions(+), 53 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 21f8c6e..420bfce 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -30,9 +30,6 @@ description: | > > properties: > compatible: > - description: | > - Must list the device specific compatible string first, followed by the > - generic compatible string. > oneOf: > - items: > - enum: > @@ -44,6 +41,8 @@ properties: > - enum: > - ti,ds90cf384a # For the DS90CF384A FPD-Link LVDS Receiver > - const: lvds-decoder # Generic LVDS decoders compatible fallback > + - enum: > + - thine,thc63lvdm83d # For the THC63LVDM83D LVDS serializer > > ports: > type: object > diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt > deleted file mode 100644 > index fee3c88..0000000 > --- a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt > +++ /dev/null > @@ -1,50 +0,0 @@ > -THine Electronics THC63LVDM83D LVDS serializer > ----------------------------------------------- > - > -The THC63LVDM83D is an LVDS serializer designed to support pixel data > -transmission between a host and a flat panel. > - > -Required properties: > - > -- compatible: Should be "thine,thc63lvdm83d" > - > -Optional properties: > - > -- powerdown-gpios: Power down control GPIO (the /PWDN pin, active low). > - > -Required nodes: > - > -The THC63LVDM83D has two video ports. Their connections are modeled using the > -OFgraph bindings specified in Documentation/devicetree/bindings/graph.txt. > - > -- Video port 0 for CMOS/TTL input > -- Video port 1 for LVDS output > - > - > -Example > -------- > - > - lvds_enc: encoder@0 { > - compatible = "thine,thc63lvdm83d"; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - > - lvds_enc_in: endpoint@0 { > - remote-endpoint = <&rgb_out>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - > - lvds_enc_out: endpoint@0 { > - remote-endpoint = <&panel_in>; > - }; > - }; > - }; > - }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 13/13] [HACK] dt-bindings: display: bridge: lvds-codec: Absorb thine,thc63lvdm83d.txt Date: Tue, 19 Nov 2019 02:19:08 +0200 Message-ID: <20191119001908.GM5171@pendragon.ideasonboard.com> References: <1573660292-10629-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573660292-10629-14-git-send-email-fabrizio.castro@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE0FE6E85C for ; Tue, 19 Nov 2019 00:19:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1573660292-10629-14-git-send-email-fabrizio.castro@bp.renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Mark Rutland , devicetree@vger.kernel.org, Chris Paterson , Geert Uytterhoeven , Simon Horman , Neil Armstrong , David Airlie , Kieran Bingham , Magnus Damm , dri-devel@lists.freedesktop.org, Biju Das , linux-renesas-soc@vger.kernel.org, Rob Herring , Jacopo Mondi , Peter Rosin List-Id: dri-devel@lists.freedesktop.org SGkgRmFicml6aW8sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFdlZCwgTm92IDEzLCAy MDE5IGF0IDAzOjUxOjMyUE0gKzAwMDAsIEZhYnJpemlvIENhc3RybyB3cm90ZToKPiBBdCB0aGlz IHBvaW50IGluIHRpbWUsIGNvbXBhdGlibGUgc3RyaW5nICJ0aGluZSx0aGM2M2x2ZG04M2QiIGlz Cj4gYmFja2VkIGJ5IHRoZSBsdmRzLWNvZGVjIGRyaXZlciwgYW5kIHRoZSBkb2N1bWVudGF0aW9u IGNvbnRhaW5lZAo+IGluIHRoaW5lLHRoYzYzbHZkbTgzZC50eHQgaXMgYmFzaWNhbGx5IHRoZSBz YW1lIGFzIHRoZSBvbmUKPiBjb250YWluZWQgaW4gbHZkcy1jb2RlYy55YW1sIChnZW5lcmljIGZh bGxiYWNrIGNvbXBhdGlibGUgc3RyaW5nCj4gYXNpZGUpLCB0aGVyZWZvcmUgYWJzb3JiIHRoaW5l LHRoYzYzbHZkbTgzZC50eHQuCj4gCj4gU2lnbmVkLW9mZi1ieTogRmFicml6aW8gQ2FzdHJvIDxm YWJyaXppby5jYXN0cm9AYnAucmVuZXNhcy5jb20+Cj4gCj4gLS0tCj4gSGkgTGF1cmVudCwKPiAK PiB3aGF0IGRvIHlvdSB0aGluayBhYm91dCB0aGlzIHBhdGNoPwoKSSB0aGluayBpdCdzIGdvb2Qg Oi0pCgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVh c29uYm9hcmQuY29tPgoKSXQgaG93ZXZlciBkb2Vzbid0IGFkZHJlc3MgbXkgY29uY2VybiB0aGF0 IHJlc3VsdGVkIGluIHBhdGNoIDEyLzEzLiBBCkRUQiBjb3VsZCBzdGlsbCBjb250YWluIG9ubHkg bHZkcy1lbmNvZGVyIG9yIGx2ZHMtZGVjb2RlciwgZXZlbiBpZiB0aGUKRFQgYmluZGluZ3MgZm9y YmlkIGl0LiBBZGRpbmcgYSBjaGVjayBpbiB0aGUgZHJpdmVyIHdvdWxkIGVuZm9yY2UgdGhlCnVz ZSBvZiBhIGRldmljZS1zcGVjaWZpYyBjb21wYXRpYmxlIHN0cmluZy4gSXQgYWRkcyBxdWl0ZSBh IGJpdCBvZgpjb21wbGV4aXR5IHRob3VnaCA6LVMKCj4gdjMtPnY0Ogo+ICogTmV3IHBhdGNoCj4g LS0tCj4gIC4uLi9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9sdmRzLWNvZGVjLnlhbWwgICAgICAg IHwgIDUgKy0tCj4gIC4uLi9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZG04 M2QudHh0IHwgNTAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgNTMgZGVsZXRpb25zKC0pCj4gIGRlbGV0ZSBtb2RlIDEwMDY0NCBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdGhpbmUsdGhjNjNs dmRtODNkLnR4dAo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9icmlkZ2UvbHZkcy1jb2RlYy55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2x2ZHMtY29kZWMueWFtbAo+IGluZGV4IDIx ZjhjNmUuLjQyMGJmY2UgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2x2ZHMtY29kZWMueWFtbAo+ICsrKyBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9sdmRzLWNvZGVjLnlhbWwKPiBA QCAtMzAsOSArMzAsNiBAQCBkZXNjcmlwdGlvbjogfAo+ICAKPiAgcHJvcGVydGllczoKPiAgICBj b21wYXRpYmxlOgo+IC0gICAgZGVzY3JpcHRpb246IHwKPiAtICAgICAgTXVzdCBsaXN0IHRoZSBk ZXZpY2Ugc3BlY2lmaWMgY29tcGF0aWJsZSBzdHJpbmcgZmlyc3QsIGZvbGxvd2VkIGJ5IHRoZQo+ IC0gICAgICBnZW5lcmljIGNvbXBhdGlibGUgc3RyaW5nLgo+ICAgICAgb25lT2Y6Cj4gICAgICAg IC0gaXRlbXM6Cj4gICAgICAgICAgLSBlbnVtOgo+IEBAIC00NCw2ICs0MSw4IEBAIHByb3BlcnRp ZXM6Cj4gICAgICAgICAgLSBlbnVtOgo+ICAgICAgICAgICAgLSB0aSxkczkwY2YzODRhICAgICAj IEZvciB0aGUgRFM5MENGMzg0QSBGUEQtTGluayBMVkRTIFJlY2VpdmVyCj4gICAgICAgICAgLSBj b25zdDogbHZkcy1kZWNvZGVyICMgR2VuZXJpYyBMVkRTIGRlY29kZXJzIGNvbXBhdGlibGUgZmFs bGJhY2sKPiArICAgICAgLSBlbnVtOgo+ICsgICAgICAgIC0gdGhpbmUsdGhjNjNsdmRtODNkICAj IEZvciB0aGUgVEhDNjNMVkRNODNEIExWRFMgc2VyaWFsaXplcgo+ICAKPiAgICBwb3J0czoKPiAg ICAgIHR5cGU6IG9iamVjdAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdGhpbmUsdGhjNjNsdmRtODNkLnR4dCBiL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZG04 M2QudHh0Cj4gZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggZmVlM2M4OC4uMDAwMDAw MAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRn ZS90aGluZSx0aGM2M2x2ZG04M2QudHh0Cj4gKysrIC9kZXYvbnVsbAo+IEBAIC0xLDUwICswLDAg QEAKPiAtVEhpbmUgRWxlY3Ryb25pY3MgVEhDNjNMVkRNODNEIExWRFMgc2VyaWFsaXplcgo+IC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gLQo+IC1UaGUg VEhDNjNMVkRNODNEIGlzIGFuIExWRFMgc2VyaWFsaXplciBkZXNpZ25lZCB0byBzdXBwb3J0IHBp eGVsIGRhdGEKPiAtdHJhbnNtaXNzaW9uIGJldHdlZW4gYSBob3N0IGFuZCBhIGZsYXQgcGFuZWwu Cj4gLQo+IC1SZXF1aXJlZCBwcm9wZXJ0aWVzOgo+IC0KPiAtLSBjb21wYXRpYmxlOiBTaG91bGQg YmUgInRoaW5lLHRoYzYzbHZkbTgzZCIKPiAtCj4gLU9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gLQo+ IC0tIHBvd2VyZG93bi1ncGlvczogUG93ZXIgZG93biBjb250cm9sIEdQSU8gKHRoZSAvUFdETiBw aW4sIGFjdGl2ZSBsb3cpLgo+IC0KPiAtUmVxdWlyZWQgbm9kZXM6Cj4gLQo+IC1UaGUgVEhDNjNM VkRNODNEIGhhcyB0d28gdmlkZW8gcG9ydHMuIFRoZWlyIGNvbm5lY3Rpb25zIGFyZSBtb2RlbGVk IHVzaW5nIHRoZQo+IC1PRmdyYXBoIGJpbmRpbmdzIHNwZWNpZmllZCBpbiBEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZ3JhcGgudHh0Lgo+IC0KPiAtLSBWaWRlbyBwb3J0IDAgZm9y IENNT1MvVFRMIGlucHV0Cj4gLS0gVmlkZW8gcG9ydCAxIGZvciBMVkRTIG91dHB1dAo+IC0KPiAt Cj4gLUV4YW1wbGUKPiAtLS0tLS0tLQo+IC0KPiAtCWx2ZHNfZW5jOiBlbmNvZGVyQDAgewo+IC0J CWNvbXBhdGlibGUgPSAidGhpbmUsdGhjNjNsdmRtODNkIjsKPiAtCj4gLQkJcG9ydHMgewo+IC0J CQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiAtCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gLQo+IC0J CQlwb3J0QDAgewo+IC0JCQkJcmVnID0gPDA+Owo+IC0KPiAtCQkJCWx2ZHNfZW5jX2luOiBlbmRw b2ludEAwIHsKPiAtCQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JnJnYl9vdXQ+Owo+IC0JCQkJfTsK PiAtCQkJfTsKPiAtCj4gLQkJCXBvcnRAMSB7Cj4gLQkJCQlyZWcgPSA8MT47Cj4gLQo+IC0JCQkJ bHZkc19lbmNfb3V0OiBlbmRwb2ludEAwIHsKPiAtCQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JnBh bmVsX2luPjsKPiAtCQkJCX07Cj4gLQkJCX07Cj4gLQkJfTsKPiAtCX07CgotLSAKUmVnYXJkcywK CkxhdXJlbnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs