From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E4FFC432C3 for ; Tue, 19 Nov 2019 05:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB5D0206DA for ; Tue, 19 Nov 2019 05:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574143137; bh=X33pF3J0S4PQTHIOi6rgmmFFe9etwYPH/2MIH3bxg/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YQT3Tvdx9GZ6PDr1wd//xlNuR94PsehmvBECfl99U621huDUD/qop7yAEZznXIstC /w3ZkQZn1RsmxUT/RsLIrGWryNEwg4Uuv4VXEDr8Qk6lbddg7Dx39vpEvaVBIzALzB kGi8RiYDYiTGiNdlAeKmR/77y9DAP/ZLoHnBw21U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730045AbfKSFsi (ORCPT ); Tue, 19 Nov 2019 00:48:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:45166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731090AbfKSFsf (ORCPT ); Tue, 19 Nov 2019 00:48:35 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 047E8208CC; Tue, 19 Nov 2019 05:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142514; bh=X33pF3J0S4PQTHIOi6rgmmFFe9etwYPH/2MIH3bxg/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JTjwgBHIW3quhObtLgHi5m3gNiknwR1PCsXsQY9HMMK/DwKScqA6rp85pvxkOtFKM T0rqk+GaJIoz+B6N7SbCKtwi9G6hnZC7J3G0hP+kC0RNXLv9/yZldwRBqd8xpuhLQb UwEL5FC3kwlCLuka9dUWu7fdHUQNT97OVcw/5spU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lao Wei , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 107/239] media: fix: media: pci: meye: validate offset to avoid arbitrary access Date: Tue, 19 Nov 2019 06:18:27 +0100 Message-Id: <20191119051326.536887890@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lao Wei [ Upstream commit eac7230fdb4672c2cb56f6a01a1744f562c01f80 ] Motion eye video4linux driver for Sony Vaio PictureBook desn't validate user-controlled parameter 'vma->vm_pgoff', a malicious process might access all of kernel memory from user space by trying pass different arbitrary address. Discussion: http://www.openwall.com/lists/oss-security/2018/07/06/1 Signed-off-by: Lao Wei Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/meye/meye.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c index 49e047e4a81ee..926707c997acb 100644 --- a/drivers/media/pci/meye/meye.c +++ b/drivers/media/pci/meye/meye.c @@ -1460,7 +1460,7 @@ static int meye_mmap(struct file *file, struct vm_area_struct *vma) unsigned long page, pos; mutex_lock(&meye.lock); - if (size > gbuffers * gbufsize) { + if (size > gbuffers * gbufsize || offset > gbuffers * gbufsize - size) { mutex_unlock(&meye.lock); return -EINVAL; } -- 2.20.1