From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB07BC432C0 for ; Tue, 19 Nov 2019 05:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B37E221823 for ; Tue, 19 Nov 2019 05:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142612; bh=8JSNvn9TVCSWekjREP0P9IlnAzsxkji+Lf9fjESjWsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b8qbeRdkXIfHtkOJxQUEDuWJudQzP4U5L9/+T1r0AFYcv3MxBWZbsGD1aZ5lX+kkG 8KKkWBT9IqgiKTRdklMM2ApUZ0Yr1n82/PmMhKhC7QsYkbJI/239ad++aNNT3rJSC4 1wrE5b1FehbBwC9ki4cVKCaWQV6fq1wC1ULx1z0w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731591AbfKSFuL (ORCPT ); Tue, 19 Nov 2019 00:50:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:47068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731575AbfKSFuG (ORCPT ); Tue, 19 Nov 2019 00:50:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BDE220862; Tue, 19 Nov 2019 05:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142605; bh=8JSNvn9TVCSWekjREP0P9IlnAzsxkji+Lf9fjESjWsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CwI+oLqm5XebML41RlabhsdQabUWAdduFUWEuqbj3LoTMvSNxbL+TVKsTDLHSJ2Fl kRUCW7WGZf9os+YHKvKzpKs7V2IO2GTBOAf/obSosiuB6QuXcLo84EIys6SyJ+i7ZS wZ1rLN/6hhaz10a7FRVHHc6u2M8bEqZG7z60vk00= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Breno Leitao , Michael Ellerman , Sasha Levin Subject: [PATCH 4.14 139/239] powerpc/iommu: Avoid derefence before pointer check Date: Tue, 19 Nov 2019 06:18:59 +0100 Message-Id: <20191119051331.473699362@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Breno Leitao [ Upstream commit 984ecdd68de0fa1f63ce205d6c19ef5a7bc67b40 ] The tbl pointer is being derefenced by IOMMU_PAGE_SIZE prior the check if it is not NULL. Just moving the dereference code to after the check, where there will be guarantee that 'tbl' will not be NULL. Signed-off-by: Breno Leitao Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/kernel/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c index af7a20dc6e093..80b6caaa9b92e 100644 --- a/arch/powerpc/kernel/iommu.c +++ b/arch/powerpc/kernel/iommu.c @@ -785,9 +785,9 @@ dma_addr_t iommu_map_page(struct device *dev, struct iommu_table *tbl, vaddr = page_address(page) + offset; uaddr = (unsigned long)vaddr; - npages = iommu_num_pages(uaddr, size, IOMMU_PAGE_SIZE(tbl)); if (tbl) { + npages = iommu_num_pages(uaddr, size, IOMMU_PAGE_SIZE(tbl)); align = 0; if (tbl->it_page_shift < PAGE_SHIFT && size >= PAGE_SIZE && ((unsigned long)vaddr & ~PAGE_MASK) == 0) -- 2.20.1