From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 444DEC432C0 for ; Tue, 19 Nov 2019 05:54:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 123B42084D for ; Tue, 19 Nov 2019 05:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142850; bh=fg91nLDGVt3w607YoMYtnBvNOU3I7TSwxUy5GAjZX40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cCzZfVnzdgLkM2l78UUvgyIp3AItnUUKSHu8JIgQZiSd7joC4dfUBHlLbdcTxmOfQ tz8XOrW+h+oW//bqSgJfq5fzzBZX4nLxTfZU1NK1Kfyby5AFTL2LfRLAzyzHIGvns+ fDp0c4xl778K/2ekRzzNxUGLsyp90DWw44dExbOw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731804AbfKSFyJ (ORCPT ); Tue, 19 Nov 2019 00:54:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:52152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732095AbfKSFyE (ORCPT ); Tue, 19 Nov 2019 00:54:04 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D53A920721; Tue, 19 Nov 2019 05:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142844; bh=fg91nLDGVt3w607YoMYtnBvNOU3I7TSwxUy5GAjZX40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0363rzaXbWMN4P+jOxXSazyZksRlFP7sp8SM9+r+9XJcXmbn1EiQJQhANDsNxKsqI BESaDELK4y0BJq0yDd1AhSmJnmIe3lrTPYnhViHaIACqv8vwFwVjUenQVLd4YsRzaQ FLgwmNtmTd1cLMTZFx+VdT56I9208W4NClTzC3+8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Balakrishna Godavarthi , Marcel Holtmann , Sasha Levin Subject: [PATCH 4.14 212/239] Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing proto races Date: Tue, 19 Nov 2019 06:20:12 +0100 Message-Id: <20191119051338.451348099@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Balakrishna Godavarthi [ Upstream commit 7cf7846d27bfc9731e449857db3eec5e0e9701ba ] Clearing HCI_UART_PROTO_READY will avoid usage of proto function pointers before running the proto close function pointer. There is chance of kernel crash, due to usage of non proto close function pointers after proto close. Signed-off-by: Balakrishna Godavarthi Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- drivers/bluetooth/hci_serdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c index 52e6d4d1608e3..69c00a3db5382 100644 --- a/drivers/bluetooth/hci_serdev.c +++ b/drivers/bluetooth/hci_serdev.c @@ -360,6 +360,7 @@ void hci_uart_unregister_device(struct hci_uart *hu) { struct hci_dev *hdev = hu->hdev; + clear_bit(HCI_UART_PROTO_READY, &hu->flags); hci_unregister_dev(hdev); hci_free_dev(hdev); -- 2.20.1