From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 717ACC43215 for ; Tue, 19 Nov 2019 05:55:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39EFF20872 for ; Tue, 19 Nov 2019 05:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142959; bh=BBDr5XZmvudqT38/n9AWNa+7cdhu3U138aHUBryPFtE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rzdfdUKGJ9qm4Yq8PjKacLGR41ncQyKG5wh62gqAMPkFk1ELWBvh5G9HtseKYiTg+ thXTqtjNoLNlbfBtQdGafNSMESX6tzFh+dBCy/B/VgxsjfxDcQmXvUJOp9iBSDKmMS M3ZsCBj0Z4wjtbsm8RTsKgLYf/j27QTqYU+gmO6A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732142AbfKSFy2 (ORCPT ); Tue, 19 Nov 2019 00:54:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:52552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732135AbfKSFyY (ORCPT ); Tue, 19 Nov 2019 00:54:24 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCF4D21D7B; Tue, 19 Nov 2019 05:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142864; bh=BBDr5XZmvudqT38/n9AWNa+7cdhu3U138aHUBryPFtE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tBWIY5v/ix5WblnoDZTuSUzD85tfg0n0QdsBxaNosFdjYomGV+bwIQuJxiRd7NxZ1 jDsjMZMHlNEgY307hbRv0lgVpmxI+sTjqUftWBGs4NyQ195SUEDOp3kCN2JPa+BgED pVWL4lJIqYqAdmu3vcbLv9Fp1Ab55ZoNhDSvmnfg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Schmitz , Finn Thain , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 227/239] scsi: NCR5380: Handle BUS FREE during reselection Date: Tue, 19 Nov 2019 06:20:27 +0100 Message-Id: <20191119051340.769442775@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Finn Thain [ Upstream commit ca694afad707cb3ae2fdef3b28454444d9ac726e ] The X3T9.2 specification (draft) says, under "6.1.4.2 RESELECTION time-out procedure", that a target may assert RST or go to BUS FREE phase if the initiator does not respond within 200 us. Something like this has been observed with AztecMonster II target. When it happens, all we can do is wait for the target to try again. Tested-by: Michael Schmitz Signed-off-by: Finn Thain Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/NCR5380.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 48f123601f575..a85c5155fcf40 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -2045,6 +2045,9 @@ static void NCR5380_reselect(struct Scsi_Host *instance) if (NCR5380_poll_politely(hostdata, STATUS_REG, SR_REQ, SR_REQ, 2 * HZ) < 0) { + if ((NCR5380_read(STATUS_REG) & (SR_BSY | SR_SEL)) == 0) + /* BUS FREE phase */ + return; shost_printk(KERN_ERR, instance, "reselect: REQ timeout\n"); do_abort(instance); return; -- 2.20.1