From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWxgm-0000p7-VL for kexec@lists.infradead.org; Tue, 19 Nov 2019 07:12:45 +0000 Received: by mail-pg1-x541.google.com with SMTP id k32so5193552pgl.2 for ; Mon, 18 Nov 2019 23:12:40 -0800 (PST) Date: Tue, 19 Nov 2019 16:13:42 +0900 From: AKASHI Takahiro Subject: Re: [PATCH v4 0/3] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs) Message-ID: <20191119071341.GW22427@linaro.org> References: <1573459282-26989-1-git-send-email-bhsharma@redhat.com> <20191113063858.GE22427@linaro.org> <20191115015959.GI22427@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Prabhakar Kushwaha Cc: Mark Rutland , Linux Doc Mailing List , Benjamin Herrenschmidt , Bhupesh Sharma , Paul Mackerras , Will Deacon , Ingo Molnar , Jonathan Corbet , Michael Ellerman , x86@kernel.org, Catalin Marinas , Boris Petkov , Thomas Gleixner , Bhupesh SHARMA , linux-arm-kernel , Kazuhito Hagio , Ard Biesheuvel , Steve Capper , kexec mailing list , Linux Kernel Mailing List , James Morse , Dave Anderson , linuxppc-dev@lists.ozlabs.org Hi Prabhakar, On Tue, Nov 19, 2019 at 12:02:46PM +0530, Prabhakar Kushwaha wrote: > Hi Akashi, > > On Fri, Nov 15, 2019 at 7:29 AM AKASHI Takahiro > wrote: > > > > Bhupesh, > > > > On Fri, Nov 15, 2019 at 01:24:17AM +0530, Bhupesh Sharma wrote: > > > Hi Akashi, > > > > > > On Wed, Nov 13, 2019 at 12:11 PM AKASHI Takahiro > > > wrote: > > > > > > > > Hi Bhupesh, > > > > > > > > Do you have a corresponding patch for userspace tools, > > > > including crash util and/or makedumpfile? > > > > Otherwise, we can't verify that a generated core file is > > > > correctly handled. > > > > > > Sure. I am still working on the crash-utility related changes, but you > > > can find the makedumpfile changes I posted a couple of days ago here > > > (see [0]) and the github link for the makedumpfile changes can be seen > > > via [1]. > > > > > > I will post the crash-util changes shortly as well. > > > Thanks for having a look at the same. > > > > Thank you. > > I have tested my kdump patch with a hacked version of crash > > where VA_BITS_ACTUAL is calculated from tcr_el1_t1sz in vmcoreinfo. > > > > I also did hack to calculate VA_BITS_ACTUAL is calculated from > tcr_el1_t1sz in vmcoreinfo. Now i am getting error same as mentioned > by you in other thread last month. > https://www.mail-archive.com/crash-utility@redhat.com/msg07385.html > > how this error was overcome? > > I am using > - crashkernel: https://github.com/crash-utility/crash.git commit: > babd7ae62d4e8fd6f93fd30b88040d9376522aa3 > and > - Linux: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > commit: af42d3466bdc8f39806b26f593604fdc54140bcb # I am rather reluctant to cross-post non-kernel patch to lkml/lakml, The only change I made to crash utility was: ===8<=== diff --git a/arm64.c b/arm64.c index 5ee5f1a29a41..84e40aeb561b 100644 --- a/arm64.c +++ b/arm64.c @@ -3857,8 +3857,8 @@ arm64_calc_VA_BITS(void) } else if (ACTIVE()) error(FATAL, "cannot determine VA_BITS_ACTUAL: please use /proc/kcore\n"); else { - if ((string = pc->read_vmcoreinfo("NUMBER(VA_BITS_ACTUAL)"))) { - value = atol(string); + if ((string = pc->read_vmcoreinfo("NUMBER(tcr_el1_t1sz)"))) { + value = 64 - strtoll(string, NULL, 0); free(string); machdep->machspec->VA_BITS_ACTUAL = value; machdep->machspec->VA_BITS = value; ===>8=== Thanks, -Takahiro Akashi > --pk _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 6D9C87D90D for ; Tue, 19 Nov 2019 07:12:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfKSHMl (ORCPT ); Tue, 19 Nov 2019 02:12:41 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39398 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726555AbfKSHMk (ORCPT ); Tue, 19 Nov 2019 02:12:40 -0500 Received: by mail-pf1-f195.google.com with SMTP id x28so11703153pfo.6 for ; Mon, 18 Nov 2019 23:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SOkEaxvoeuRDKKO9iEeAXK3d8jDrm2+Y0YFp9RHvoAo=; b=nuNOMTdV6cqA5xhs04CNCftYPLjSdTjJ0ePCPMCc3uiZcs4YCBMy9ZamdEurSipKqb B7qbTtqSkuv+cFtd5XGfPFzEAOygMAUU6PfcUq9+XWmSNfghnDQd5F7MZO2RpEtgPBO4 pY9GDSzO29EdOQ3rQOPPXttJfNyhL/qzEK/UbIBzD0EktqXFkIZukEz6uYOhqO/XpJSv CZVM33HewLSdQwXu5Sk//1CSz1ZkVkWtwDNAv2TM14cIkWzrIAXJHvymtQVGDfQtyKZ4 Gy6ZtONETM6pOH2ZXJaQ3hbDHkgWZ1LaHoK8pE6aiIh13lYEHwfU8H2bnK85SCTR2yLA qJ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=SOkEaxvoeuRDKKO9iEeAXK3d8jDrm2+Y0YFp9RHvoAo=; b=FILOf4xlPWW/QGEYD/IFWgGJYt+RNYJOFaPjUnP/8TkpYnZHFcSLYiVauqtCkwHCxM QbgrakaoZsoCmroSGYdDTfbCfEKQkxeXrzcXldpHUwXbHfOJE8VHE83vy1K/QzuMFnB6 OMokyT1n8DKTBaITU+pFbAOUELfZ7hOoHBruKwXRAny2wQsA/DkbhGUz136UyZir+dm+ YtuSgJZ32dRqz+bRQ2pUHYRN8jSVu8nr5wDuUYvK8FI5Yf2a/4GJBi+Wtrk6F9CXUuU/ ZAAiZTz3mRycPPzp24fM7nu3f+LdyXxfUq71JiVwls6SFBsPryuJjprdjoi2N+KjAaNq YZKQ== X-Gm-Message-State: APjAAAUzj/+CkrBAe4k7aCvw22O3cg6BHh+1D8k5pId8jn1H6I7PjTyF XxmaUdWfUqsGO4Qq5tStmuVh6w== X-Google-Smtp-Source: APXvYqwFnemtfhSeFTtXNTKp5S2y3O1/8DNvV3VlNu9ve+aPwic4dTdlBLzDttqWkR7TRM8xvN2dTQ== X-Received: by 2002:a63:68c3:: with SMTP id d186mr3516436pgc.301.1574147559580; Mon, 18 Nov 2019 23:12:39 -0800 (PST) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id j7sm1931994pjz.12.2019.11.18.23.12.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Nov 2019 23:12:38 -0800 (PST) Date: Tue, 19 Nov 2019 16:13:42 +0900 From: AKASHI Takahiro To: Prabhakar Kushwaha Cc: Bhupesh Sharma , Linux Kernel Mailing List , Bhupesh SHARMA , Boris Petkov , Ingo Molnar , Thomas Gleixner , Jonathan Corbet , James Morse , Mark Rutland , Will Deacon , Steve Capper , Catalin Marinas , Ard Biesheuvel , Michael Ellerman , Paul Mackerras , Benjamin Herrenschmidt , Dave Anderson , Kazuhito Hagio , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Linux Doc Mailing List , kexec mailing list Subject: Re: [PATCH v4 0/3] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs) Message-ID: <20191119071341.GW22427@linaro.org> Mail-Followup-To: AKASHI Takahiro , Prabhakar Kushwaha , Bhupesh Sharma , Linux Kernel Mailing List , Bhupesh SHARMA , Boris Petkov , Ingo Molnar , Thomas Gleixner , Jonathan Corbet , James Morse , Mark Rutland , Will Deacon , Steve Capper , Catalin Marinas , Ard Biesheuvel , Michael Ellerman , Paul Mackerras , Benjamin Herrenschmidt , Dave Anderson , Kazuhito Hagio , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Linux Doc Mailing List , kexec mailing list References: <1573459282-26989-1-git-send-email-bhsharma@redhat.com> <20191113063858.GE22427@linaro.org> <20191115015959.GI22427@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Prabhakar, On Tue, Nov 19, 2019 at 12:02:46PM +0530, Prabhakar Kushwaha wrote: > Hi Akashi, > > On Fri, Nov 15, 2019 at 7:29 AM AKASHI Takahiro > wrote: > > > > Bhupesh, > > > > On Fri, Nov 15, 2019 at 01:24:17AM +0530, Bhupesh Sharma wrote: > > > Hi Akashi, > > > > > > On Wed, Nov 13, 2019 at 12:11 PM AKASHI Takahiro > > > wrote: > > > > > > > > Hi Bhupesh, > > > > > > > > Do you have a corresponding patch for userspace tools, > > > > including crash util and/or makedumpfile? > > > > Otherwise, we can't verify that a generated core file is > > > > correctly handled. > > > > > > Sure. I am still working on the crash-utility related changes, but you > > > can find the makedumpfile changes I posted a couple of days ago here > > > (see [0]) and the github link for the makedumpfile changes can be seen > > > via [1]. > > > > > > I will post the crash-util changes shortly as well. > > > Thanks for having a look at the same. > > > > Thank you. > > I have tested my kdump patch with a hacked version of crash > > where VA_BITS_ACTUAL is calculated from tcr_el1_t1sz in vmcoreinfo. > > > > I also did hack to calculate VA_BITS_ACTUAL is calculated from > tcr_el1_t1sz in vmcoreinfo. Now i am getting error same as mentioned > by you in other thread last month. > https://www.mail-archive.com/crash-utility@redhat.com/msg07385.html > > how this error was overcome? > > I am using > - crashkernel: https://github.com/crash-utility/crash.git commit: > babd7ae62d4e8fd6f93fd30b88040d9376522aa3 > and > - Linux: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > commit: af42d3466bdc8f39806b26f593604fdc54140bcb # I am rather reluctant to cross-post non-kernel patch to lkml/lakml, The only change I made to crash utility was: ===8<=== diff --git a/arm64.c b/arm64.c index 5ee5f1a29a41..84e40aeb561b 100644 --- a/arm64.c +++ b/arm64.c @@ -3857,8 +3857,8 @@ arm64_calc_VA_BITS(void) } else if (ACTIVE()) error(FATAL, "cannot determine VA_BITS_ACTUAL: please use /proc/kcore\n"); else { - if ((string = pc->read_vmcoreinfo("NUMBER(VA_BITS_ACTUAL)"))) { - value = atol(string); + if ((string = pc->read_vmcoreinfo("NUMBER(tcr_el1_t1sz)"))) { + value = 64 - strtoll(string, NULL, 0); free(string); machdep->machspec->VA_BITS_ACTUAL = value; machdep->machspec->VA_BITS = value; ===>8=== Thanks, -Takahiro Akashi > --pk From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FE4C43141 for ; Tue, 19 Nov 2019 07:14:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56F21222DF for ; Tue, 19 Nov 2019 07:14:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nuNOMTdV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56F21222DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47HHBp6R05zDqPK for ; Tue, 19 Nov 2019 18:14:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=takahiro.akashi@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="nuNOMTdV"; dkim-atps=neutral Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47HH8W60hfzDqBh for ; Tue, 19 Nov 2019 18:12:43 +1100 (AEDT) Received: by mail-pf1-x442.google.com with SMTP id p24so11708134pfn.4 for ; Mon, 18 Nov 2019 23:12:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SOkEaxvoeuRDKKO9iEeAXK3d8jDrm2+Y0YFp9RHvoAo=; b=nuNOMTdV6cqA5xhs04CNCftYPLjSdTjJ0ePCPMCc3uiZcs4YCBMy9ZamdEurSipKqb B7qbTtqSkuv+cFtd5XGfPFzEAOygMAUU6PfcUq9+XWmSNfghnDQd5F7MZO2RpEtgPBO4 pY9GDSzO29EdOQ3rQOPPXttJfNyhL/qzEK/UbIBzD0EktqXFkIZukEz6uYOhqO/XpJSv CZVM33HewLSdQwXu5Sk//1CSz1ZkVkWtwDNAv2TM14cIkWzrIAXJHvymtQVGDfQtyKZ4 Gy6ZtONETM6pOH2ZXJaQ3hbDHkgWZ1LaHoK8pE6aiIh13lYEHwfU8H2bnK85SCTR2yLA qJ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=SOkEaxvoeuRDKKO9iEeAXK3d8jDrm2+Y0YFp9RHvoAo=; b=ih1Rd4ZMRSwsV2RWYZ8aQYNE0aR5rktV+RCMxsqx2/VlwL+gPP334yBj99ly75OWf0 BJBVqxg/Y+zT7N0GMmTkCW8iVAD+t7meIGplullVVEjp9IhFrsmbe/W6SB2Paap55n1I +QfbXDIlAx7hi6xET0XLDMdg0sZoF6YEl3Ja0MN1fAaEPwqDq14aqgDPgm3KrF1olbtV a7UVD19u6dSQRmilUvYz8O3AEFszQ8rHLpgKqdxdhzUcgYeqkGWGIXuEDhfHgfUlmZsy 5pf6iixuD3VuT2uHKT2Eke4phqhVFqvzd9rWnx4B7Low5W4slgBu7bgkqi57bqzwje+p vN1w== X-Gm-Message-State: APjAAAVeS9DCdENSVjcv1KfHSQkSARmrQHlhXBYrcT9zrlIE452l71DG gDEiuQDcVQvIdjfeutrRKvFdNQ== X-Google-Smtp-Source: APXvYqwFnemtfhSeFTtXNTKp5S2y3O1/8DNvV3VlNu9ve+aPwic4dTdlBLzDttqWkR7TRM8xvN2dTQ== X-Received: by 2002:a63:68c3:: with SMTP id d186mr3516436pgc.301.1574147559580; Mon, 18 Nov 2019 23:12:39 -0800 (PST) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id j7sm1931994pjz.12.2019.11.18.23.12.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Nov 2019 23:12:38 -0800 (PST) Date: Tue, 19 Nov 2019 16:13:42 +0900 From: AKASHI Takahiro To: Prabhakar Kushwaha Subject: Re: [PATCH v4 0/3] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs) Message-ID: <20191119071341.GW22427@linaro.org> Mail-Followup-To: AKASHI Takahiro , Prabhakar Kushwaha , Bhupesh Sharma , Linux Kernel Mailing List , Bhupesh SHARMA , Boris Petkov , Ingo Molnar , Thomas Gleixner , Jonathan Corbet , James Morse , Mark Rutland , Will Deacon , Steve Capper , Catalin Marinas , Ard Biesheuvel , Michael Ellerman , Paul Mackerras , Benjamin Herrenschmidt , Dave Anderson , Kazuhito Hagio , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Linux Doc Mailing List , kexec mailing list References: <1573459282-26989-1-git-send-email-bhsharma@redhat.com> <20191113063858.GE22427@linaro.org> <20191115015959.GI22427@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Linux Doc Mailing List , Bhupesh Sharma , Paul Mackerras , Will Deacon , Ingo Molnar , Jonathan Corbet , x86@kernel.org, Catalin Marinas , Boris Petkov , Thomas Gleixner , Bhupesh SHARMA , linux-arm-kernel , Kazuhito Hagio , Ard Biesheuvel , Steve Capper , kexec mailing list , Linux Kernel Mailing List , James Morse , Dave Anderson , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Prabhakar, On Tue, Nov 19, 2019 at 12:02:46PM +0530, Prabhakar Kushwaha wrote: > Hi Akashi, > > On Fri, Nov 15, 2019 at 7:29 AM AKASHI Takahiro > wrote: > > > > Bhupesh, > > > > On Fri, Nov 15, 2019 at 01:24:17AM +0530, Bhupesh Sharma wrote: > > > Hi Akashi, > > > > > > On Wed, Nov 13, 2019 at 12:11 PM AKASHI Takahiro > > > wrote: > > > > > > > > Hi Bhupesh, > > > > > > > > Do you have a corresponding patch for userspace tools, > > > > including crash util and/or makedumpfile? > > > > Otherwise, we can't verify that a generated core file is > > > > correctly handled. > > > > > > Sure. I am still working on the crash-utility related changes, but you > > > can find the makedumpfile changes I posted a couple of days ago here > > > (see [0]) and the github link for the makedumpfile changes can be seen > > > via [1]. > > > > > > I will post the crash-util changes shortly as well. > > > Thanks for having a look at the same. > > > > Thank you. > > I have tested my kdump patch with a hacked version of crash > > where VA_BITS_ACTUAL is calculated from tcr_el1_t1sz in vmcoreinfo. > > > > I also did hack to calculate VA_BITS_ACTUAL is calculated from > tcr_el1_t1sz in vmcoreinfo. Now i am getting error same as mentioned > by you in other thread last month. > https://www.mail-archive.com/crash-utility@redhat.com/msg07385.html > > how this error was overcome? > > I am using > - crashkernel: https://github.com/crash-utility/crash.git commit: > babd7ae62d4e8fd6f93fd30b88040d9376522aa3 > and > - Linux: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > commit: af42d3466bdc8f39806b26f593604fdc54140bcb # I am rather reluctant to cross-post non-kernel patch to lkml/lakml, The only change I made to crash utility was: ===8<=== diff --git a/arm64.c b/arm64.c index 5ee5f1a29a41..84e40aeb561b 100644 --- a/arm64.c +++ b/arm64.c @@ -3857,8 +3857,8 @@ arm64_calc_VA_BITS(void) } else if (ACTIVE()) error(FATAL, "cannot determine VA_BITS_ACTUAL: please use /proc/kcore\n"); else { - if ((string = pc->read_vmcoreinfo("NUMBER(VA_BITS_ACTUAL)"))) { - value = atol(string); + if ((string = pc->read_vmcoreinfo("NUMBER(tcr_el1_t1sz)"))) { + value = 64 - strtoll(string, NULL, 0); free(string); machdep->machspec->VA_BITS_ACTUAL = value; machdep->machspec->VA_BITS = value; ===>8=== Thanks, -Takahiro Akashi > --pk From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1836C432C0 for ; Tue, 19 Nov 2019 07:12:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BED84222DF for ; Tue, 19 Nov 2019 07:12:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BdHb7QCt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nuNOMTdV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BED84222DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ypemfkPvxfsqZSs514/FsZR9aFA4HXnUwuvyq0gfZ3E=; b=BdHb7QCtjzyXVK 29wptVAa1nEqBYdUcc31HcbklCffKqKD+jS2cTT72BFwUEV/E2l3A21CvXZ3StZmNlS0WH9CuOtYP YkfQVHIkyPYWA+XGv/eLR2tS70CKkYzIxs62fMoZB+uX/x6MjsF7H4y+zIAvvupj5elhdsdk9adx2 HCSTvq5WPy+l3qZY8cwCpiffXO0gbQEnCdHrBqcE1/wVrp7GrYYq0IvWPSmSLBL0KmbUqICvhK1BJ r6kybERczkYjOz85oDWDSFs0iQtX2hyITB3o1zzJ8EnsA0shCHqp3C7We+OoikIu8aX8ngdRQf64f NCSS2pxXroSdFl6nwhbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWxgs-0000qL-Fe; Tue, 19 Nov 2019 07:12:46 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWxgm-0000p8-VX for linux-arm-kernel@lists.infradead.org; Tue, 19 Nov 2019 07:12:45 +0000 Received: by mail-pg1-x543.google.com with SMTP id z188so10924762pgb.1 for ; Mon, 18 Nov 2019 23:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SOkEaxvoeuRDKKO9iEeAXK3d8jDrm2+Y0YFp9RHvoAo=; b=nuNOMTdV6cqA5xhs04CNCftYPLjSdTjJ0ePCPMCc3uiZcs4YCBMy9ZamdEurSipKqb B7qbTtqSkuv+cFtd5XGfPFzEAOygMAUU6PfcUq9+XWmSNfghnDQd5F7MZO2RpEtgPBO4 pY9GDSzO29EdOQ3rQOPPXttJfNyhL/qzEK/UbIBzD0EktqXFkIZukEz6uYOhqO/XpJSv CZVM33HewLSdQwXu5Sk//1CSz1ZkVkWtwDNAv2TM14cIkWzrIAXJHvymtQVGDfQtyKZ4 Gy6ZtONETM6pOH2ZXJaQ3hbDHkgWZ1LaHoK8pE6aiIh13lYEHwfU8H2bnK85SCTR2yLA qJ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=SOkEaxvoeuRDKKO9iEeAXK3d8jDrm2+Y0YFp9RHvoAo=; b=lEYyBQj38JI+ulobzkiFEQFKE5YD5E401zuedCCrd7/6cNgu2PugYQ05sUbs+7kt3I xLKXSceZUD+dXYnqlsNc+wDiwYgu5jhPCcdVK9MUnUVRJ9qhuRosYz6Q0rgezTb/SFBy 2Xb5+wcuuRyHmz2cMaNGM5UqPTI1Wq1xZJNHVefObxSeyaw6l8AQ04rJ6sHeYwnZO4Lh X0cjIwnYbszlKL4H4BlLLtA4KpbOmO+pLEOllmSN3kJff/pAIKSe7u5GUkoXszOJdyKC BBE2en5OpKhux6dy9iy/T1qzd+yXWFk2mpQwgIVadV58q6/kxRsMRfQakLxg6Hsz2cOn ZquQ== X-Gm-Message-State: APjAAAXKHcrlUdKew2B2VXSfWGp30435tvXbEBsHTv3H9hpetrC80CpJ 4e811QlYP7L6gaNBlAurKdnPSg== X-Google-Smtp-Source: APXvYqwFnemtfhSeFTtXNTKp5S2y3O1/8DNvV3VlNu9ve+aPwic4dTdlBLzDttqWkR7TRM8xvN2dTQ== X-Received: by 2002:a63:68c3:: with SMTP id d186mr3516436pgc.301.1574147559580; Mon, 18 Nov 2019 23:12:39 -0800 (PST) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id j7sm1931994pjz.12.2019.11.18.23.12.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Nov 2019 23:12:38 -0800 (PST) Date: Tue, 19 Nov 2019 16:13:42 +0900 From: AKASHI Takahiro To: Prabhakar Kushwaha Subject: Re: [PATCH v4 0/3] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs) Message-ID: <20191119071341.GW22427@linaro.org> Mail-Followup-To: AKASHI Takahiro , Prabhakar Kushwaha , Bhupesh Sharma , Linux Kernel Mailing List , Bhupesh SHARMA , Boris Petkov , Ingo Molnar , Thomas Gleixner , Jonathan Corbet , James Morse , Mark Rutland , Will Deacon , Steve Capper , Catalin Marinas , Ard Biesheuvel , Michael Ellerman , Paul Mackerras , Benjamin Herrenschmidt , Dave Anderson , Kazuhito Hagio , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Linux Doc Mailing List , kexec mailing list References: <1573459282-26989-1-git-send-email-bhsharma@redhat.com> <20191113063858.GE22427@linaro.org> <20191115015959.GI22427@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191118_231241_043604_FEEDC831 X-CRM114-Status: GOOD ( 24.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Linux Doc Mailing List , Benjamin Herrenschmidt , Bhupesh Sharma , Paul Mackerras , Will Deacon , Ingo Molnar , Jonathan Corbet , Michael Ellerman , x86@kernel.org, Catalin Marinas , Boris Petkov , Thomas Gleixner , Bhupesh SHARMA , linux-arm-kernel , Kazuhito Hagio , Ard Biesheuvel , Steve Capper , kexec mailing list , Linux Kernel Mailing List , James Morse , Dave Anderson , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, On Tue, Nov 19, 2019 at 12:02:46PM +0530, Prabhakar Kushwaha wrote: > Hi Akashi, > > On Fri, Nov 15, 2019 at 7:29 AM AKASHI Takahiro > wrote: > > > > Bhupesh, > > > > On Fri, Nov 15, 2019 at 01:24:17AM +0530, Bhupesh Sharma wrote: > > > Hi Akashi, > > > > > > On Wed, Nov 13, 2019 at 12:11 PM AKASHI Takahiro > > > wrote: > > > > > > > > Hi Bhupesh, > > > > > > > > Do you have a corresponding patch for userspace tools, > > > > including crash util and/or makedumpfile? > > > > Otherwise, we can't verify that a generated core file is > > > > correctly handled. > > > > > > Sure. I am still working on the crash-utility related changes, but you > > > can find the makedumpfile changes I posted a couple of days ago here > > > (see [0]) and the github link for the makedumpfile changes can be seen > > > via [1]. > > > > > > I will post the crash-util changes shortly as well. > > > Thanks for having a look at the same. > > > > Thank you. > > I have tested my kdump patch with a hacked version of crash > > where VA_BITS_ACTUAL is calculated from tcr_el1_t1sz in vmcoreinfo. > > > > I also did hack to calculate VA_BITS_ACTUAL is calculated from > tcr_el1_t1sz in vmcoreinfo. Now i am getting error same as mentioned > by you in other thread last month. > https://www.mail-archive.com/crash-utility@redhat.com/msg07385.html > > how this error was overcome? > > I am using > - crashkernel: https://github.com/crash-utility/crash.git commit: > babd7ae62d4e8fd6f93fd30b88040d9376522aa3 > and > - Linux: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > commit: af42d3466bdc8f39806b26f593604fdc54140bcb # I am rather reluctant to cross-post non-kernel patch to lkml/lakml, The only change I made to crash utility was: ===8<=== diff --git a/arm64.c b/arm64.c index 5ee5f1a29a41..84e40aeb561b 100644 --- a/arm64.c +++ b/arm64.c @@ -3857,8 +3857,8 @@ arm64_calc_VA_BITS(void) } else if (ACTIVE()) error(FATAL, "cannot determine VA_BITS_ACTUAL: please use /proc/kcore\n"); else { - if ((string = pc->read_vmcoreinfo("NUMBER(VA_BITS_ACTUAL)"))) { - value = atol(string); + if ((string = pc->read_vmcoreinfo("NUMBER(tcr_el1_t1sz)"))) { + value = 64 - strtoll(string, NULL, 0); free(string); machdep->machspec->VA_BITS_ACTUAL = value; machdep->machspec->VA_BITS = value; ===>8=== Thanks, -Takahiro Akashi > --pk _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel