From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: netdev@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net 1/1] mdio_bus: fix mdio_register_device when RESET_CONTROLLER is disabled
Date: Tue, 19 Nov 2019 12:27:44 +0200 [thread overview]
Message-ID: <20191119102744.GD32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191118181505.32298-1-marek.behun@nic.cz>
On Mon, Nov 18, 2019 at 07:15:05PM +0100, Marek Behún wrote:
> When CONFIG_RESET_CONTROLLER is disabled, the
> devm_reset_control_get_exclusive function returns -ENOTSUPP. This is not
> handled in subsequent check and then the mdio device fails to probe.
>
> When CONFIG_RESET_CONTROLLER is enabled, its code checks in OF for reset
> device, and since it is not present, returns -ENOENT. -ENOENT is handled.
> Add -ENOTSUPP also.
>
> This happened to me when upgrading kernel on Turris Omnia. You either
> have to enable CONFIG_RESET_CONTROLLER or use this patch.
In the long term prospective shouldn't it use
reset_control_get_optional_exclusive() instead?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-11-19 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 18:15 [PATCH net 1/1] mdio_bus: fix mdio_register_device when RESET_CONTROLLER is disabled Marek Behún
2019-11-18 23:38 ` Andrew Lunn
2019-11-19 2:00 ` David Miller
2019-11-19 10:27 ` Andy Shevchenko [this message]
2019-11-20 10:36 ` Geert Uytterhoeven
2019-11-20 10:42 ` Geert Uytterhoeven
2019-11-21 2:08 ` Andrew Lunn
2019-11-21 8:38 ` David Bauer
2019-11-21 8:40 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119102744.GD32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=dmitry.torokhov@gmail.com \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.