From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Markus Theil <markus.theil@tu-ilmenau.de>,
nbd@nbd.name, linux-wireless@vger.kernel.org,
lorenzo.bianconi@redhat.com
Subject: Re: [PATCH 3/4] mt76: speed up usb bulk copy
Date: Tue, 19 Nov 2019 11:58:37 +0100 [thread overview]
Message-ID: <20191119105832.GA22415@redhat.com> (raw)
In-Reply-To: <20191116114312.GC20820@localhost.localdomain>
On Sat, Nov 16, 2019 at 01:43:12PM +0200, Lorenzo Bianconi wrote:
> > + memcpy(usb->data, val + i, current_batch_size);
> > ret = __mt76u_vendor_request(dev, MT_VEND_MULTI_WRITE,
> > USB_DIR_OUT | USB_TYPE_VENDOR,
> > - 0, offset + i * 4, usb->data,
> > - sizeof(u32));
> > + 0, offset + i, usb->data,
> > + current_batch_size);
>
> @Stanislaw: I vaguely remember you reported some issues if the burst size
> is greater than 4B (but I can be wrong)
It didn't work as usb vendor requests which were not multiple of 4
were not transferred to the device on some usb host. But this is
properly handled by the latest version of this patch set.
Stanislaw
next prev parent reply other threads:[~2019-11-19 10:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 11:17 [PATCH 0/4] mt76: channel switch support for USB devices Markus Theil
2019-11-16 11:17 ` [PATCH 1/4] mt76: mt76x02: ommit beacon slot clearing Markus Theil
2019-11-16 11:44 ` Markus Theil
2019-11-16 11:17 ` [PATCH 2/4] mt76: mt76x02: split beaconing Markus Theil
2019-11-16 12:51 ` Lorenzo Bianconi
2019-11-16 11:17 ` [PATCH 3/4] mt76: speed up usb bulk copy Markus Theil
2019-11-16 11:43 ` Lorenzo Bianconi
2019-11-19 10:58 ` Stanislaw Gruszka [this message]
2019-11-16 11:17 ` [PATCH 4/4] mt76: mt76x02: add channel switch support for usb interfaces Markus Theil
2019-11-16 11:45 ` Lorenzo Bianconi
2019-11-16 12:13 ` Markus Theil
2019-11-16 12:43 ` Lorenzo Bianconi
2019-11-17 3:44 ` kbuild test robot
2019-11-17 3:44 ` kbuild test robot
2019-11-17 3:44 ` [RFC PATCH] mt76: mt76x02: mt76x2u_channel_switch_beacon() can be static kbuild test robot
2019-11-17 3:44 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119105832.GA22415@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=markus.theil@tu-ilmenau.de \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.