From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] efi_loader: restrict EFI_LOADER to armv7 and armv8 on ARM
Date: Tue, 19 Nov 2019 10:30:03 -0500 [thread overview]
Message-ID: <20191119153003.GC19317@bill-the-cat> (raw)
In-Reply-To: <20191117100040.8682-1-xypron.glpk@gmx.de>
On Sun, Nov 17, 2019 at 11:00:40AM +0100, Heinrich Schuchardt wrote:
> fatload USB was reported to fail on the Sheevaplug. Debugging showed that
> this was caused by an incorrect unaligned write to memory in
> path_to_uefi().
>
> UEFI on ARM requires that unaligned memory access is enabled.
>
> * ARMv5 does not support unaligned access at all.
> * ARMv6 supports unaligned access when we clear the A flag and set the
> U flag.
> * On ARMv7 unaligned access is possible when clearing the aligned flag,
> which we do in function allow_unaligned() (arch/arm/cpu/armv7/sctlr.S).
> For none of the other cpus in arch/arm/cpu/ we have implemented a
> similar function.
> * ARMv8 allows unaligned access.
>
> Let EFI_LOADER on ARM depend on SYS_CPU=armv7 or SYS_CPU=armv8.
>
> Once we have implemented allow_unaligned() for other ARM CPUs we can add
> these to Kconfig.
>
> Reported-by: Gray Remlin <gryrmln@gmail.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191119/cad063ef/attachment.sig>
prev parent reply other threads:[~2019-11-19 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 10:00 [U-Boot] [PATCH 1/1] efi_loader: restrict EFI_LOADER to armv7 and armv8 on ARM Heinrich Schuchardt
2019-11-19 15:30 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119153003.GC19317@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.