From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available Date: Tue, 19 Nov 2019 08:30:13 -0800 Message-ID: <20191119163013.GK35479@atomide.com> References: <20191118165236.22136-1-afd@ti.com> <20191118215759.GD35479@atomide.com> <20191118223128.GE35479@atomide.com> <29db708e-119e-8a89-7d43-e38e2a10dc07@ti.com> <20191119162157.GJ35479@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191119162157.GJ35479@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: "Andrew F. Davis" Cc: Mark Rutland , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org * Tony Lindgren [191119 16:22]: > * Andrew F. Davis [191119 01:14]: > > A generic smc() call would be nice, but arm_smccc_smc() is specifically > > for SMCCC. > > To me it seeems that HAVE_ARM_SMCCC is a generic feature though. > It's not limited to OPTEE. We have select HAVE_ARM_SMCCC if CPU_V7 > in arch/arm/Kconfig, and OPTEE depends on HAVE_ARM_SMCCC. > > From that point of view it seems that we could have HAVE_ARM_SMCCC > enabled also for v6 and use it for all mach-omap2 with a wrapper. In the omap_smc1 case it seems that we can just unconditionally change the callers to use arm_smccc_smc() instead of omap_smc1 and get rid of it. It's only used by v7 SMP related stuff based on grepping for it. > So I'd like to have our smc callers eventually just call generic > generic arm_smccc_smc(OMAP_SIP_SMC_STD_CALL_VAL(fn)...) rather > than the custom calls. And we want to update to using the generic > functions one case at a time as the features get tested :) Sounds like the others can be then done one at a time as needed :) Regards, Tony