Re: [PATCH v6 2/2] RDMA/cma: Add trace points in RDMA Connection Manager

[Jason Gunthorpe <jgg@ziepe.ca>]

On Tue, Nov 19, 2019 at 07:10:03AM -0500, Chuck Lever wrote:
> >> diff --git a/include/trace/events/rdma_cma.h b/include/trace/events/rdma_cma.h
> >> new file mode 100644
> >> index 000000000000..b6ccdade651c
> >> +++ b/include/trace/events/rdma_cma.h
> >> @@ -0,0 +1,218 @@
> >> +/* SPDX-License-Identifier: GPL-2.0-only */
> >> +/*
> >> + * Trace point definitions for the RDMA Connect Manager.
> >> + *
> >> + * Author: Chuck Lever <chuck.lever@oracle.com>
> >> + *
> >> + * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
> >> + */
> >> +
> >> +#undef TRACE_SYSTEM
> >> +#define TRACE_SYSTEM rdma_cma
> >> +
> >> +#if !defined(_TRACE_RDMA_CMA_H) || defined(TRACE_HEADER_MULTI_READ)
> >> +
> >> +#define _TRACE_RDMA_CMA_H
> >> +
> >> +#include <linux/tracepoint.h>
> >> +#include <rdma/rdma_cm.h>
> >> +#include "cma_priv.h"
> > 
> > Did it compile?
> 
> Yes, it compiles for me, and passes lkp as well.
> 
>  I admit though that it seems like a brittle arrangement. Might be
>  better off moving rdma_cma.h to drivers/infiniband/core/ .

The more headers that can move out of include the better, IMHO

Jason