From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Danit Goldberg <danitg@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Parav Pandit <parav@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>
Subject: Re: [PATCH rdma-next] IB/mlx4: Update HW GID table while adding vlan GID
Date: Tue, 19 Nov 2019 16:04:01 -0400 [thread overview]
Message-ID: <20191119200401.GA24934@ziepe.ca> (raw)
In-Reply-To: <20191115154457.247763-1-leon@kernel.org>
On Fri, Nov 15, 2019 at 05:44:57PM +0200, Leon Romanovsky wrote:
> From: Danit Goldberg <danitg@mellanox.com>
>
> While adding new GID, besides comparing GID and type, compare also vlan
> id, so vlan GIDs will also be updated in HW GID table although they
> have same GID as the default GID.
>
> Signed-off-by: Danit Goldberg <danitg@mellanox.com>
> Reviewed-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx4/main.c | 9 ++++++++-
> drivers/infiniband/hw/mlx4/mlx4_ib.h | 1 +
> 2 files changed, 9 insertions(+), 1 deletion(-)
I'm going to apply this because of the bug fix, but this design in
mlx4 looks wrong to me? The core gid cache is supposed to manage the
gid table completely, and the driver should not be doing searching
when the core says to change a table entry. What is going on here?
The core code already removes duplicates
Parav?
Jason
prev parent reply other threads:[~2019-11-19 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 15:44 [PATCH rdma-next] IB/mlx4: Update HW GID table while adding vlan GID Leon Romanovsky
2019-11-19 20:04 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119200401.GA24934@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=danitg@mellanox.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.